From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Paulo Marques" <pmarques@grupopie.com>
Cc: "Vegard Nossum" <vegard.nossum@gmail.com>,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kallsyms: fix potential overflow in binary search
Date: Wed, 14 May 2008 15:22:00 +0300 [thread overview]
Message-ID: <84144f020805140522m6136ff69w7ffa6f9c9248706f@mail.gmail.com> (raw)
In-Reply-To: <482AD08D.7070206@grupopie.com>
On Wed, May 14, 2008 at 2:44 PM, Paulo Marques <pmarques@grupopie.com> wrote:
> > This will probably never trigger... but it won't hurt to be careful.
>
> Not "probably", this will never trigger _period_. If you ever have more
> than 2^31 symbols in the kernel's kallsyms table you'll have worse problems
> to worry about than the binary search overflowing.
>
> So, I don't think it is worth this des-optimization at all...
Yes it is. It serves as correct reference code and the
"deoptimization" is not measurable.
next prev parent reply other threads:[~2008-05-14 12:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-13 20:07 Vegard Nossum
2008-05-14 11:44 ` Paulo Marques
2008-05-14 12:22 ` Pekka Enberg [this message]
2008-05-14 14:24 ` Paulo Marques
2008-05-14 15:31 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020805140522m6136ff69w7ffa6f9c9248706f@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®