mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Paul Mundt" <lethal@linux-sh.org>,
	"Pekka J Enberg" <penberg@cs.helsinki.fi>,
	"David Howells" <dhowells@redhat.com>,
	"Christoph Lameter" <clameter@sgi.com>,
	LKML <linux-kernel@vger.kernel.org>,
	cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com
Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB
Date: Mon, 2 Jun 2008 09:32:48 +0300	[thread overview]
Message-ID: <84144f020806012332n47ba7a7eg37a6892dbb059d09@mail.gmail.com> (raw)
In-Reply-To: <20080602055922.GA24626@linux-sh.org>

Hi Paul,

On Mon, Jun 2, 2008 at 8:59 AM, Paul Mundt <lethal@linux-sh.org> wrote:
> In the kmem_cache_alloc() case calling ksize() there is bogus, the
> previous semantics for kobjsize() just defaulted to returning PAGE_SIZE
> for these, since page->index was typically 0. Presently if we ksize()
> those objects, we get bogus size results that are smaller than the
> minimum alignment size. So we still need a way to handle that, even if
> it's not frightfully accurate.
>
> If we go back and apply your PG_slab patch for SLUB + SLOB, then
> kobjsize() can just become:

What call-sites are using kmem_cache_alloc()? Can we convert them to
kmalloc() or page_alloc()? IIRC both Christoph and Matt opposed my
PG_slab patches.

  reply	other threads:[~2008-06-02  6:32 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0805281646470.27125@sbz-30.cs.Helsinki.FI>
     [not found] ` <20080528153648.GA27783@linux-sh.org>
2008-05-28 20:03   ` Pekka Enberg
2008-05-28 20:25     ` Christoph Lameter
2008-05-28 20:25       ` Pekka Enberg
2008-05-28 20:29         ` Christoph Lameter
2008-05-29 13:08         ` David Howells
2008-05-29 13:21           ` Pekka J Enberg
2008-05-29 21:12             ` Paul Mundt
2008-06-01  7:58               ` Pekka Enberg
2008-06-01  8:22                 ` Pekka J Enberg
2008-06-01  8:24                   ` Paul Mundt
2008-06-01  8:36                     ` Pekka J Enberg
2008-06-01  9:13                     ` Pekka J Enberg
2008-06-01 10:24                       ` Paul Mundt
2008-06-01 10:29                         ` Pekka Enberg
2008-06-01 11:21                           ` Paul Mundt
2008-06-01 11:30                             ` Pekka J Enberg
2008-06-02  5:59                               ` Paul Mundt
2008-06-02  6:32                                 ` Pekka Enberg [this message]
2008-06-02  6:50                                   ` Paul Mundt
2008-06-02  6:58                                     ` Pekka Enberg
2008-06-02  7:01                                       ` Paul Mundt
2008-06-01  8:22                 ` Paul Mundt
2008-05-29 15:00           ` Christoph Lameter
2008-05-22 16:09 Pekka J Enberg
2008-05-22 16:48 ` Christoph Lameter
2008-05-22 23:40 ` Paul Mundt
2008-05-22 23:45   ` Christoph Lameter
2008-05-22 23:50     ` Paul Mundt
2008-05-23  0:04       ` Christoph Lameter
2008-05-28 13:12 ` David Howells
2008-05-28 13:17   ` Pekka J Enberg
2008-05-28 13:40   ` David Howells
2008-05-28 14:09 ` David Howells
2008-05-28 17:26   ` Christoph Lameter
2008-05-28 17:38   ` David Howells
2008-05-28 20:35     ` Mike Frysinger
2008-05-29 13:03     ` David Howells
2008-05-29 20:25       ` Mike Frysinger
2008-05-29 20:30         ` Christoph Lameter
2008-05-29 20:51           ` Mike Frysinger
2008-05-29 21:29             ` Christoph Lameter
2008-05-30  4:18               ` Mike Frysinger
2008-05-28 14:27 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020806012332n47ba7a7eg37a6892dbb059d09@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=cooloney@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®