From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758063AbYFBG6T (ORCPT ); Mon, 2 Jun 2008 02:58:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757951AbYFBG6E (ORCPT ); Mon, 2 Jun 2008 02:58:04 -0400 Received: from rv-out-0506.google.com ([209.85.198.226]:10572 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751723AbYFBG6B (ORCPT ); Mon, 2 Jun 2008 02:58:01 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=Y0L+GF9BQPxrA9/TEikeBn6XDWa9fX/UoQatcXxRKlyp4hBs0jfHdjhcijZ3Wa/x8IObCW2YS9TOmvVGf2ppOs1Ep76kPp6tnsngzpgV0Lnt4M+NPLOUQAO/niCm3tQqFeesk12yTzW3wn8VYLs7TCRbKtRLrPsnOldiJTTnsyI= Message-ID: <84144f020806012358y6a2e5707odca7216a72e4092f@mail.gmail.com> Date: Mon, 2 Jun 2008 09:58:01 +0300 From: "Pekka Enberg" To: "Paul Mundt" , "Pekka Enberg" , "David Howells" , "Christoph Lameter" , LKML , cooloney@kernel.org, akpm@linux-foundation.org, mpm@selenic.com Subject: Re: [PATCH] nommu: fix kobjsize() for SLOB and SLUB In-Reply-To: <20080602065055.GA27293@linux-sh.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <484256AA.3000709@cs.helsinki.fi> <20080601082427.GC25429@linux-sh.org> <20080601102401.GD25429@linux-sh.org> <48427A13.7050704@cs.helsinki.fi> <20080601112137.GE25429@linux-sh.org> <20080602055922.GA24626@linux-sh.org> <84144f020806012332n47ba7a7eg37a6892dbb059d09@mail.gmail.com> <20080602065055.GA27293@linux-sh.org> X-Google-Sender-Auth: 4a06708a2686b002 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On Mon, Jun 2, 2008 at 9:50 AM, Paul Mundt wrote: > Well, with that modified version of your patch I posted, even if your > previous PG_slab patches aren't applied, kobjsize() doesn't behave any > worse than it presently does in terms of object size accuracy. > > In short: PG_slab doesn't get set and ksize() is never called, so we get > the same degree of accuracy as the existing implementation, and the > oopses get fixed (and the comments are still accurate, too!). So I think > it's worth applying. Verified on all of SLUB/SLOB/SLAB. Agreed. Can you send this to Andrew? Reviewed-by: Pekka Enberg On Mon, Jun 2, 2008 at 9:50 AM, Paul Mundt wrote: > As for the call-site question, perhaps I'm misunderstanding your > question. alloc_vfsmnt() is the first to call kmem_cache_zalloc() during > boot-up on my system, but I'm not sure what relevance this has to > anything? Accurately measuring kmem_cache_alloc() and static allocations > is going to need quite a bit more of a re-think, but that's out of scope > for 2.6.26. Presently I'd rather have my system booting first :-) David already mentioned some (most?) of the kobjsize() calls can go away and I think we should pursue that for 2.6.27.