mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "FUJITA Tomonori" <fujita.tomonori@lab.ntt.co.jp>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH -mm] clean up duplicated alloc/free_thread_info
Date: Tue, 3 Jun 2008 09:06:26 +0300	[thread overview]
Message-ID: <84144f020806022306h236a48cbv32b82cfa83fe4ee6@mail.gmail.com> (raw)
In-Reply-To: <20080603140620S.fujita.tomonori@lab.ntt.co.jp>

On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> Is there a reason we duplicate alloc/free_thread_info defines on many
> platforms?

No. The patch looks good.

On Tue, Jun 3, 2008 at 8:02 AM, FUJITA Tomonori
<fujita.tomonori@lab.ntt.co.jp> wrote:
> Note:
>
> - I don't like __HAVE_ARCH_THREAD_INFO_ALLOCATOR name much. I chose
> that name just because we define __HAVE_ARCH_TASK_STRUCT_ALLOCATOR in
> the same place.
>
> - frv, m32r, mips, mn10300, and sh uses kmalloc/kfree instead of
> __get_free_pages/free_pages. I let them alone but it could remove more
> code if __get_free_pages/free_pages works for them.

Yeah, I too have wondered why some architectures use kmalloc() whereas
others use the page allocator. Is THREAD_SIZE significantly smaller
than PAGE_SIZE for those?

  reply	other threads:[~2008-06-03  6:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-03  5:02 FUJITA Tomonori
2008-06-03  6:06 ` Pekka Enberg [this message]
2008-06-03  6:42   ` Paul Mackerras
2008-06-03 22:58     ` FUJITA Tomonori
2008-06-03  8:22 ` Russell King
2008-06-03  9:14 ` David Howells
2008-06-03 22:58   ` FUJITA Tomonori
2008-06-03 10:31 ` Haavard Skinnemoen
2008-06-03 22:58   ` FUJITA Tomonori
2008-06-04  8:46     ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84144f020806022306h236a48cbv32b82cfa83fe4ee6@mail.gmail.com \
    --to=penberg@cs.helsinki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®