From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Christoph Lameter" <cl@linux-foundation.org>
Cc: "Matt Mackall" <mpm@selenic.com>,
"Yoichi Yuasa" <yoichi_yuasa@tripeaks.co.jp>,
linux-kernel@vger.kernel.org
Subject: Re: slub: Do not use 192 byte sized cache if minimum alignment is 128 byte
Date: Thu, 3 Jul 2008 18:37:52 +0300 [thread overview]
Message-ID: <84144f020807030837k213e1880vf2d01bcf77e6886c@mail.gmail.com> (raw)
In-Reply-To: <486CDEC2.5030803@linux-foundation.org>
On Thu, Jul 3, 2008 at 5:14 PM, Christoph Lameter
<cl@linux-foundation.org> wrote:
> The 192 byte cache is not necessary if we have a basic alignment of 128
> byte. If it would be used then the 192 would be aligned to the next 128 byte
> boundary which would result in another 256 byte cache. Two 256 kmalloc caches
> cause sysfs to complain about a duplicate entry.
>
> MIPS needs 128 byte aligned kmalloc caches and spits out warnings on boot without
> this patch.
>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Looks good to me. Yoichi, did you have the chance to test this?
Christoph, are the warnings harmless or do we need to get this into
2.6.26?
next prev parent reply other threads:[~2008-07-03 15:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 14:14 Christoph Lameter
2008-07-03 15:37 ` Pekka Enberg [this message]
2008-07-03 16:09 ` Christoph Lameter
2008-07-04 0:28 ` Yoichi Yuasa
2008-07-04 7:38 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020807030837k213e1880vf2d01bcf77e6886c@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®