From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Pavel Machek" <pavel@suse.cz>
Cc: greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] w35und: plug memory leak in wbsoft_tx()
Date: Tue, 28 Oct 2008 23:08:50 +0200 [thread overview]
Message-ID: <84144f020810281408g4adda06em5cd7a620bf837b53@mail.gmail.com> (raw)
In-Reply-To: <20081028193204.GI16452@elf.ucw.cz>
On Tue 2008-10-28 00:14:38, Pekka J Enberg wrote:
>> From: Pekka Enberg <penberg@cs.helsinki.fi>
>>
>> There's no reason to duplicate the skb in wbsoft_tx() and leak GFP_ATOMIC
>> memory as the contents are copied to ->TxBuffer in MdxTx() anyway before
>> MLMESendFrame() returns.
On Tue, Oct 28, 2008 at 9:32 PM, Pavel Machek <pavel@suse.cz> wrote:
> Acked-by: Pavel Machek <pavel@suse.cz>
>
> ...but I guess I should test the this after it hits the mainline...
For sure. I'm bit surprised no one noticed this before as it seems to
be leaking memory for every transmitted frame...
next prev parent reply other threads:[~2008-10-28 21:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 22:14 Pekka J Enberg
2008-10-28 19:32 ` Pavel Machek
2008-10-28 21:08 ` Pekka Enberg [this message]
2008-10-30 14:55 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020810281408g4adda06em5cd7a620bf837b53@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®