From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Guennadi Liakhovetski" <lg@denx.de>
Cc: "Johannes Weiner" <hannes@cmpxchg.org>,
linux-kernel@vger.kernel.org,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] bitmap: fix bitmap_find_free_region()
Date: Fri, 19 Dec 2008 15:59:53 +0200 [thread overview]
Message-ID: <84144f020812190559y2bf4ac9am695f3d35941fa7ed@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812191413520.4536@axis700.grange>
On Fri, 19 Dec 2008, Johannes Weiner wrote:
>> And return -ENOSPC?
On Fri, Dec 19, 2008 at 3:18 PM, Guennadi Liakhovetski <lg@denx.de> wrote:
> So, you agree that a check should be added to bitmap_find_free_region()?
> As for details - to warn or not to warn and what error code to return,
> that can be discussed, although "No space left on device" doesn't seem to
> fit very well IMHO:-)
Yeah, but ENOMEM, on the other had, is mostly for out-of-memory
conditions so EINVAL might be more appropriate.
next prev parent reply other threads:[~2008-12-19 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-19 11:26 Guennadi Liakhovetski
2008-12-19 13:02 ` Johannes Weiner
2008-12-19 13:18 ` Guennadi Liakhovetski
2008-12-19 13:59 ` Pekka Enberg [this message]
2008-12-19 14:47 ` Johannes Weiner
2008-12-19 15:09 ` Guennadi Liakhovetski
2008-12-19 22:45 ` Johannes Weiner
2008-12-19 23:19 ` Guennadi Liakhovetski
2008-12-20 11:34 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020812190559y2bf4ac9am695f3d35941fa7ed@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=lg@denx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®