From: "Pekka Enberg" <penberg@cs.helsinki.fi>
To: "Phillip Lougher" <phillip@lougher.demon.co.uk>
Cc: akpm@linux-foundation.org, linux-embedded@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.bird@am.sony.com, sfr@canb.auug.org.au
Subject: Re: [PATCH V3 12/17] Squashfs: header files
Date: Mon, 5 Jan 2009 15:32:13 +0200 [thread overview]
Message-ID: <84144f020901050532m3c8a4d68q655514051d4e259a@mail.gmail.com> (raw)
In-Reply-To: <E1LJnJo-0002Lz-2y@dylan.lougher.demon.co.uk>
Hi Phillip,
On Mon, Jan 5, 2009 at 1:08 PM, Phillip Lougher
<phillip@lougher.demon.co.uk> wrote:
> +#define TRACE(s, args...) pr_debug("SQUASHFS: "s, ## args)
You've probably heard this before but silly "tracing" such as:
TRACE("Entered squashfs_fill_superblock\n");
should really be removed from the filesystem code.
> +#define ERROR(s, args...) pr_err("SQUASHFS error: "s, ## args)
> +
> +#define WARNING(s, args...) pr_warning("SQUASHFS: "s, ## args)
I think you're supposed to #define pr_fmt() in your header instead of
adding wrappers like these.
Pekka
prev parent reply other threads:[~2009-01-05 13:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 11:08 Phillip Lougher
2009-01-05 13:32 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020901050532m3c8a4d68q655514051d4e259a@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
--cc=sfr@canb.auug.org.au \
--cc=tim.bird@am.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®