From: Pekka Enberg <penberg@cs.helsinki.fi>
To: David Rientjes <rientjes@google.com>
Cc: Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [patch 1/2] slub: rename cpuslab_flush to cpu_slab_flush
Date: Thu, 23 Apr 2009 22:39:39 +0300 [thread overview]
Message-ID: <84144f020904231239i813959dobe85b8c56cbf8887@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.0904231136390.20852@chino.kir.corp.google.com>
Hi David,
On Thu, Apr 23, 2009 at 9:38 PM, David Rientjes <rientjes@google.com> wrote:
> There is already a `cpu_slabs' file to display the number of cpu slabs,
> so cpuslab_flush should follow this pattern.
>
> The first documentation of this file will be in a subsequent patch that
> adds Documentation/ABI/testing/sysfs-kernel-slab, so no stable guarantee
> has been made that the name of this file would not change.
I'm afraid I don't have enough asbestos in my underwear to try to
sneak this one past Linus.
A kernel ABI is an ABI even if it's not documented. Now, I wouldn't
mind getting flamed if we actually gained something from the change.
But just fixing a simple typo in sysfs files is not big enough a
reason for me to merge the patch.
That said, I love the second patch though and am more than happy to take it.
Pekka
prev parent reply other threads:[~2009-04-23 19:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-23 18:38 David Rientjes
2009-04-23 18:38 ` [patch 2/2] slub: add Documentation/ABI/testing/sysfs-kernel-slab David Rientjes
2009-04-23 18:52 ` Christoph Lameter
2009-04-24 23:26 ` [patch] " David Rientjes
2009-04-27 14:09 ` Christoph Lameter
2009-04-28 11:32 ` Pekka Enberg
2009-04-23 22:26 ` [patch 2/2] " David Rientjes
2009-04-23 22:31 ` Christoph Lameter
2009-04-23 22:52 ` David Rientjes
2009-04-23 22:55 ` Christoph Lameter
2009-04-24 23:35 ` David Rientjes
2009-04-23 19:39 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020904231239i813959dobe85b8c56cbf8887@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®