From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Nick Piggin <npiggin@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] SLQB: Coding style cleanups
Date: Tue, 5 May 2009 11:37:32 +0300 [thread overview]
Message-ID: <84144f020905050137k692fb9d6l3f25a03b12b65333@mail.gmail.com> (raw)
In-Reply-To: <20090505082545.GE30220@wotan.suse.de>
Hi Nick,
On Tue, May 5, 2009 at 11:25 AM, Nick Piggin <npiggin@suse.de> wrote:
>> @@ -59,7 +59,7 @@ static inline void struct_slqb_page_wrong_size(void)
>> /*
>> * slqb_min_order: minimum allocation order for slabs
>> */
>> -static int slqb_min_order = 0;
>> +static int slqb_min_order;
>
> I actually like explicit zero initializers. I think it has been
> a long time since this actually saved any memory with gcc.
>
> Yes yes, I know that anybody who can "read C" will read the
> implicit zero initializer anyway... however I just think it is
> a stupid thing for checkpatch to warn against.
OK. I guess I can drop those hunks. But from coding style of point
view we don't really do explicit zero initializers in the core
kernel...
Pekka
next prev parent reply other threads:[~2009-05-05 8:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 12:15 Pekka J Enberg
2009-05-05 8:25 ` Nick Piggin
2009-05-05 8:37 ` Pekka Enberg [this message]
2009-05-05 9:17 ` Nick Piggin
2009-05-05 12:18 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020905050137k692fb9d6l3f25a03b12b65333@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®