From: Pekka Enberg <penberg@cs.helsinki.fi>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] mm/slub.c: change printk()s to pr_*() notation
Date: Wed, 20 May 2009 15:33:13 +0300 [thread overview]
Message-ID: <84144f020905200533j2e1debc1i97e0dbb96ef0edf6@mail.gmail.com> (raw)
In-Reply-To: <200905191103.03749.hartleys@visionengravers.com>
On Tue, May 19, 2009 at 9:03 PM, H Hartley Sweeten
<hartleys@visionengravers.com> wrote:
> Change all the printk()s in mm/slub.c to the pr_*() notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 65ffda5..2805b7f 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -338,25 +338,25 @@ static void print_section(char *text, u8 *addr, unsigned int length)
>
> for (i = 0; i < length; i++) {
> if (newline) {
> - printk(KERN_ERR "%8s 0x%p: ", text, addr + i);
> + pr_err("%8s 0x%p: ", text, addr + i);
Hmm, isn't the whole point of pr_err() that you override pr_fmt() to
include your subsystem name?
next prev parent reply other threads:[~2009-05-20 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-19 18:03 H Hartley Sweeten
2009-05-19 20:54 ` Joe Perches
2009-05-19 21:53 ` H Hartley Sweeten
2009-05-20 12:33 ` Pekka Enberg [this message]
2009-05-20 15:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020905200533j2e1debc1i97e0dbb96ef0edf6@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=cl@linux-foundation.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®