From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932481AbZHDGmt (ORCPT ); Tue, 4 Aug 2009 02:42:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932472AbZHDGms (ORCPT ); Tue, 4 Aug 2009 02:42:48 -0400 Received: from mail-bw0-f219.google.com ([209.85.218.219]:62515 "EHLO mail-bw0-f219.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932248AbZHDGmq convert rfc822-to-8bit (ORCPT ); Tue, 4 Aug 2009 02:42:46 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=llS89dxFuaml3akC38kQqwgNq9/EE5bwxOtzK1SvEWdnnAmZTW4ItB+7UIsziWJmRL EHvpVyB0RVAqo1+6dvUfzLlt4ockJTigl4tTTNfhsm2QHOQmOevoiG7f1VX9HcoYRR9x 74lxRghNh/LEK8MxZBLfD/qGhtrnpU/jeWgHY= MIME-Version: 1.0 In-Reply-To: <20090804121259.d0c4e202.kamezawa.hiroyu@jp.fujitsu.com> References: <200907301204.n6UC4Saf019612@imap1.linux-foundation.org> <20090804121259.d0c4e202.kamezawa.hiroyu@jp.fujitsu.com> Date: Tue, 4 Aug 2009 09:42:46 +0300 X-Google-Sender-Auth: a6f55f7b1bdc2ce0 Message-ID: <84144f020908032342w51337862m5879f98cf297f889@mail.gmail.com> Subject: Re: mmotm 2009-07-30-05-01 uploaded From: Pekka Enberg To: KAMEZAWA Hiroyuki Cc: npiggin@suse.de, linux-kernel@vger.kernel.org, "akpm@linux-foundation.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kame, On Tue, Aug 4, 2009 at 6:12 AM, KAMEZAWA Hiroyuki wrote: > On Thu, 30 Jul 2009 05:04:28 -0700 > akpm@linux-foundation.org wrote: > >> The mm-of-the-moment snapshot 2009-07-30-05-01 has been uploaded to >> >>    http://userweb.kernel.org/~akpm/mmotm/ >> >> and will soon be available at >> >>    git://git.zen-sources.org/zen/mmotm.git >> > > I'm sorry if already reported. When using SLQB, this warning is shown. > > > [    0.000000] ------------[ cut here ]------------ > [    0.000000] WARNING: at kernel/lockdep.c:2131 trace_hardirqs_on_caller+0xb1/0x12f() > [    0.000000] Hardware name: VMware Virtual Platform > [    0.000000] Modules linked in: > [    0.000000] Pid: 0, comm: swapper Not tainted 2.6.31-rc4-mm1 #1 > [    0.000000] Call Trace: > [    0.000000]  [] ? trace_hardirqs_on_caller+0xb1/0x12f > [    0.000000]  [] warn_slowpath_common+0x77/0xa4 > [    0.000000]  [] ? _spin_unlock_irq+0x2b/0x30 > [    0.000000]  [] warn_slowpath_null+0xf/0x11 > [    0.000000]  [] trace_hardirqs_on_caller+0xb1/0x12f > [    0.000000]  [] trace_hardirqs_on+0xd/0xf > [    0.000000]  [] _spin_unlock_irq+0x2b/0x30 > [    0.000000]  [] ? __down_write_nested+0x1c/0xa9 > [    0.000000]  [] __down_write_nested+0x39/0xa9 > [    0.000000]  [] ? kmem_cache_open+0x2b1/0x460 > [    0.000000]  [] __down_write+0xb/0xd > [    0.000000]  [] down_write+0x4a/0x4e > [    0.000000]  [] ? kmem_cache_open+0x2b1/0x460 > [    0.000000]  [] kmem_cache_open+0x2b1/0x460 > [    0.000000]  [] kmem_cache_init+0x4d/0x352 > [    0.000000]  [] ? mem_init+0x156/0x161 > [    0.000000]  [] start_kernel+0x1cd/0x3ab > [    0.000000]  [] x86_64_start_reservations+0xaa/0xae > [    0.000000]  [] x86_64_start_kernel+0xe1/0xe8 > [    0.000000] ---[ end trace 4eaa2a86a8e2da22 ]--- > [    0.000000] start_kernel(): bug: interrupts were enabled *very* early, fixing it > > This is because down_write() uses spin_lock_irq(), not spin_lock_irqsave(). > I think this is sane because down_write() is not called under irq-disabled. > By this, irq is enabled before init_IRQ(). > > SLUB don't have this bug because it uses special routine for initializing > kmalloc area. (See slub.c::create_kmalloc_cache(), it's commented.) Should be fixed by this: http://git.kernel.org/?p=linux/kernel/git/penberg/slab-2.6.git;a=commitdiff;h=791738e83b97d2d4fc631d68483430200035bdf3