Re: [origin tree build failure] [PATCH] slub: Fix build error in kmem_cache_open() with !CONFIG_SLUB_DEBUG

[Pekka Enberg <penberg@cs.helsinki.fi>]

Hi Ingo,

On Tue, Sep 15, 2009 at 12:03 PM, Ingo Molnar <mingo@elte.hu> wrote:
> From 817eb1b8da641984334db46a486ad2f867daa803 Mon Sep 17 00:00:00 2001
> From: Ingo Molnar <mingo@elte.hu>
> Date: Tue, 15 Sep 2009 11:00:26 +0200
> Subject: [PATCH] slub: Fix build error in kmem_cache_open() with !CONFIG_SLUB_DEBUG
>
> This build bug:
>
>  mm/slub.c: In function 'kmem_cache_open':
>  mm/slub.c:2476: error: 'disable_higher_order_debug' undeclared (first use in this function)
>  mm/slub.c:2476: error: (Each undeclared identifier is reported only once
>  mm/slub.c:2476: error: for each function it appears in.)
>
> Triggers because there's no !CONFIG_SLUB_DEBUG definition for
> disable_higher_order_debug.
>
> Signed-off-by: Ingo Molnar <mingo@elte.hu>
> ---
>  mm/slub.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 417ed84..be6e1e0 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1071,6 +1071,8 @@ static inline unsigned long kmem_cache_flags(unsigned long objsize,
>  }
>  #define slub_debug 0
>
> +#define disable_higher_order_debug 0
> +
>  static inline unsigned long slabs_node(struct kmem_cache *s, int node)
>                                                        { return 0; }
>  static inline unsigned long node_nr_slabs(struct kmem_cache_node *n)

Oh, sorry about that. I'll merge the patch and send it to Linus later
this evening. Thanks!

                        Pekka