From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Hank Janssen <hjanssen@microsoft.com>
Cc: Greg KH <gregkh@suse.de>, Haiyang Zhang <haiyangz@microsoft.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Tom Hanrahan <hanrahat@microsoft.com>,
Hashir Abdi <habdi@microsoft.com>
Subject: Re: [patch] Staging: hv: Fix vmbus load hang caused by wrong data packing
Date: Tue, 13 Oct 2009 08:08:49 +0300 [thread overview]
Message-ID: <84144f020910122208k1fde7e60hce873e81a6436f57@mail.gmail.com> (raw)
In-Reply-To: <8AFC7968D54FB448A30D8F38F259C5620E7B1C22@TK5EX14MBXC114.redmond.corp.microsoft.com>
Hi Hank,
On Mon, Oct 12, 2009 at 11:10 PM, Hank Janssen <hjanssen@microsoft.com> wrote:
>>Ideally, we don't deal with packed structures at all, but with offsets
>>in memory and pick out the proper fields and put them into new
>>structures if you want to use them that way. How hard would that be to
>>do here instead?
>
> It is something that I want to look at in the future. Our primary focus
> Is to get the bug fixed. We cannot do the offset way in the time we
> Have before 2.6.32 closes and still be comfortable we have gone through
> The extensive testing cycle we do on our side.
We don't merge fixes to the kernel unless we understand _why_ they fix
things. It's pretty likely that the problem here is that one or more
of the structs you are putting under "#pragma pack" just need to be
annotated with "attribute packed".
Pekka
next prev parent reply other threads:[~2009-10-13 5:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 23:16 Haiyang Zhang
2009-10-12 15:30 ` Greg KH
2009-10-12 17:03 ` Haiyang Zhang
2009-10-12 17:29 ` Greg KH
2009-10-12 20:10 ` Hank Janssen
2009-10-12 20:22 ` Greg KH
2009-10-12 20:44 ` Haiyang Zhang
2009-10-12 21:27 ` Greg KH
2009-10-12 23:41 ` Haiyang Zhang
2009-10-13 5:08 ` Pekka Enberg [this message]
2009-10-16 20:03 ` Hank Janssen
2009-10-12 20:34 ` Greg KH
2009-10-16 20:11 ` [PATCH 1/1] Staging: hv: Fix vmbus load hang caused by faulty " Hank Janssen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f020910122208k1fde7e60hce873e81a6436f57@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=gregkh@suse.de \
--cc=habdi@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hanrahat@microsoft.com \
--cc=hjanssen@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®