From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lars Lindley <lindley@coyote.org>,
gregkh@suse.de, greg@kroah.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: winbond: mto.c Coding style fixes
Date: Sun, 21 Mar 2010 22:22:29 +0200 [thread overview]
Message-ID: <84144f021003211322m6d45a391p860cff532c7b4a77@mail.gmail.com> (raw)
In-Reply-To: <20100321200450.GD1933@elf.ucw.cz>
On Sun, Mar 21, 2010 at 10:04 PM, Pavel Machek <pavel@ucw.cz> wrote:
> On Sat 2010-03-20 00:26:45, Lars Lindley wrote:
>> I changed all things reported by checkpatch.pl except some long lines
>> and the use of externs in a .c file. I also removed revision comments
>> and "commented out" code.
>> Please review this closely as the generated .o differs from the
>> mainline one but I suspect that is because I removed the explicit
>> initialization to 0 in a couple of statics..
>> There are also some very deep if-if-else-if-ifs that I might have messed
>> up :)
>>
>> Signed-off-by: Lars Lindley <lindley@coyote.org>
>
> ACK.
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
prev parent reply other threads:[~2010-03-21 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 23:26 Lars Lindley
2010-03-19 23:49 ` Lars Lindley
2010-03-21 20:04 ` Pavel Machek
2010-03-21 20:22 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84144f021003211322m6d45a391p860cff532c7b4a77@mail.gmail.com \
--to=penberg@cs.helsinki.fi \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=lindley@coyote.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®