From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84B253D524F for ; Tue, 23 Jun 2026 11:59:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782215972; cv=none; b=Gq5vLWVPXAjXSdt6kM4mD8eDob5tbue2kOwQA+y9B1Hei0kQYVIeYrVn/KIbcEmTTzih2L6xJy4CvMrcsfpjORAj7wjBiliFh2/Iw4gKsyFBuaiGWRI06MSwBWcmJ8oYoQ6x0nylTCS9Rs7S5VdPdcDZg59UDM+vxTfRrB7KLoc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782215972; c=relaxed/simple; bh=N/3AVGovt15f7wbdWrYGPsjnPnBLGdx20x+VTIjeCAU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oHk1E0PZezjPxAFRswwV9f42p/QvcIGp2qhGv8OG9jsvqKXOGsGyhJQ/RhOXmYEB33Z25UXH8BQjC1dYv+SlZ3w+Wz8Cq2zqtqpS6s7txAWc2rlW13wDltbin6z9VGazz3Nk+tawo3JHlzUlPQVUWw0Dbnni+1K/f6+0bnuqN0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=XoE5k9vi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jU8+mOg+; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="XoE5k9vi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jU8+mOg+" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBZijr4052828 for ; Tue, 23 Jun 2026 11:59:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= AeDY1Z/tgJlpDbX7IPSk/ptAPNQ1w+OnQUXLRd5JDUs=; b=XoE5k9vinZh5Yvv2 OO2HBm0lodKmCxTYcaA+Br6B9oBuNGJRqr0ri5m7si1tBZZZmdCEd8IzSf+pe0WP xAOJHibs9YDVhdVXPzwIlK+6/oPh/wO9JgHmT2N/heiY0NIizBRWUA5QiTV+FSw2 HwAf921GPUZdFIVBevmC5H/KQIWO+m4Y83y1cUuUUOo3jSGPSOYHaU7Z9QhyGw9c DibnzKDJXwBxbMdOAg1hmDFYP3uinEAo/kUkqn9v0dPBRrwA9NAhqSCzxKQU4BmT Hs6PZTW/WL+N5535yUKr+8WRfp5Xf+lVjL9Ifxj2QbfCg3CfbP63vChuCPSfi47R /NF7oA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr9yrate-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 11:59:29 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36d99181eaaso6538162a91.3 for ; Tue, 23 Jun 2026 04:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782215969; x=1782820769; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AeDY1Z/tgJlpDbX7IPSk/ptAPNQ1w+OnQUXLRd5JDUs=; b=jU8+mOg+wsgDCxfRcSSIKAwu8Ieh3TsCVRMkIALGveKbIpW/NW9Ht2zBotRfmBuSWR XmNEqoqLLJs3H7NrcRmd6iMOvaEeiRzju2p6kUK2T15UDSnLHp5Bf0WBG9NdGRYc5dcK pknzIcVQmUT/GVfz8ketSVHR07mRtAfsv0u+guNkVyDF734H+HsspJhH9GZWwp/YchVT Gq6waMtOyONfpOyEiJTs3ofrixok1Pvrt3GgdjFebH4/QoHTiuPSUJkERHqiVUtdxXgK QCtwuS6w4eHQkQy4WcsNphNbEdtWD5bBXQw2jVUt8o9T/2ozn3rNBPtEhe8a7Ie4V1G3 3kDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782215969; x=1782820769; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AeDY1Z/tgJlpDbX7IPSk/ptAPNQ1w+OnQUXLRd5JDUs=; b=AQ1Bjj3x1fOHgXV08nU7W/G4PymqkzmgiR4PHlHPHG0eDe95ESpwDKa2eMxCJHnpS0 KmaNuOJWYRa1ql3kZZ5sQ4O/JipGNa/VFyDaYqZq6A6Y2g86HcE2I4Rz3hFecSqVBPwC PpUHd+9g9Yq96GSowOCjiHtqH3JmFvzGtVnMvrEIx3opIBSwxhYcORrQ6OB+wsQN0Az5 LkJVaDN4NmcCi2g+XdkLG8LKXPLyOHjmZenxidjChz/M5Oy2oe6DIwBommSo3f0MXo5f jCo8WZoodKmUc09k0jFYgn1df8Gk3i2dhh9kYIgFljBssdvm/OTBRnot0q7rhvZNlV+v bNFA== X-Forwarded-Encrypted: i=1; AHgh+RobjThxMjbyLx70p5XKp2uJmzpXzzgKAsaJtXXMZPrzsUqVbI9iHyJOfqWCZuM0kqFPQEHQk8qdsPdGa8w=@vger.kernel.org X-Gm-Message-State: AOJu0YxjL0EVP2euKr9IWfnMMYOzfE5CBe9J4Q0plZuv0pY3zCDDVz8q MinaWkZW0sv3zNC46MU/rQCDcMvo8RJNNLtb2PUwEp74syizhg+AP81aLooEDfLqU5qpFkN+1Fl Q7TmahchSH3qeGxDXQK816hzb7znHytoNGMFGiBk2EzyU2fqA1ahwV210MLiqXnxCHXM= X-Gm-Gg: AfdE7cnCCiuF5MVGHczsvN6VxGc+tt9EmEnvd8yMzS3e67baHlAAtgLVHYapXkojuaq SLC765J3tt6FkOy0Do8ilzIR0G30t7ElHwpFT9KTUpS7o82w0btElnkQrkdSKhve04h5hDKefNA 2gUGO9f9KfJW5ThlpeJwncMIDpkTtWCvJdPXO6eCNqCyn/u3QleDHo/lQNs40I7pyHgoYx+EYC3 pwBD0wEtmMp9r8hPCsFhv2WjJ9PNeL5qKWXh5Wg+Pp3jN1ukNoRxmRbUKdikLC6SdCl+UJ70Fvq KYq3p7iyar6kgeDfyjDm4qpHfitzZrcEIx0fqOQ99zgxK5/Zo3tloQ5c9xOfXX8QB1TfifaYUsa 4LV8JYbDzHP8i9guC2QdWzxlJ1Kz0rLld4NS1cPk= X-Received: by 2002:a17:90b:4a4c:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-37dd15bf1b7mr2558284a91.0.1782215968753; Tue, 23 Jun 2026 04:59:28 -0700 (PDT) X-Received: by 2002:a17:90b:4a4c:b0:35c:30a8:330 with SMTP id 98e67ed59e1d1-37dd15bf1b7mr2558262a91.0.1782215968224; Tue, 23 Jun 2026 04:59:28 -0700 (PDT) Received: from [10.218.18.193] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37d4f2d2702sm10091200a91.12.2026.06.23.04.59.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 04:59:27 -0700 (PDT) Message-ID: <84167531-b252-425c-bea5-49992a9c4500@oss.qualcomm.com> Date: Tue, 23 Jun 2026 17:29:23 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 2/3] ASoC: codecs: lpass-va-macro: Switch to PM clock framework for runtime PM To: Konrad Dybcio , broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, srini@kernel.org Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260623071708.2822269-3-ajay.nandam@oss.qualcomm.com> <89c4fb14-9884-44a0-8921-fc361a9303f9@oss.qualcomm.com> Content-Language: en-US From: Ajay Kumar Nandam In-Reply-To: <89c4fb14-9884-44a0-8921-fc361a9303f9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=JYSMa0KV c=1 sm=1 tr=0 ts=6a3a7521 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=dF8yuam3Ay0lu1q_4Y0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: V7Y7RBJkOjDtzz9u0vI9yW6JgyzHyynJ X-Proofpoint-ORIG-GUID: V7Y7RBJkOjDtzz9u0vI9yW6JgyzHyynJ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDA5OCBTYWx0ZWRfXwR8GPAreAAo7 1lG/EoRlvo/AYDeYEs7K/K9wrhim04GOsQgAU0gv56hdR4jGg+UHc27yu/35HS+RQkMLPriYngv ZsTTiQf+SYTu45zMlNT/YGIP/G6VizQbW3ostmUm/zWdXKZE1xcEYyHS66JaJWZPXecbQ0Tey4j HHQJ2GLbBxZCNnWTTui/xvy0IRcZwOrFRdOb9q8ZLrUA5LkoDqI5D4YJehj+hL6hsMoA50V+9B4 bCO4w4Xm872u2cQ9i4Nx5nSTrFjKsr/i4oZ6QZcpooyKFyGYNtSJ5js9IOUPtu/aUrJ2plnWWhT 6BXvvA8ZtMtMCnT6lLtVItdU0baI/tWa9u6fp9OQrHKlB4tjMLXuXv6UDBaboyuTE3icL51jD9s QYukouRXUidGcYcuwOgaIolquZfBIQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDA5OCBTYWx0ZWRfX3hurmrMugT+v Q7Zi2gDGfaYMt07mEwSCVCbbX8ToFBbt3EbSlbulsyL/P3WFGvO2BsBiOQhgKYFouM+lREXhnnn /+Xpv+96F/TmpJJoQr4f9z68ANn6q4Q= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 malwarescore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230098 On 6/23/2026 4:09 PM, Konrad Dybcio wrote: >> Convert the LPASS VA macro codec driver to runtime PM clock management by >> using the PM clock framework. >> >> Replace manual macro/dcodec/mclk/npl clock handling with PM clock helpers >> and runtime PM callbacks, and keep runtime PM references around fsgen clock >> gating so PM-clock-managed clocks remain active while fsgen is enabled. >> >> Set autosuspend delay to 100 ms so PM-clock-managed votes are dropped soon >> after idle while still avoiding suspend/resume churn on short gaps. >> >> Add a PM_CLK dependency to SND_SOC_LPASS_VA_MACRO since this patch >> introduces PM clock APIs. >> >> Improve failure unwind paths: handle runtime PM put errors in probe/fsgen >> paths and restore regcache state correctly on resume failure. >> >> Signed-off-by: Ajay Kumar Nandam >> --- > [...] > >> --- a/sound/soc/codecs/lpass-va-macro.c >> +++ b/sound/soc/codecs/lpass-va-macro.c >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include > includes should be sorted > ACK, I’ll fix the include ordering in the next version > [...] > >> +static int va_macro_setup_pm_clocks(struct device *dev) >> +{ >> + int ret; >> + >> + ret = devm_pm_clk_create(dev); >> + if (ret) >> + return ret; >> + >> + ret = of_pm_clk_add_clks(dev); >> + if (ret < 0) >> + return ret; >> + >> + return 0; >> } > Can't these 2 calls simply be part of .probe()? The helper was added to keep the PM clock setup isolated, but I agree it’s simple enough to inline into probe(). I’ll move it there in the next revision. Ajay Kumar Nandam > > Konrad