From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 41AC420468E for ; Thu, 7 Aug 2025 17:59:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754589587; cv=none; b=DvcytJf793y6chgnBQDHMk+6TiqP/bxHASaVO/rPqQk9sqXBN5AroxEyqEOpik48TPFcsqSiWNEMw/tPvLWwN8iQCfthXotEvUdd9mLatmfzaii/THzLQuuohu4ZoBjHhOAYj/RQ/LsauQQZeraZBuTTr4wtcg6oIuE8Yee37og= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1754589587; c=relaxed/simple; bh=r5jXZtVpLIkTTs0nhtHenLPnARs3ev3d8Mjt+ujMm4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BAB8rB9KiBVkKHqeN0MEBllHwzDpDbPllp+MZDW4vcmTM628OTC8q6RftxFfcNglsv1ZkENI4a7CZAkNjmTjYBncF7VQeW7BOKA3TKHTAMHOj8wKtWWTOW1hvpnRm0YTbGTIrRZvbaGRNCrdKTCJWLHhxxAgZVJSbZOoMyXa/gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f9hxdFf0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f9hxdFf0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754589585; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Wk6a/pPPJhrMqThE6QoVfYpodt1UgZPfr4F28Ot7H28=; b=f9hxdFf0Zc2/QhbmKujdXkWQvB+vMPjFkeGicJJY+tkHJ1Mrhb+5zdqceZExPHBBTzAq80 Wl9MARmX9bWoVK4E//CbiXGHSPoGQnFrmUHooS+hJwNP70gL0URyunj1AgFsAlU1uH8xa8 cRkjcPVo7+2gqMwBcGyRQuXtgDFj49E= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-gywd0dICPm-AizUYv8zrnA-1; Thu, 07 Aug 2025 13:59:43 -0400 X-MC-Unique: gywd0dICPm-AizUYv8zrnA-1 X-Mimecast-MFC-AGG-ID: gywd0dICPm-AizUYv8zrnA_1754589582 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-459e0f54c88so6884475e9.1 for ; Thu, 07 Aug 2025 10:59:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754589582; x=1755194382; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Wk6a/pPPJhrMqThE6QoVfYpodt1UgZPfr4F28Ot7H28=; b=VLBYHMwCwVwdKJx7I/kzN18zHdzdcT0Hua8qaJW5qP2G9dx9RwCtOK1S2c6AOrN0Y3 BTaLOSICmANS6H4UPVTdYduXrVUR5ZK0chU9RQUaQ21Q+BsJ42P+b3dJhenfeK1Z1mex HeaHNvetGJgNGGOaiCbMSidEGyB0GYE7nUsPNKub8DvF42yeOLKsLg+l3GqSaXz1SF8n qDcQr16TKPvdP/pu7w9ClJ1LpQL/w3vSuAVARhyd5+YP2KBiw8u6iRLgVNvxGJ8sxmkf wHmlMH/Ot8l39CJNJypSQvKlNdVUEx+V1dugtjTc8GUc4thwJx2vvMX4zW6Nga/KnnNc n5SQ== X-Forwarded-Encrypted: i=1; AJvYcCX//xZALMbvpyy0twlubnf2Fu+z69fwfKGusRPnsKvSxFgL3kuV5bJjai++AcvfiitkIxfEyvey5bDk6h8=@vger.kernel.org X-Gm-Message-State: AOJu0YxvfwVlNQY0tnME99bx76H49sW7XxMXpWh/AtEFg8aetavfWwYX Ic7mctQsUq/liAgDPtvC5vWYfOYawknyICqyX6oup7UJ4JIHUaL+Pn9VYJkUXFmgMvo7wQkwASh hgHT8cIiqps6S1IGnYfOJZIosdbu48mEk7TYAmGOR5M/OUh1DorcfNwGBIovOz5x0oA== X-Gm-Gg: ASbGncth3zDrmXU4Y0BVgyZKF3eX635ciSA5gyqRIRXwpo4jlVA/kqK86DKuAKxoHfJ lj3qUrH79HqAIoqUrTBskDs6t0MyE7DxMKqzaJs4ExAFvZyChk9kvsDrpY8cig3c057mTcDYUPL /YuxUwtuhVE1mj4MJcYndyn8v3UuY/MgXuPYk/hUcAQLHLcD6oXeA5tFtxjz8nsNFg/M6TOrVsL tmzImdZOveRvAeIzF4qCA4oYZR63MgQ00o/C0MN/2/2997guVvba2NM7ePilIRqnWNZyR8SggpG manSlSQ1ehealY5x9vIr3C6nsvg+NxzMdQkvpJBOUxRlSdB3sMXUaniGN0UE4NeNw/hMp9aGJqn mPpyI/JurJaEiPiGcJIFBjYHzmzrysqxIVE85wSmiSwpZmZ4k2wPlsYgCcFC2iuXYwbc= X-Received: by 2002:a05:600c:64c3:b0:459:e39e:e5a5 with SMTP id 5b1f17b1804b1-459ede945a6mr45490665e9.5.1754589582467; Thu, 07 Aug 2025 10:59:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFn0NJBCGt4/Rk/NEdnJWnNlQiQuizOhALHDnhgSLWYNhieS2DmpQ+fxa0tiLbFyO8ObvlS7w== X-Received: by 2002:a05:600c:64c3:b0:459:e39e:e5a5 with SMTP id 5b1f17b1804b1-459ede945a6mr45490405e9.5.1754589582034; Thu, 07 Aug 2025 10:59:42 -0700 (PDT) Received: from ?IPV6:2003:d8:2f49:bc00:12fa:1681:c754:1630? (p200300d82f49bc0012fa1681c7541630.dip0.t-ipconnect.de. [2003:d8:2f49:bc00:12fa:1681:c754:1630]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b8e0b2d2fasm17231775f8f.50.2025.08.07.10.59.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Aug 2025 10:59:40 -0700 (PDT) Message-ID: <8416922c-4198-45cf-b5c2-dc39587bbf68@redhat.com> Date: Thu, 7 Aug 2025 19:59:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [linus:master] [mm] f822a9a81a: stress-ng.bigheap.realloc_calls_per_sec 37.3% regression To: Lorenzo Stoakes , Jann Horn Cc: kernel test robot , Dev Jain , oe-lkp@lists.linux.dev, lkp@intel.com, linux-kernel@vger.kernel.org, Andrew Morton , Barry Song , Pedro Falcato , Anshuman Khandual , Bang Li , Baolin Wang , bibo mao , Hugh Dickins , Ingo Molnar , Lance Yang , Liam Howlett , Matthew Wilcox , Peter Xu , Qi Zheng , Ryan Roberts , Vlastimil Babka , Yang Shi , Zi Yan , linux-mm@kvack.org References: <202508071609.4e743d7c-lkp@intel.com> <9e3a59b2-11c0-43ca-aff3-414091f04aa4@lucifer.local> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07.08.25 19:41, Lorenzo Stoakes wrote: > On Thu, Aug 07, 2025 at 07:37:38PM +0200, Jann Horn wrote: >> On Thu, Aug 7, 2025 at 10:28 AM Lorenzo Stoakes >> wrote: >>> On Thu, Aug 07, 2025 at 04:17:09PM +0800, kernel test robot wrote: >>>> 94dab12d86cf77ff f822a9a81a31311d67f260aea96 >>>> ---------------- --------------------------- >>>> %stddev %change %stddev >>>> \ | \ >>>> 13777 ą 37% +45.0% 19979 ą 27% numa-vmstat.node1.nr_slab_reclaimable >>>> 367205 +2.3% 375703 vmstat.system.in >>>> 55106 ą 37% +45.1% 79971 ą 27% numa-meminfo.node1.KReclaimable >>>> 55106 ą 37% +45.1% 79971 ą 27% numa-meminfo.node1.SReclaimable >>>> 559381 -37.3% 350757 stress-ng.bigheap.realloc_calls_per_sec >>>> 11468 +1.2% 11603 stress-ng.time.system_time >>>> 296.25 +4.5% 309.70 stress-ng.time.user_time >>>> 0.81 ą187% -100.0% 0.00 perf-sched.sch_delay.avg.ms.__cond_resched.zap_pte_range.zap_pmd_range.isra.0 >>>> 9.36 ą165% -100.0% 0.00 perf-sched.sch_delay.max.ms.__cond_resched.zap_pte_range.zap_pmd_range.isra.0 >>>> 0.81 ą187% -100.0% 0.00 perf-sched.wait_time.avg.ms.__cond_resched.zap_pte_range.zap_pmd_range.isra.0 >>>> 9.36 ą165% -100.0% 0.00 perf-sched.wait_time.max.ms.__cond_resched.zap_pte_range.zap_pmd_range.isra.0 >>>> 5.50 ą 17% +390.9% 27.00 ą 56% perf-c2c.DRAM.local >>>> 388.50 ą 10% +114.7% 834.17 ą 33% perf-c2c.DRAM.remote >>>> 1214 ą 13% +107.3% 2517 ą 31% perf-c2c.HITM.local >>>> 135.00 ą 19% +130.9% 311.67 ą 32% perf-c2c.HITM.remote >>>> 1349 ą 13% +109.6% 2829 ą 31% perf-c2c.HITM.total >>> >>> Yeah this also looks pretty consistent too... >> >> FWIW, HITM hat different meanings depending on exactly which >> microarchitecture that test happened on; the message says it is from >> Sapphire Rapids, which is a successor of Ice Lake, so HITM is less >> meaningful than if it came from a pre-IceLake system (see >> https://lore.kernel.org/all/CAG48ez3RmV6SsVw9oyTXxQXHp3rqtKDk2qwJWo9TGvXCq7Xr-w@mail.gmail.com/). >> >> To me those numbers mainly look like you're accessing a lot more >> cache-cold data. (On pre-IceLake they would indicate cacheline >> bouncing, but I guess here they probably don't.) And that makes sense, >> since before the patch, this path was just moving PTEs around without >> looking at the associated pages/folios; basically more or less like a >> memcpy() on x86-64. But after the patch, for every 8 bytes that you >> copy, you have to load a cacheline from the vmemmap to get the page. > > Yup this is representative of what my investigation is showing. > > I've narrowed it down but want to wait to report until I'm sure... > > But yeah we're doing a _lot_ more work. > > I'm leaning towards disabling except for arm64 atm tbh, seems mremap is > especially sensitive to this (I found issues with this with my abortive mremap > anon merging stuff too, but really expected it there...) > > On assumption arm64 is _definitely_ faster. I wonder if older arm64 arches might > suffer? Are we sure it's not also slower on arm64 with small folios? I would be surprised if it isn't. -- Cheers, David / dhildenb