From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20EB713D276 for ; Sun, 10 Nov 2024 03:10:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731208243; cv=none; b=D1H1CHij0BveqjdWN1O8dDEw4q7wGdmEyoX55opC1dT+9JHpgCvLYJ1t3Qds+SBYCDpwSU41PF9Zl8tVys4BEYMCCEQSDwLvoCymE/3VZnO3mQYBIXZ+KcWlfKXYDCTw2rxzlUBgfZUjNWr8oUtT1oaUhRgn5Jv96a1r77DbcGI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731208243; c=relaxed/simple; bh=cQlKNhd5NE6RwBmoxY0OcVryhkWPxYxqlNQtOR1DQls=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nfehr5YxWVBk8HYQQ3CICZKe3x5j2ROrDCQCs9GlDnQ5DYhBygj3vCtLyswI8D8JMSo5hPmppIAnvEgu/dkEHb6rSuW4xIKaju5ScjtZQMYeuD9u1ZtXVzdr0lMHxGrqzvBQnWja9VBHvYe92aLoiDGvhREuUSSpN1YR14Joods= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie; spf=none smtp.mailfrom=nexus-software.ie; dkim=pass (2048-bit key) header.d=nexus-software-ie.20230601.gappssmtp.com header.i=@nexus-software-ie.20230601.gappssmtp.com header.b=cm2HOsUd; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nexus-software.ie Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=nexus-software.ie Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nexus-software-ie.20230601.gappssmtp.com header.i=@nexus-software-ie.20230601.gappssmtp.com header.b="cm2HOsUd" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-431616c23b5so19703795e9.0 for ; Sat, 09 Nov 2024 19:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20230601.gappssmtp.com; s=20230601; t=1731208239; x=1731813039; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zGxEFnmS5fq8tk5sA1fqqLEk9HyDO1wqcsP8ouvekQY=; b=cm2HOsUdx85pqUS1bc98v3r/axAU0pzhBo3xU26kafhTwItiHw6oSE3PILQUg1oAqh ICtQg4uEgJL8hg1nfrPsY+RwH+wpL2kGL03sw7GGb6arBjU0LSRtafn5SIDI7hrfaNXk DORgyH/pJWgM052qdJp2ZOJ3WdE+uFqvPE+AzkJ7srIRsSb+kef2mf6YXNU/q7MQ7AJx vykSPbxc7b0HHUB9mVYiTOx7eof1xQy3ZAppBazJvUcKX60k4b+FeWxvxuR/zhVw69E3 UzmP/l2yhVURF9B0Nqtj+JXznJUBaykZfiGAkAWYDtgU2omngUh7IRS/02VKrzyOuV+H M7SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731208239; x=1731813039; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zGxEFnmS5fq8tk5sA1fqqLEk9HyDO1wqcsP8ouvekQY=; b=sLRei8nQVcccjDW4nMF55SBo3FLdg8LsPNkzNwJ1FkmKIaWold21LX1FqP8B+5hGcs NqfO2d8/ojtX3K2iaNUBtuTiOM61bTWYZygye2GCiJpAo0/hPMrkrkDcGTYrLofq1hmD EgMFZtNrqBBS/fuoI16oEQji/8V6A93S3Jukj6KC5didES4Op3SPJKjcsRi5i9yFb4SK 11MTLXGw8mI7V+ELtqiyN1h3JxVDpn/PpmaUL9DqHuINmsfrGTetiVtUDFDkdpZrSSt/ qMx9mzReLIf8RECkq5OtdtHu77n411cIP0l6/hsPRQEc+sya0CmcLy6SreloT9sT/sYs KOUg== X-Forwarded-Encrypted: i=1; AJvYcCUu/JEWnIAlNUhn6n1b6j3/sd/0qc5aRxWrZXwRNQ343lCkbP4IJNpR5XngKHbBFNGRf6P18nTLQN/WG1E=@vger.kernel.org X-Gm-Message-State: AOJu0YyripgkyRYdaMUpI4FH3XDjGYkJ3jozW0gpPAusU6k9fDMLYvOW b6N3k3ysrMBbTiFny+CxUyoonNJbxcEWaAMnV+5E2SFAlGYufK9dtV/fw5hHbVY= X-Google-Smtp-Source: AGHT+IH5aQ8aQ1R+iLcbezixKAMbiVAd6tXCGBPiuHyJUqk5Nwvv+Ivfc/HUeFLxpFg7fJTC26pjWw== X-Received: by 2002:a05:600c:4fc3:b0:42c:baf1:4c7 with SMTP id 5b1f17b1804b1-432b6858e60mr70055455e9.4.1731208239337; Sat, 09 Nov 2024 19:10:39 -0800 (PST) Received: from [192.168.0.48] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432aa737721sm165333935e9.36.2024.11.09.19.10.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Nov 2024 19:10:37 -0800 (PST) Message-ID: <841a9469-4fa1-443f-88a6-bfbe11b74487@nexus-software.ie> Date: Sun, 10 Nov 2024 03:10:36 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 03/28] media: iris: implement iris v4l2 file ops To: Dikshita Agarwal , Vikash Garodia , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: Hans Verkuil , Sebastian Fricke , Bryan O'Donoghue , Dmitry Baryshkov , Neil Armstrong , Nicolas Dufresne , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Jianhua Lu , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241105-qcom-video-iris-v5-0-a88e7c220f78@quicinc.com> <20241105-qcom-video-iris-v5-3-a88e7c220f78@quicinc.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241105-qcom-video-iris-v5-3-a88e7c220f78@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 05/11/2024 06:55, Dikshita Agarwal wrote: > Implement open, close and poll ops. > > Open: > Configure the vb2 queue and v4l2 file handler. Allocate a video instance > and add the instance to core instance list. > > Close: > Free the instance and remove it from core instance list. Its a bit odd that you describe the purpose of open and close but not poll, despite listing poll along with open and close at the very top. Consider adding that text if you do a next version. Reviewed-by: Bryan O'Donoghue --- bod