From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f228.google.com (mail-yw1-f228.google.com [209.85.128.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5FBC337117 for ; Fri, 16 Jan 2026 02:10:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768529440; cv=none; b=B+OUJimv9+G2cv2bfCczfPUF53KDzC/B7UiNnxMdQUjNA0/Wp3Iw6ebqqiMq+bVKRKFExFy5YheIR80SZjPodrslRDCdIVOkAvlMuXLC3W8PqjlDkBCDMo9Rf6XEx4OVyDcjJ3KpEofxv530V2q0Gu9ov3q4Gd+tDq4Qa7kZ6TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768529440; c=relaxed/simple; bh=d33WoMx5AG/SD4NZkWXjfXAEtn0Tav+vfwFXs7EZivI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KS7VkYEaICpJppMtw8n5xUDKxzT+w97z0O3PoxYPTJvXYuDTJ8aAx01puG04mu+MC+7mT6tImr2t5mN22FJCQSPGa8eBLpC5zZW6td55SxL1gevmCl1vWDZf94ZN4MrNj/K9LmW82QIxMMg7FP8dAS9qVJ0PCIZmPrMrhcWYjtg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=fjF8gSlA; arc=none smtp.client-ip=209.85.128.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="fjF8gSlA" Received: by mail-yw1-f228.google.com with SMTP id 00721157ae682-78fc3572431so17213877b3.0 for ; Thu, 15 Jan 2026 18:10:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768529435; x=1769134235; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Smsas5XP9kATJgrCPlJwH36X7CX19/Y/MUlq+6C6jCw=; b=qO2g9ML1FHePQdTHylIY0Z4WU6z2pWG1efz+DqHX705VodQI2B7sd7A0l/MXROEJKi ts/79MJ6csHHTA7dncDuX8/Xb6boiRZurPzGPdKNTD96wK6R9yoK4DnntltIl0xL7SnU ZqrKkiIdReP/1TEx6gDXI6cL9tRDv6kegINBJDdt9+G8wuOKTZK8xN5y9+K9t98vtIbI zfepibxchnVnGN50p526iwWNxqRS0FwCvlhXvmYgt/6eahdniqRX1O8fU/czWjalWjQk QVhjoppbd6LKcVDlQgsWCzI6mi5Izgcj9zwh9VtmeMuaODqEm8td+wGXf9RiQ6vfugCU gHKQ== X-Forwarded-Encrypted: i=1; AJvYcCVDD+6ZHpGeLpL6xH9Z9+KLi4fK/S9CNAkx+6kP8MMz3IkBlQ5ENY3JffgdjgUwntOw0kRsxVHK3/yQaow=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4a6LTdbdWAkfcWf1Wx1P6on6xzcweJuwm6gj6SCLqyHJP2oRk ILO7dkrRvbf/4/4OgYazP6KYdVosQa/5Qv/2bomG0Wh1wuMWKQ+EH+RcfoyADQyYlITAutJu5/5 pHEj5NaXxduyIaTFqhPYAMDiRpKLkX6MBWAAN8aAavh4aorAAx4T/8VyzhtT0VP2O3Y/EQBSivn a3TgCGnZQDB4z+ogUXw1UA+xFNxljzjNUb2/uVHVXBFHgq5//LYbl64wMIKfYPMbCTgkdmuzIH+ 7mr4F+bmGbLT/SO3UmYHf0c X-Gm-Gg: AY/fxX4DOKQ4SYlvw1F7eQsbnJ/4P8g2RJpKxMDwy06KrkryNFRz6ghElxm/6OrDFV2 S3d8U6oUp35O3IGeSM8tIrkF8g2O/l9onB9GrUAOj+p8E0SGf0MHBdX3+w0ArApHqBfymsx2jNQ iB88QwAbiSqfvOQSe6kh4GawIfehUZ/4mK3iChXtPierZl4xH+ri/jMHX4Xff1cOYNtwUsl1XGp arGFm+6ko79bBAOeGMfynnTcnsoDelzXB7Gtliowy8GCFhmpJnU8wv6R+snHxPl6V+tvEIeMU8h kKELDffGN9IymLGBSF8NqAW9uH77iNNTWNC3t2kFnUbZEDNg4Eh7OiUvs9ZjWEKFC/P3BM02QfY iqR9cvKVtq4Av6Mv5BG14YhkXH9N6aU3WfmAJlIg+eBKDhqGLTk6y6fFaOsebEHIReaQyHMHsAc IHFkl/iwK9SlnXHnioRxwIzDlB7zybxjDwWVMcP1x+FpeoK5WmjQ== X-Received: by 2002:a05:690c:d0e:b0:792:7745:72d0 with SMTP id 00721157ae682-793c536134fmr15267997b3.23.1768529434773; Thu, 15 Jan 2026 18:10:34 -0800 (PST) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-72.dlp.protect.broadcom.com. [144.49.247.72]) by smtp-relay.gmail.com with ESMTPS id 00721157ae682-793c66fc1efsm564937b3.12.2026.01.15.18.10.33 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Jan 2026 18:10:34 -0800 (PST) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-121b1cb8377so2985915c88.0 for ; Thu, 15 Jan 2026 18:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1768529433; x=1769134233; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=Smsas5XP9kATJgrCPlJwH36X7CX19/Y/MUlq+6C6jCw=; b=fjF8gSlAcOQ8lUHvzP2r/HG1St4blEhiykQXWkAeQwekKjnGufjuOP3H3pkaf4+IBk 12mLna4zUEr5tH/+VHUOOP5vcILPfG99W6BhOOzARuoXO6chaiNvCxjnYYCjvInObkZt YbqyXUKXJPmPgW5QFGXpLqfXCH1BvnQ5h2sTU= X-Forwarded-Encrypted: i=1; AJvYcCVUscGzaX1iTUCTY4y0e7LsWjnzQwdAorTWueLEtv+6CNxwJgMZkoe0qCEx/FvoYBw+Y2YvH+q7HrCPrGI=@vger.kernel.org X-Received: by 2002:a05:7022:a8a:b0:123:3500:b688 with SMTP id a92af1059eb24-1244a72e65fmr1689887c88.19.1768529432853; Thu, 15 Jan 2026 18:10:32 -0800 (PST) X-Received: by 2002:a05:7022:a8a:b0:123:3500:b688 with SMTP id a92af1059eb24-1244a72e65fmr1689874c88.19.1768529432339; Thu, 15 Jan 2026 18:10:32 -0800 (PST) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244ad72063sm1309212c88.6.2026.01.15.18.10.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 18:10:31 -0800 (PST) Message-ID: <84215494-ad8f-4bcd-8f76-cc2b9a5eb3f9@broadcom.com> Date: Thu, 15 Jan 2026 18:10:30 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 2/3] net: bcmasp: clean up some legacy logic To: justin.chen@broadcom.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260116005037.540490-1-justin.chen@broadcom.com> <20260116005037.540490-3-justin.chen@broadcom.com> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260116005037.540490-3-justin.chen@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 1/15/2026 4:50 PM, justin.chen@broadcom.com wrote: > From: Justin Chen > > Removed wol_irq check. This was needed for brcm,asp-v2.0, which was > removed in previous commits. > > Removed bcmasp_intf_ops. These function pointers were added to make > it easier to implement pseudo channels. These channels were removed > in newer versions of the hardware and were never implemented. > > Signed-off-by: Justin Chen Reviewed-by: Florian Fainelli -- Florian