From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Smirnov <asmirnou@pinefeat.co.uk>,
mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org
Cc: devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
Aliaksandr Smirnou <support@pinefeat.co.uk>
Subject: Re: [PATCH v2 1/2] dt-bindings: Pinefeat cef168 lens control board
Date: Tue, 12 Aug 2025 09:13:22 +0200 [thread overview]
Message-ID: <84262447-0877-4c52-8c80-65f1288e5944@kernel.org> (raw)
In-Reply-To: <20250811213102.15703-2-aliaksandr.smirnou@gmail.com>
On 11/08/2025 23:31, Alexander Smirnov wrote:
> +
Subject: missing media prefix.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
> +properties:
> + compatible:
> + enum:
> + - pinefeat,cef168
> +
> + reg:
> + maxItems: 1
> +
> + vcc-supply:
> + description: VDD 3v3 power supply
Property says VCC, description says VDD, datasheet says 5V (not 3.3V).
I guess this should be for the 5V case, no? If that's true, then I think
that 5V pin is not a controllable supply ever, because this product is
purely for RPi which has 5V pins directly tied to main power supply.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-08-12 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 21:31 [PATCH v2 0/2] Pinefeat cef168 lens control board driver Alexander Smirnov
2025-08-11 21:31 ` [PATCH v2 1/2] dt-bindings: Pinefeat cef168 lens control board Alexander Smirnov
2025-08-12 7:13 ` Krzysztof Kozlowski [this message]
2025-08-12 19:37 ` Aliaksandr Smirnou
2025-08-14 9:04 ` Krzysztof Kozlowski
2025-08-14 20:10 ` Aliaksandr Smirnou
2025-08-17 7:14 ` Krzysztof Kozlowski
2025-08-14 9:00 ` Krzysztof Kozlowski
2025-08-11 21:31 ` [PATCH v2 2/2] media/i2c: Pinefeat cef168 lens control board driver Alexander Smirnov
2025-08-13 1:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84262447-0877-4c52-8c80-65f1288e5944@kernel.org \
--to=krzk@kernel.org \
--cc=asmirnou@pinefeat.co.uk \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=support@pinefeat.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®