From: Christian Loehle <christian.loehle@arm.com>
To: 朱恺乾 <zhukaiqian@xiaomi.com>, "rafael@kernel.org" <rafael@kernel.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
"quic_zhonhan@quicinc.com" <quic_zhonhan@quicinc.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuidle: menu: find the typical interval by a heuristic classification method
Date: Mon, 28 Jul 2025 11:04:45 +0100 [thread overview]
Message-ID: <842e4029-e941-4024-9a1e-59bf8c8f1b18@arm.com> (raw)
In-Reply-To: <fa1c6faa96344fa9803675b179d7a329@xiaomi.com>
On 7/17/25 11:11, 朱恺乾 wrote:
> The iterations of deviation calculation gives too less predictions on
> the idle interval by trying to find a single repeating pattern from the
> whole history. This is not always the case when the workload is flowing.
>
> This algorithm assumes there're multiple repeating patterns heuristically,
> and tries to determine which is the most promising one from the averages
> of different idle states. It also takes the occurrence sequence into
> consideration, and gives the prediction close to the recent idle.
>
> This increased the shallow idle states detected, but the difference in deep
> sleep time didn't change a lot. The performance on my platform, as
> expected, has improved.
>
> Before:
> Multi-Core Score 7279
> Overall above under
> 34107 0.00 2.75
> 8200 59.90 7.02
> 29881 57.06 0.00
>
> After:
> Multi-Core Score 7365
> Overall above under
> 49913 0.00 6.43
> 7881 44.51 18.08
> 23108 52.38 0.00
>
> There's another re-classification method, which, instead of looking for the
> repeating-interval, tends to find the repeating state. It gives a better result
> on performance gain, but may hurt the power consumption.
>
> if (best_state == drv->state_count - 1 || state_avg[best_state] == 0) {
> adj_weight[best_state] += weights[i];
> adj_avg[best_state] += value;
> adj_hit[best_state]++;
> } else if (best_diff < state_avg[best_state] * 2) {
> adj_weight[best_state] += weights[i];
> adj_avg[best_state] += value;
> adj_hit[best_state]++;
> } else {
> adj_weight[best_state + 1] += weights[i];
> adj_avg[best_state + 1] += value;
> adj_hit[best_state + 1]++;
> }
>
> Repeating State:
> Multi-Core Score 7421
> Overall above under
> 60857 0.00 8.30
> 3838 29.88 18.42
> 15318 39.05 0.00
>
>
Would be nice to have statistical significance on those (I'm assuming Geekbench)
scores and a description of the systems idle state and maybe a comparison to
shallowest (only WFI enabled) and deepest (only max idle state enabled).
next prev parent reply other threads:[~2025-07-28 10:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-17 10:11 朱恺乾
2025-07-17 18:23 ` Rafael J. Wysocki
2025-07-28 10:04 ` Christian Loehle [this message]
2025-08-18 9:09 ` [External Mail]Re: " 朱恺乾
2025-07-18 10:52 朱恺乾
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=842e4029-e941-4024-9a1e-59bf8c8f1b18@arm.com \
--to=christian.loehle@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_zhonhan@quicinc.com \
--cc=rafael@kernel.org \
--cc=zhukaiqian@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome