mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Tobias.Jordan@elektrobit.com>
To: <wsa@the-dreams.de>
Cc: <der.herr@hofr.at>, <linux-i2c@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [SIL2review] [PATCH] i2c: img-scb: fix PM device usage count
Date: Tue, 17 Apr 2018 08:03:07 +0000	[thread overview]
Message-ID: <84353cd0444f41c4aebbc1b6eb2eeae3@denue6es008.ebgroup.elektrobit.com> (raw)
In-Reply-To: <20180416161845.hxizpjituo6mpvbm@ninjato>

Hi,

> Is it easily recognizable if the drivers check the error code because
> there is a reason or if they do it "out of habit"?

Probably by looking closely at the implementation of the PM callouts
for the driver, but I couldn't find a pattern that would be easy to
recognize. Maybe I didn't look close enough ;-)

I concur that removing the check would be a better approach if it's
clear that it's just done "out of habit".

Actually, the real problem is to find the drivers that need to have
the check in, add/fix it for them, and remove it for all others.

Unfortunately, all I'm currently able to do is finding the parts that
are inconsistent.

Tobias

      reply	other threads:[~2018-04-17  8:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-24 22:43 Tobias Jordan
2018-02-25 13:20 ` [SIL2review] " Nicholas Mc Guire
2018-02-25 16:27   ` Tobias Jordan
2018-04-16 16:18     ` Wolfram Sang
2018-04-17  8:03       ` Tobias.Jordan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84353cd0444f41c4aebbc1b6eb2eeae3@denue6es008.ebgroup.elektrobit.com \
    --to=tobias.jordan@elektrobit.com \
    --cc=der.herr@hofr.at \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®