From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E35C001DB for ; Tue, 8 Aug 2023 16:58:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233826AbjHHQ6a (ORCPT ); Tue, 8 Aug 2023 12:58:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233670AbjHHQ5k (ORCPT ); Tue, 8 Aug 2023 12:57:40 -0400 Received: from xry111.site (xry111.site [89.208.246.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B5F41FF2 for ; Tue, 8 Aug 2023 08:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xry111.site; s=default; t=1691481389; bh=XGCtQaY1fBiZaLV8w8R9Yc6KVjaILCVagr6X2S6pXBs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=X3/gIFazMGASFfLBwiDYLPix2AKIiATjzprJlsPAl4xiCUigQljLY98J4WWoopYQO QS5sqT1u/8cjGe3zP9YtNTAuMRd+iv/tt0GPDZZXVjg9LDMZM9+fKw25HnnCbQSN3R ArECw1kqC2XSoCZ2/kEXx9aWSwbfr4wdTZ00QQZ4= Received: from localhost.localdomain (xry111.site [IPv6:2001:470:683e::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-384) server-digest SHA384) (Client did not present a certificate) (Authenticated sender: xry111@xry111.site) by xry111.site (Postfix) with ESMTPSA id 57600659C7; Tue, 8 Aug 2023 03:56:28 -0400 (EDT) Message-ID: <843a059dec8607ce694adb82ddcbda2dfc01f833.camel@xry111.site> Subject: Re: [PATCH] loongarch: Remove spurious "source drivers/firmware/Kconfig" From: Xi Ruoyao To: Huacai Chen Cc: loongarch@lists.linux.dev, WANG Xuerui , linux-kernel@vger.kernel.org Date: Tue, 08 Aug 2023 15:56:26 +0800 In-Reply-To: References: <20230808034836.418485-1-xry111@xry111.site> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2023-08-08 at 15:16 +0800, Huacai Chen wrote: > Hi, Ruoyao, >=20 > I think the title should be "LoongArch: Remove redundant "source > drivers/firmware/Kconfig""? Yes, it looks better. I've sent v2 with the change. Thanks! >=20 > Huacai >=20 > On Tue, Aug 8, 2023 at 11:49=E2=80=AFAM Xi Ruoyao wr= ote: > >=20 > > In drivers/Kconfig, drivers/firmware/Kconfig is sourced for all > > ports so > > there is no need to source it in the port-specific Kconfig file.=C2=A0 > > And > > sourcing it here also caused the "Firmware Drivers" menu appeared > > two > > times: once in the "Device Drivers" menu, another time in the > > toplevel > > menu.=C2=A0 This was really puzzling. > >=20 > > Signed-off-by: Xi Ruoyao > > --- > > =C2=A0arch/loongarch/Kconfig | 2 -- > > =C2=A01 file changed, 2 deletions(-) > >=20 > > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > > index e71d5bf2cee0..465759f6b0ed 100644 > > --- a/arch/loongarch/Kconfig > > +++ b/arch/loongarch/Kconfig > > @@ -662,5 +662,3 @@ source "kernel/power/Kconfig" > > =C2=A0source "drivers/acpi/Kconfig" > >=20 > > =C2=A0endmenu > > - > > -source "drivers/firmware/Kconfig" > > -- > > 2.41.0 > >=20 --=20 Xi Ruoyao School of Aerospace Science and Technology, Xidian University