From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 109E1ECAAD6 for ; Fri, 26 Aug 2022 14:42:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344534AbiHZOmX (ORCPT ); Fri, 26 Aug 2022 10:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230255AbiHZOmT (ORCPT ); Fri, 26 Aug 2022 10:42:19 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37F27D3996 for ; Fri, 26 Aug 2022 07:42:18 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id m3-20020a05600c3b0300b003a5e0557150so4179389wms.0 for ; Fri, 26 Aug 2022 07:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=lZLJoIWsXsqa+EaO47AoJNbezNHg+wFL+Ah5uTdYlwk=; b=KLyLNrCoJwl+5GwKMfIX792NGKHxwN6CwoN19TkfC9cJysJIjrduUKHxb0+yWzgPD0 E1cvx9do1g7IrPPt+Pb7osZ9oZI02WQCKE4T8tBaK0SmdrzMqVx85I4eRc+XvcrVNTXG veK3oQmN5PqjIuWiG7Wfc8/opAook1+EgHPj1wr8CMYu1OZbJijFDAvEUlu26MiT5tNi fgKnVtCy9t4zDW5s8MkjjwWmalXolPLhHi2fJpdJ8l/lxTAq9aJ76hpYnOLly7cPNUcq +MKkcsxtNyAhqRvSkYFMBAsZJcbLwhOPPZypSTBaBzzbN31iaZvSrhAarROudcEp38Nk HQWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=lZLJoIWsXsqa+EaO47AoJNbezNHg+wFL+Ah5uTdYlwk=; b=1R3+WVcsCMDz80bmHGHJdXwtnZz2QXhGBSR89DEy/AONfQzBEXIN3dcNojRwcLJXkp rR4XGs/2vNqLU1t1f+LAzFutwuFvOoN13f1FfZezeHqcxBmODYtjrY1bxLf0GJg7hKpN cVCvEYFBT1kZMHlM5R5vyYwHoimS3FeUHgIGgAcgSnHfcYOpeJdVrPYKr2APsfTc2MQG 9Nr+boZ9hIgCuHZ1OouMGNaCJ0nAFprJrFhoHaFF0VKOEhMFxpPpKigR8JIv83y7ndtJ xnggo3/k0WDCRQ+x54YcNZPAuM2mJDjieqyGMhMHZIyLAhbl+5CIV9zgTMDMd9wyd8zT eQQQ== X-Gm-Message-State: ACgBeo1iOdExOFSrV5Ja+woibJ/g5AKLi5OsQuiptLNmLcez/JMdz1C8 FOdYw22/XAH3gnmn6PyK8ZvKBS0wBLZ98ELv X-Google-Smtp-Source: AA6agR6DMgDGXJ3XhgJFIVcmP9tyyxiw62Mu4CdcheESQmuIWil8nfX+s4MTdQxlI0jsktqF1CsfAQ== X-Received: by 2002:a1c:3b04:0:b0:3a5:487c:6240 with SMTP id i4-20020a1c3b04000000b003a5487c6240mr11564634wma.152.1661524936715; Fri, 26 Aug 2022 07:42:16 -0700 (PDT) Received: from [10.83.37.24] ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id t18-20020a5d49d2000000b00224f5bfa890sm2052764wrs.97.2022.08.26.07.42.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Aug 2022 07:42:16 -0700 (PDT) Message-ID: <843fda3c-f1bd-61e0-e94d-38026ad98e5f@arista.com> Date: Fri, 26 Aug 2022 15:42:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 02/31] crypto_pool: Add crypto_pool_reserve_scratch() Content-Language: en-US To: Dan Carpenter , kbuild@lists.01.org, Eric Dumazet , "David S. Miller" , linux-kernel@vger.kernel.org Cc: lkp@intel.com, kbuild-all@lists.01.org, netdev@vger.kernel.org, Andy Lutomirski , Ard Biesheuvel , Bob Gilligan , David Ahern , Eric Biggers , Francesco Ruggeri , Herbert Xu , Hideaki YOSHIFUJI , Ivan Delalande , Jakub Kicinski , Leonard Crestez , Paolo Abeni , Salam Noureddine , Shuah Khan , linux-crypto@vger.kernel.org References: <202208221817.t5uzfegL-lkp@intel.com> From: Dmitry Safonov In-Reply-To: <202208221817.t5uzfegL-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 8/22/22 11:45, Dan Carpenter wrote: > Hi Dmitry, [..] > "err" not set. It was supposed to be set to zero at the start. But > better to say "ret = i;" here maybe? > > Why is i unsigned? It leads to unsightly casts. Presumably some static > checker insists on this... :/ Thanks! Will be addressed/reworked in v2. Thank you, Dmitry