From: Joel Fernandes <joel@joelfernandes.org>
To: paulmck@kernel.org
Cc: rcu@vger.kernel.org, linux-kernel@vger.kernel.org,
rushikesh.s.kadam@intel.com, urezki@gmail.com,
neeraj.iitr10@gmail.com, frederic@kernel.org,
rostedt@goodmis.org, vineeth@bitbyteword.org
Subject: Re: [PATCH v2 1/8] rcu: Introduce call_rcu_lazy() API implementation
Date: Tue, 12 Jul 2022 17:10:41 -0400 [thread overview]
Message-ID: <8441c152-2953-3cb1-c585-b3b0d48a363f@joelfernandes.org> (raw)
In-Reply-To: <20220712210406.GF1790663@paulmck-ThinkPad-P17-Gen-1>
On 7/12/2022 5:04 PM, Paul E. McKenney wrote:
> On Tue, Jul 12, 2022 at 04:53:48PM -0400, Joel Fernandes wrote:
>>
>> On 7/10/2022 12:03 PM, Paul E. McKenney wrote:
>> [..]
>>>>>> + // Note that if the bypass list has lazy CBs, and the main list is
>>>>>> + // empty, and rhp happens to be non-lazy, then we end up flushing all
>>>>>> + // the lazy CBs to the main list as well. That's the right thing to do,
>>>>>> + // since we are kick-starting RCU GP processing anyway for the non-lazy
>>>>>> + // one, we can just reuse that GP for the already queued-up lazy ones.
>>>>>> + if ((rdp->nocb_nobypass_count < nocb_nobypass_lim_per_jiffy && !lazy) ||
>>>>>> + (lazy && n_lazy_cbs >= qhimark)) {
>>>>>> rcu_nocb_lock(rdp);
>>>>>> *was_alldone = !rcu_segcblist_pend_cbs(&rdp->cblist);
>>>>>> if (*was_alldone)
>>>>>> trace_rcu_nocb_wake(rcu_state.name, rdp->cpu,
>>>>>> - TPS("FirstQ"));
>>>>>> - WARN_ON_ONCE(!rcu_nocb_flush_bypass(rdp, NULL, j));
>>>>>> + lazy ? TPS("FirstLazyQ") : TPS("FirstQ"));
>>>>>> + WARN_ON_ONCE(!rcu_nocb_flush_bypass(rdp, NULL, j, false));
>>>>>
>>>>> The "false" here instead of "lazy" is because the caller is to do the
>>>>> enqueuing, correct?
>>>>
>>>> There is no difference between using false or lazy here, because the bypass
>>>> flush is not also enqueuing the lazy callback, right?
>>>>
>>>> We can also pass lazy instead of false if that's less confusing.
>>>>
>>>> Or maybe I missed the issue you're raising?
>>>
>>> I am mostly checking up on your intended meaning of "lazy" in various
>>> contexts. It could mean only that the caller requested laziness, or in
>>> some cases it could mean that the callback actually will be lazy.
>>>
>>> I can rationalize the "false" above as a "don't care" in this case
>>> because (as you say) there is not callback. In which case this code
>>> is OK as is, as long as the header comment for rcu_nocb_flush_bypass()
>>> clearly states that this parameter has meaning only when there really
>>> is a callback being queued.
>>
>> I decided to change this and the below to "lazy" variable instead of
>> true/false, as the code is cleaner and less confusing IMO. It makes
>> sense to me and in my testing it works fine. Hope that's Ok with you.
>
> Sounds plausible.
>
>> About changing the lazy length count to a flag, one drawback of doing
>> that is, say if there are some non-lazy CBs in the bypass list, then the
>> lazy shrinker will end up reporting an inaccurate count. Also
>> considering that it might be harder to add the count back later say if
>> we need it for tracing, I would say lets leave it as is. I will keep the
>> counter for v3 and we can discuss. Does that sound good to you?
>
> You lost me on this one. If there are any non-lazy callbacks, the whole
> bypass list is already being treated as non-lazy, right? If so, then
> the lazy shrinker should report the full count if all callbacks are lazy,
> and should report none otherwise. Or am I missing something here?
>
That's one way to interpret it, another way is say there were a 1000
lazy CBs, and now 1 non-lazy came in. The shrinker could report the lazy
count as 0 per your interpretation. Yes its true they will get flushed
out in the next jiffie, but for that time instant, the number of lazy
CBs in the list is not zero! :) Yeah OK its a weak argument, still an
argument! ;-)
In any case, we saw the need for the length of the segcb lists to figure
out things via tracing, so I suspect we may need this in the future as
well, its a small cost so I would rather keep it if that's Ok with you! :)
Thanks,
- Joel
next prev parent reply other threads:[~2022-07-12 21:13 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 22:50 [PATCH v2 0/8] Implement call_rcu_lazy() and miscellaneous fixes Joel Fernandes (Google)
2022-06-22 22:50 ` [PATCH v2 1/1] context_tracking: Use arch_atomic_read() in __ct_state for KASAN Joel Fernandes (Google)
2022-06-22 22:58 ` Joel Fernandes
2022-06-22 22:50 ` [PATCH v2 1/8] rcu: Introduce call_rcu_lazy() API implementation Joel Fernandes (Google)
2022-06-22 23:18 ` Joel Fernandes
2022-06-26 4:00 ` Paul E. McKenney
2022-06-23 1:38 ` kernel test robot
2022-06-26 4:00 ` Paul E. McKenney
2022-07-08 18:43 ` Joel Fernandes
2022-07-08 23:10 ` Paul E. McKenney
2022-07-10 2:26 ` Joel Fernandes
2022-07-10 16:03 ` Paul E. McKenney
2022-07-12 20:53 ` Joel Fernandes
2022-07-12 21:04 ` Paul E. McKenney
2022-07-12 21:10 ` Joel Fernandes [this message]
2022-07-12 22:41 ` Paul E. McKenney
2022-06-29 11:53 ` Frederic Weisbecker
2022-06-29 17:05 ` Paul E. McKenney
2022-06-29 20:29 ` Joel Fernandes
2022-06-29 22:01 ` Frederic Weisbecker
2022-06-30 14:08 ` Joel Fernandes
2022-06-22 22:50 ` [PATCH v2 2/8] rcu: shrinker for lazy rcu Joel Fernandes (Google)
2022-06-22 22:50 ` [PATCH v2 3/8] fs: Move call_rcu() to call_rcu_lazy() in some paths Joel Fernandes (Google)
2022-06-22 22:50 ` [PATCH v2 4/8] rcu/nocb: Add option to force all call_rcu() to lazy Joel Fernandes (Google)
2022-06-22 22:50 ` [PATCH v2 5/8] rcu/nocb: Wake up gp thread when flushing Joel Fernandes (Google)
2022-06-26 4:06 ` Paul E. McKenney
2022-06-26 13:45 ` Joel Fernandes
2022-06-26 13:52 ` Paul E. McKenney
2022-06-26 14:37 ` Joel Fernandes
2022-06-22 22:51 ` [PATCH v2 6/8] rcuscale: Add test for using call_rcu_lazy() to emulate kfree_rcu() Joel Fernandes (Google)
2022-06-23 2:09 ` kernel test robot
2022-06-23 3:00 ` kernel test robot
2022-06-23 8:10 ` kernel test robot
2022-06-26 4:13 ` Paul E. McKenney
2022-07-08 4:25 ` Joel Fernandes
2022-07-08 23:06 ` Paul E. McKenney
2022-07-12 20:27 ` Joel Fernandes
2022-07-12 20:58 ` Paul E. McKenney
2022-07-12 21:15 ` Joel Fernandes
2022-07-12 22:41 ` Paul E. McKenney
2022-06-22 22:51 ` [PATCH v2 7/8] rcu/nocb: Rewrite deferred wake up logic to be more clean Joel Fernandes (Google)
2022-06-22 22:51 ` [PATCH v2 8/8] rcu/kfree: Fix kfree_rcu_shrink_count() return value Joel Fernandes (Google)
2022-06-26 4:17 ` Paul E. McKenney
2022-06-27 18:56 ` Uladzislau Rezki
2022-06-27 20:59 ` Paul E. McKenney
2022-06-27 21:18 ` Joel Fernandes
2022-06-27 21:43 ` Paul E. McKenney
2022-06-28 16:56 ` Joel Fernandes
2022-06-28 21:13 ` Joel Fernandes
2022-06-29 16:56 ` Paul E. McKenney
2022-06-29 19:47 ` Joel Fernandes
2022-06-29 21:07 ` Paul E. McKenney
2022-06-30 14:25 ` Joel Fernandes
2022-06-30 15:29 ` Paul E. McKenney
2022-06-29 16:52 ` Paul E. McKenney
2022-06-26 3:12 ` [PATCH v2 0/8] Implement call_rcu_lazy() and miscellaneous fixes Paul E. McKenney
2022-07-08 4:17 ` Joel Fernandes
2022-07-08 22:45 ` Paul E. McKenney
2022-07-10 1:38 ` Joel Fernandes
2022-07-10 15:47 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8441c152-2953-3cb1-c585-b3b0d48a363f@joelfernandes.org \
--to=joel@joelfernandes.org \
--cc=frederic@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neeraj.iitr10@gmail.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=rushikesh.s.kadam@intel.com \
--cc=urezki@gmail.com \
--cc=vineeth@bitbyteword.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®