From: Krzysztof Kozlowski <krzk@kernel.org>
To: Manush Prajwal <manushprajwal555@gmail.com>,
cw00.choi@samsung.com, lee@kernel.org, pavel@kernel.org
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
dsankouski@gmail.com, sakari.ailus@linux.intel.com
Subject: Re: [PATCH v2] leds: max77705: use fwnode_for_each_child_node_scoped() in max77705_add_led()
Date: Fri, 28 Aug 2026 11:25:05 +0200 [thread overview]
Message-ID: <8441fd0b-3ad0-4ff3-8bd5-c501a94b61a3@kernel.org> (raw)
In-Reply-To: <6a914e1e.7d702ed2.1273e8.2a52@mx.google.com>
On 28/08/2026 11:00, Manush Prajwal wrote:
> Rework the subled loop in max77705_add_led() around
> fwnode_for_each_child_node_scoped() instead of adding a manual
> fwnode_handle_put(child) before the early return on a
> max77705_parse_subled() failure, so the reference on the current
> child fwnode is released automatically on every exit path from the
> loop. child is never used outside the loop, so the now-unused outer
> child declaration is dropped along with it.
>
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
That's probably a stretch, I suggested only a solution, not the commit
itself. Anyway, no need to resend to change it.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
prev parent reply other threads:[~2026-08-28 9:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-28 9:00 Manush Prajwal
2026-08-28 9:25 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8441fd0b-3ad0-4ff3-8bd5-c501a94b61a3@kernel.org \
--to=krzk@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dsankouski@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=manushprajwal555@gmail.com \
--cc=pavel@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®