From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Satya Priya <quic_c_skakit@quicinc.com>,
Lee Jones <lee@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Andy Gross <agross@kernel.org>,
Alessandro Zummo <a.zummo@towertech.it>
Cc: linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode
Date: Fri, 21 Oct 2022 11:16:20 +0200 [thread overview]
Message-ID: <8443ca29-ea0f-f209-e3f6-20eca969ea7c@somainline.org> (raw)
In-Reply-To: <20220928-mdm9615-dt-schema-fixes-v4-11-dac2dfaac703@linaro.org>
On 21.10.2022 11:06, Neil Armstrong wrote:
> The separate amba device node doesn't add anything significant to the
> DT. The OF parsing code already creates amba_device or platform_device
> depending on the compatibility lists.
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
If we ever wanted to do split buses, per-NoC nodes would make sense, but
as you mentioned, this does not, really.
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>
Konrad
> arch/arm/boot/dts/qcom-mdm9615.dtsi | 78 +++++++++++++++++--------------------
> 1 file changed, 36 insertions(+), 42 deletions(-)
>
> diff --git a/arch/arm/boot/dts/qcom-mdm9615.dtsi b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> index 9d950f96280d..482fd246321c 100644
> --- a/arch/arm/boot/dts/qcom-mdm9615.dtsi
> +++ b/arch/arm/boot/dts/qcom-mdm9615.dtsi
> @@ -314,49 +314,43 @@ sdcc2bam: dma-controller@12142000{
> qcom,ee = <0>;
> };
>
> - amba {
> - compatible = "simple-bus";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges;
> - sdcc1: mmc@12180000 {
> - status = "disabled";
> - compatible = "arm,pl18x", "arm,primecell";
> - arm,primecell-periphid = <0x00051180>;
> - reg = <0x12180000 0x2000>;
> - interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
> - clock-names = "mclk", "apb_pclk";
> - bus-width = <8>;
> - max-frequency = <48000000>;
> - cap-sd-highspeed;
> - cap-mmc-highspeed;
> - vmmc-supply = <&vsdcc_fixed>;
> - dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
> - dma-names = "tx", "rx";
> - assigned-clocks = <&gcc SDC1_CLK>;
> - assigned-clock-rates = <400000>;
> - };
> + sdcc1: mmc@12180000 {
> + status = "disabled";
> + compatible = "arm,pl18x", "arm,primecell";
> + arm,primecell-periphid = <0x00051180>;
> + reg = <0x12180000 0x2000>;
> + interrupts = <GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc SDC1_CLK>, <&gcc SDC1_H_CLK>;
> + clock-names = "mclk", "apb_pclk";
> + bus-width = <8>;
> + max-frequency = <48000000>;
> + cap-sd-highspeed;
> + cap-mmc-highspeed;
> + vmmc-supply = <&vsdcc_fixed>;
> + dmas = <&sdcc1bam 2>, <&sdcc1bam 1>;
> + dma-names = "tx", "rx";
> + assigned-clocks = <&gcc SDC1_CLK>;
> + assigned-clock-rates = <400000>;
> + };
>
> - sdcc2: mmc@12140000 {
> - compatible = "arm,pl18x", "arm,primecell";
> - arm,primecell-periphid = <0x00051180>;
> - status = "disabled";
> - reg = <0x12140000 0x2000>;
> - interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
> - clock-names = "mclk", "apb_pclk";
> - bus-width = <4>;
> - cap-sd-highspeed;
> - cap-mmc-highspeed;
> - max-frequency = <48000000>;
> - no-1-8-v;
> - vmmc-supply = <&vsdcc_fixed>;
> - dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
> - dma-names = "tx", "rx";
> - assigned-clocks = <&gcc SDC2_CLK>;
> - assigned-clock-rates = <400000>;
> - };
> + sdcc2: mmc@12140000 {
> + compatible = "arm,pl18x", "arm,primecell";
> + arm,primecell-periphid = <0x00051180>;
> + status = "disabled";
> + reg = <0x12140000 0x2000>;
> + interrupts = <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&gcc SDC2_CLK>, <&gcc SDC2_H_CLK>;
> + clock-names = "mclk", "apb_pclk";
> + bus-width = <4>;
> + cap-sd-highspeed;
> + cap-mmc-highspeed;
> + max-frequency = <48000000>;
> + no-1-8-v;
> + vmmc-supply = <&vsdcc_fixed>;
> + dmas = <&sdcc2bam 2>, <&sdcc2bam 1>;
> + dma-names = "tx", "rx";
> + assigned-clocks = <&gcc SDC2_CLK>;
> + assigned-clock-rates = <400000>;
> };
>
> tcsr: syscon@1a400000 {
>
next prev parent reply other threads:[~2022-10-21 9:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 9:06 [PATCH v4 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 01/11] dt-bindings: arm: qcom: move swir,mangoh-green-wp8548 board documentation to qcom.yaml Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 02/11] arm: dts: qcom: mdm9615*: add SPDX-License-Identifier Neil Armstrong
2022-10-21 13:42 ` Krzysztof Kozlowski
2022-10-21 13:43 ` Krzysztof Kozlowski
2022-10-21 9:06 ` [PATCH v4 03/11] arm: dts: qcom: mdm9615: add missing reg in cpu@0 node Neil Armstrong
2022-10-21 9:14 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 04/11] arm: dts: qcom: mdm9615: remove invalid spi-max-frequency gsbi3_spi node Neil Armstrong
2022-10-21 9:14 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 05/11] dt-bindings: mfd: qcom-pm8xxx: document qcom,pm8921 as fallback of qcom,pm8018 Neil Armstrong
2022-10-31 15:31 ` Lee Jones
2022-10-21 9:06 ` [PATCH v4 06/11] dt-bindings: input: qcom,pm8921-pwrkey: convert to dt-schema Neil Armstrong
2022-10-27 7:55 ` Dmitry Torokhov
2022-10-27 12:39 ` Neil Armstrong
2022-10-27 12:43 ` Krzysztof Kozlowski
2022-10-28 0:53 ` Dmitry Torokhov
2022-10-21 9:06 ` [PATCH v4 07/11] dt-bindings: rtc: qcom-pm8xxx: document qcom,pm8921-rtc as fallback of qcom,pm8018-rtc Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 08/11] mfd: qcom-pm8xxx: drop unused PM8018 compatible Neil Armstrong
2022-10-31 15:32 ` Lee Jones
2022-10-31 15:35 ` Neil Armstrong
2022-11-02 14:10 ` Krzysztof Kozlowski
2022-11-02 14:40 ` Lee Jones
2022-10-21 9:06 ` [PATCH v4 09/11] rtc: pm8xxx: drop unused pm8018 compatible Neil Armstrong
2022-10-21 9:16 ` Konrad Dybcio
2022-10-21 9:06 ` [PATCH v4 10/11] arm: dts: qcom: mdm9615: remove invalid interrupt-names from pl18x mmc nodes Neil Armstrong
2022-10-21 9:06 ` [PATCH v4 11/11] arm: dts: qcom: mdm9615: remove useless amba subnode Neil Armstrong
2022-10-21 9:16 ` Konrad Dybcio [this message]
2022-11-07 3:12 ` (subset) [PATCH v4 00/11] arm: qcom: mdm9615: first round of bindings and DT fixes Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8443ca29-ea0f-f209-e3f6-20eca969ea7c@somainline.org \
--to=konrad.dybcio@somainline.org \
--cc=a.zummo@towertech.it \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_c_skakit@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®