From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6EED0D272 for ; Thu, 4 Apr 2024 14:52:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712242331; cv=none; b=nWgsttzdolvUwy2Upde1Pv1YsFm0v9TTjqAPRt9jxevcP0SYlG177h31CELK+E8CNc176j4mCG06TcQg4PFXXwhehra4MHiDySoPfPNPtwbmh1G3nhbqzWcUZSMVyvNZYRFKD8jOWjYxyhy3SNZgUYhu+85+Uc/+pqOEVlpAd2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712242331; c=relaxed/simple; bh=QF9HkIuWsSic0KX2uG9t0B+7k4VvuK+u22k6FjJNdAo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DewYeKk/WzfaX96E7Orh0l9YqbKsaJcTELnGfhiEBRqt3ziovxHR2denZeunyAF1t812f/VPwn5IRuv9hjqcxezLAmCyo32Mb2ch+DxLVsZae2ipez7pNLH8YH/csZyITEOSofYN62vxl8pGbDmjylUFFGQtHVX83rKKwSTGoiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.dmz-prg2.suse.org (imap2.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C17D337AE7; Thu, 4 Apr 2024 14:52:08 +0000 (UTC) Authentication-Results: smtp-out1.suse.de; none Received: from imap2.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap2.dmz-prg2.suse.org (Postfix) with ESMTPS id 4237D139E8; Thu, 4 Apr 2024 14:52:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap2.dmz-prg2.suse.org with ESMTPSA id AbN3DZi+DmbiEAAAn2gu4w (envelope-from ); Thu, 04 Apr 2024 14:52:08 +0000 Message-ID: <8443e745-3bbb-4be0-a36f-3a6135935aa4@suse.de> Date: Thu, 4 Apr 2024 16:52:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] nvmet-fc: move RCU read lock to nvmet_fc_assoc_exists Content-Language: en-US To: Daniel Wagner , James Smart Cc: Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240404144131.17988-1-dwagner@suse.de> <20240404144131.17988-2-dwagner@suse.de> From: Hannes Reinecke In-Reply-To: <20240404144131.17988-2-dwagner@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spam-Level: X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Spam-Flag: NO X-Spam-Score: -4.00 X-Rspamd-Queue-Id: C17D337AE7 On 4/4/24 16:41, Daniel Wagner wrote: > The RCU lock is only needed for the lookup loop and not for > list_ad_tail_rcu call. Thus move it down the call chain into > nvmet_fc_assoc_exists. > > While at it also fix the name typo of the function. > > Signed-off-by: Daniel Wagner > --- > drivers/nvme/target/fc.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich