From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Mark Brown <broonie@kernel.org>
Cc: Bartosz Golaszewski <brgl@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Madhavan Srinivasan <maddy@linux.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc: eeprom: at24: Make VCC supply description requirement optional
Date: Mon, 25 May 2026 09:07:42 +0200 [thread overview]
Message-ID: <84448a84-1c96-45a9-9ba8-1e058d0bf8a5@molgen.mpg.de> (raw)
In-Reply-To: <ahN2m3kCbyTUNXzZ@sirena.org.uk>
Dear Mark,
Thank you for taking the time to review and respond.
Am 25.05.26 um 00:07 schrieb Mark Brown:
> On Sun, May 24, 2026 at 10:05:33AM +0200, Paul Menzel wrote:
>
>> Some platforms (e.g. IBM Power System S822LC (8335-GCA POWER8)) do not
>> describe the EEPROM’s VCC supply in firmware-provided device trees.
>> Using `devm_regulator_get()` on such systems falls back to a dummy
>> regulator with a kernel warning:
>
>> Switch to `devm_regulator_get_optional()` and treat -ENODEV as “no
>> supply described”. When `vcc_reg` is NULL, skip all
>> regulator_enable/disable calls; the hardware is assumed to be always
>> powered. Linux now logs:
>
> This is not appropriate unless the device can actually operate without
> power, any driver could be used in a system where the firmware does not
> describe the regultors and it'd obviously be pointless and error prone
> to scatter bodges like this on every single call to a regulator API
> function.
How should the warning on the POWER server be addressed then?
Kind regards,
Paul
next prev parent reply other threads:[~2026-05-25 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-24 8:05 Paul Menzel
2026-05-24 22:07 ` Mark Brown
2026-05-25 7:07 ` Paul Menzel [this message]
2026-05-25 10:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84448a84-1c96-45a9-9ba8-1e058d0bf8a5@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=arnd@arndb.de \
--cc=brgl@kernel.org \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lgirdwood@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®