From: Jens Remus <jremus@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
bpf@vger.kernel.org, x86@kernel.org
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrii Nakryiko <andrii@kernel.org>,
Indu Bhagat <indu.bhagat@oracle.com>,
"Jose E. Marchesi" <jemarch@gnu.org>,
Beau Belgrave <beaub@linux.microsoft.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Florian Weimer <fweimer@redhat.com>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH v12 07/11] perf: Support deferred user callchains for per CPU events
Date: Wed, 2 Jul 2025 14:20:07 +0200 [thread overview]
Message-ID: <8446a4a9-023f-4f74-a15c-82450f239c13@linux.ibm.com> (raw)
In-Reply-To: <20250701180456.716085204@goodmis.org>
Hello Steve!
On 01.07.2025 20:04, Steven Rostedt wrote:
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> @@ -5609,62 +5784,119 @@ static void perf_pending_unwind_sync(struct perf_event *event)
>
> struct perf_callchain_deferred_event {
> struct perf_event_header header;
> + u64 timestamp;
> u64 nr;
> u64 ips[];
> };
Nit: Please update the following related comments when making changes to
struct perf_callchain_deferred_event.
diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h
index 184740d1e79d..08ce721e79bc 100644
--- a/include/uapi/linux/perf_event.h
+++ b/include/uapi/linux/perf_event.h
@@ -1248,6 +1248,7 @@ enum perf_event_type {
*
* struct {
* struct perf_event_header header;
+ * u64 timestamp;
* u64 nr;
* u64 ips[nr];
* struct sample_id sample_id;
diff --git a/tools/include/uapi/linux/perf_event.h b/tools/include/uapi/linux/perf_event.h
index 184740d1e79d..08ce721e79bc 100644
--- a/tools/include/uapi/linux/perf_event.h
+++ b/tools/include/uapi/linux/perf_event.h
@@ -1248,6 +1248,7 @@ enum perf_event_type {
*
* struct {
* struct perf_event_header header;
+ * u64 timestamp;
* u64 nr;
* u64 ips[nr];
* struct sample_id sample_id;
Thanks and regards,
Jens
--
Jens Remus
Linux on Z Development (D3303)
+49-7031-16-1128 Office
jremus@de.ibm.com
IBM
IBM Deutschland Research & Development GmbH; Vorsitzender des Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/
next prev parent reply other threads:[~2025-07-02 12:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 18:04 [PATCH v12 00/11] perf: Support the deferred unwinding infrastructure Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 01/11] perf: Remove get_perf_callchain() init_nr argument Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 02/11] perf: Have get_perf_callchain() return NULL if crosstask and user are set Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 03/11] perf: Use current->flags & PF_KTHREAD|PF_USER_WORKER instead of current->mm == NULL Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 04/11] perf: Simplify get_perf_callchain() user logic Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 05/11] perf: Skip user unwind if the task is a kernel thread Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 06/11] perf: Support deferred user callchains Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 07/11] perf: Support deferred user callchains for per CPU events Steven Rostedt
2025-07-02 12:20 ` Jens Remus [this message]
2025-07-01 18:04 ` [PATCH v12 08/11] perf tools: Minimal CALLCHAIN_DEFERRED support Steven Rostedt
2025-07-02 12:23 ` Jens Remus
2025-07-02 16:28 ` Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 09/11] perf record: Enable defer_callchain for user callchains Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 10/11] perf script: Display PERF_RECORD_CALLCHAIN_DEFERRED Steven Rostedt
2025-07-01 18:04 ` [PATCH v12 11/11] perf tools: Merge deferred user callchains Steven Rostedt
2025-07-01 19:17 ` [PATCH v12 00/11] perf: Support the deferred unwinding infrastructure Steven Rostedt
2025-07-01 19:24 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8446a4a9-023f-4f74-a15c-82450f239c13@linux.ibm.com \
--to=jremus@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=axboe@kernel.dk \
--cc=beaub@linux.microsoft.com \
--cc=bpf@vger.kernel.org \
--cc=fweimer@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=indu.bhagat@oracle.com \
--cc=jemarch@gnu.org \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®