From: Keith Owens <kaos@ocs.com.au>
To: Sebastian Huber <sebastian-huber@web.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: modversion.h improvement suggestion
Date: Mon, 06 May 2002 09:43:00 +1000 [thread overview]
Message-ID: <8447.1020642180@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Sun, 05 May 2002 18:00:51 +0200." <E174OQu-0007H2-00@smtp.web.de>
On Sun, 5 May 2002 18:00:51 +0200,
Sebastian Huber <sebastian-huber@web.de> wrote:
>So what about a default modversion.h file:
>/* This is an automatically generated file. Do not edit it. */
>#error You have not generated the module versions. You have to ...
No.
It is a big mistake to ship a file and overwrite it under the same
name. It messes up source repositories.
Any code that has an explicit #include <linux/modversions.h> is broken.
The kernel build automatically includes modversions.h when required.
The build instructions for third party modules should say something
like
If your kernel was built with CONFIG_MODVERSIONS=y then add these
flags to the build for this module
-DMODVERSIONS -include kernel_source_tree/linux/modversions.h
In any case, modversions.h will disappear in kbuild 2.5.
next prev parent reply other threads:[~2002-05-05 23:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-05 16:00 Sebastian Huber
2002-05-05 23:43 ` Keith Owens [this message]
2002-05-06 21:03 ` Olaf Titz
2002-05-07 4:55 ` Keith Owens
2002-05-06 15:39 ` Alan Cox
[not found] <Pine.GSO.4.05.10205051818350.20954-100000@mausmaki.cosy.sbg.ac.at>
2002-05-05 16:36 ` Sebastian Huber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8447.1020642180@ocs3.intra.ocs.com.au \
--to=kaos@ocs.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian-huber@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®