From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7383330328 for ; Sat, 14 Mar 2026 21:39:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773524388; cv=none; b=pI+PeXJXRYzyhvYBlohs6d5LCrk8Jq0rygcLP1FyFZLm3mFOYDyX10hTmnKPUbPcGkUQ3f81pAkfUpaYm4OyJQQXMsop8GyQh9vBLP3ymXUMMMrUKIIHL4JEBonzhgqmGNiP6MqrFsddPoxmDRy5ie/4jx88p+b6nZdb5BesTNc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773524388; c=relaxed/simple; bh=Cjid4llN8U4wFU73pi8DExNdpsjC2Bk83AyqgwVq+SU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gWkkIrXXWLWFnjid0isDjNXMuxS6pG6ECaMKbToNQu7TSU1cp+KInPN9YHwkj+sCpZAmYfNwp9NUik22y5HDC8kf25HxYWbi2ukmhL5xsMwFoonGr0aTOZkiiN5axxqt70UStibLkJimdDMIHKl8oTQLtfwV8lCGols1MW77DeU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=sQwfllty; arc=none smtp.client-ip=209.85.210.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="sQwfllty" Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-7d749f99691so1606617a34.3 for ; Sat, 14 Mar 2026 14:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1773524385; x=1774129185; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ro811a96fh+jbA/xvorkVanktgU1K3n1kQCoKnRbkIQ=; b=sQwflltyNCYJJkuBPYk+JV9u6BnK+n+f3nxw6EVVnGM56NxifuNXWD+5D56RsL8ePK enk4mHFSRkNb2Qo0vizpYUB7stNxu5lanHDpOCdJxrQ8ioWH9hNiOyfFGnp+q+weePh7 gmWND/PLRLxBIs2360eCBmCAhKOewnZQmWRo29BGNBSbICS+WS5BNTSlkA1Ndpg7pORQ tZ6sjYf9rwsebDvkPKzaNJB/o/xaaerV+17MIXCZYKVm/6x6uCS78cPEJZVw88T4WX5Y Mh+9tPr0LVH8jgyjd1Iz7dAHpApmye7moO+mmNKQLK2HFwnCks+fGtBkA2jVC+LBigf7 hvDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773524385; x=1774129185; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ro811a96fh+jbA/xvorkVanktgU1K3n1kQCoKnRbkIQ=; b=syBpNtJNRmhYP3OkswrHHNAo522dn/RODkKJnlJlW+s6YMx0RxnmGvFrcYfOBo4YVB s/dIG75tZu6d5K2PibFCRiTIi1pTixxlydEHAJJBw7/9M8seEL/OW3ARzy67NhvsnOS4 XENZwQW5x3bpgRORFdOhkPDWUSzcSllnkShKANPVhXh59Wt6vJO/YN9x7LQBpT3ECCOD 0biALEwH0m8IMTNtvsrEva/kHwPSf+XP2lzoA5mtk24LblQUYHY4vzPSDg2EDpjSnGz3 Yx9ffFUeZ/cUhv20cTAQXXJ256Q4L71LvIfHbnV6to8wJJNjC67bwV6YbC//Qml0E3I0 5KvQ== X-Forwarded-Encrypted: i=1; AJvYcCXL4UHX+X+PYcE3VlfahCz61+/ffatEGG+tssR0fLaX5o7/512z7CSF9+pzWJ7CgSBz/i7lzqsxYqZwV9I=@vger.kernel.org X-Gm-Message-State: AOJu0YxOhAw+wj4eKM3sGcqG2HTmqRlT1xfhJn8cyS9/9TcxMUE4ZAZ9 RWeFkRaHWy4/bdk8lQPKAvQZfsvt/PiZ8RC5EL7rfxNKxySk5kTkTVo3E/IrrkoQOgk= X-Gm-Gg: ATEYQzwc6KrcnZYbmsI1Bwyz42TmghgnybkfLd5sg7+SaETzBSkxCmyltZqrzW/4BJt evjy6UgDNmeCjrp4BxGmKaqFpvGPUXorlQfl+s5Gtb0D4iASXCOZtdBMjbHnTtqMBLwJlONLS0i g5ABFIbpcWJlogMcjasGL8nI8InTPZqZVZ6a78ZQhw5Yi99VkUw0N9cxCgAEOOibPKZqAbcpRNv BgqjMchpBC83YUiExTMt78s6PNDa9fcXHZF0wyxHyWtUApP1dER7ttzH5qFHQNlgrE3Zj2fWJ4n BWpgVdlCzM+Sw/02PAk0du0j0hiPq3Yhzr1Ewf+ZLHh685plGaFtGjunI7MXP6mElJ+mfRIs5rb mdq9xI3bJT5aB4PQ2Pe+5GGfDNH57HD6bHjwnz3otaAxM/P+yDyEO3MZ3yA81mh2RZCP4oAWvBG ripcQVMkCU2DeSPoCe4uF9i4bSR+3uWGqsVuI7a2ZCbBK8OOIyGn9poeZ6K1ZCAWbC8H9s86S4e BUf6Wk/SZEO X-Received: by 2002:a05:6830:3e07:b0:7cf:e57f:df1b with SMTP id 46e09a7af769-7d7825476edmr4747941a34.26.1773524385674; Sat, 14 Mar 2026 14:39:45 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:14a9:db6c:e65a:4287? ([2600:8803:e7e4:500:14a9:db6c:e65a:4287]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d76ae398fcsm8784176a34.16.2026.03.14.14.39.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 14 Mar 2026 14:39:44 -0700 (PDT) Message-ID: <84473bc2-727e-4440-bade-d9cc3ee62698@baylibre.com> Date: Sat, 14 Mar 2026 16:39:42 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] iio: imu: bno055: add explicit scan buf layout To: Andy Shevchenko Cc: Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260228-iio-imu-bno055-repeated-element-v2-1-888676158804@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/2/26 2:59 AM, Andy Shevchenko wrote: > On Sat, Feb 28, 2026 at 02:15:51PM -0600, David Lechner wrote: >> Move the scan buf.chans array into a union along with a struct that >> gives the layout of the buffer with all channels enabled. >> >> Although not technically required in this case, if there had been a >> different number of items before the quaternion, there could have been >> a subtle bug with the special alignment needed for the quaternion >> channel data and the array would have been too small. > > Cool thing! > Reviewed-by: Andy Shevchenko > Forgot to mention in v3 that I didn't pick up the tag because I changed it significantly, so worth another look.