From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 939E9DF78 for ; Wed, 5 Jun 2024 18:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717612825; cv=none; b=VCiiuzMmdR3xkll7oUkLhKCdYYyMPJvuBH9NTgMO2gW/P8nJRQuDfFKiJzUOns/6DAeD4zICVEPWT7sjo5c9IxTo9gPQkviErXHaX3zvqdq6pVftgzIkz0PNZFctph58hQS0J5Z9hcBODQTYuDVDtV685BySdngI23EKQjyKZvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717612825; c=relaxed/simple; bh=HDAlcS57GK25baYDQl/y1dFbksUihFMOcZW+n2UCDzc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F01tfFwpyHSiwYBRKl5aeihWSECuCVePTwRAVmJ6Zzpf/ur2L/Z4AKEyNEUQdzYO++VeiwAQgyQMlDpTzOY4GUWCo3xyN4M4XO4KTNGm2tUZRwAhs7bDLPUOlDTWlEf/+TiuwDx1a3qJMZYtv6oNQI3bkmJaTnjWDDWPITfKjHk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=nUnhafkL; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="nUnhafkL" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-6f93d757f29so42902a34.1 for ; Wed, 05 Jun 2024 11:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1717612822; x=1718217622; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=01CW9viXfpn/hTRJYVVBrZV+RhXTgdyAXCGw5dC1AEw=; b=nUnhafkLUu4MaEJOeFsLoY9MNwGlFOepbpfURA61lv7lb5bHu1EwN5qHjNIZgstS3E pUMo1cgjXcHzeL9axSnhSb/sGV7SBUW0PsArjywhLqS2oM0uUmWVL4dXwhYRIr6YyHHH 9RjY4rqCk18RfPHcykf3WVfYh38AHOcrWc1HPLwLxfofw9tzZpfv4h8gbTXHrDf8tdKa LGhlS8PcQCdvwoz5v+KRMmi1GNh0+fOCiMRHlJ1DrLn3jS5IO8JugbSMj3GvKuqCWeRU J3wED2KqsIhJ2wVPeI/yEKt6zCdt/z/5w2bOmj1b1Wg/pmeOwInxtu96e57Wy6RnDSNy +YnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717612822; x=1718217622; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=01CW9viXfpn/hTRJYVVBrZV+RhXTgdyAXCGw5dC1AEw=; b=hDhylHyNR0DUh1GdcXrfveOizc4S2Nt0y3PWJZnMidOs/2t/jTwTHdTUWawHoH5Ut1 m3raQxdOzllTcGFgXw9Q0k7KyW0YDOHdsGIyBuecHJUGdArs4UHfqLeS+b4bMr45nXca 5JqxjK8N5ZNdTQUK7RxYHUIkSYxPfOMum84ktX9ax+ghfVNPepL6qq/oEZDC2ICe5rGN NWCbRJmAtszDpPTv7s+2BqEGSW9lPeDEYwHl/PKWv1pUw+joBDu1nL0zUy4bBeZeMwkM ArflAI1idny9KNjtysl+OAL54oMHamFdMo00OwooSfog/X2IFa6YEMv/4bGaapruD2JJ 2YGA== X-Forwarded-Encrypted: i=1; AJvYcCWhmEQlDPp6Y9wyoANZsD6lT4mRYo6D8xaWIfvkyh7fBMuPG4vzZi3wwEyDutqkcJtaDa4evqblp68eiL+ts8aXbNwwwYW363GqBd6S X-Gm-Message-State: AOJu0YzNHedtTVTcxPpbApEHUWg+WW2gr9HZWsfVf+RnQXMgccqFSqjP TtwIkcKpmflgPCQQbW8B/F0klkb8/8RTeE/uEgLyzOw20O6xo3RKplBiK9ux4Zw= X-Google-Smtp-Source: AGHT+IE4D+jAv58+0GgCMXisqeGuZCKz+lY2iWITk+8FkqB8ggzQmLPTu1JtIQBnacx4nGSjj3PhJw== X-Received: by 2002:a9d:5c07:0:b0:6f0:616f:f186 with SMTP id 46e09a7af769-6f9436b051emr3526455a34.29.1717612821607; Wed, 05 Jun 2024 11:40:21 -0700 (PDT) Received: from [192.168.0.142] (ip98-183-112-25.ok.ok.cox.net. [98.183.112.25]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-6f937b7acc0sm982915a34.80.2024.06.05.11.40.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 11:40:21 -0700 (PDT) Message-ID: <8450bd9a-c39d-4d24-8a42-f86041d16081@baylibre.com> Date: Wed, 5 Jun 2024 13:40:20 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 7/9] iio: adc: ad7173: refactor device info structs To: dumitru.ceclan@analog.com Cc: Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Dumitru Ceclan References: <20240603-ad4111-v5-0-9a9c54d9ac78@analog.com> <20240603-ad4111-v5-7-9a9c54d9ac78@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20240603-ad4111-v5-7-9a9c54d9ac78@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/3/24 11:23 AM, Dumitru Ceclan via B4 Relay wrote: > From: Dumitru Ceclan > > Drop array of device info structs and use individual structs for all; > drop models enum as no longer needed. This improves readability as the > structs are pointed directly. > > Signed-off-by: Dumitru Ceclan > --- ... > static const char *const ad7173_ref_sel_str[] = { > @@ -1191,32 +1185,25 @@ static int ad7173_probe(struct spi_device *spi) > } > > static const struct of_device_id ad7173_of_match[] = { > - { .compatible = "adi,ad7172-2", > - .data = &ad7173_device_info[ID_AD7172_2]}, > - { .compatible = "adi,ad7172-4", > - .data = &ad7173_device_info[ID_AD7172_4]}, > - { .compatible = "adi,ad7173-8", > - .data = &ad7173_device_info[ID_AD7173_8]}, > - { .compatible = "adi,ad7175-2", > - .data = &ad7173_device_info[ID_AD7175_2]}, > - { .compatible = "adi,ad7175-8", > - .data = &ad7173_device_info[ID_AD7175_8]}, > - { .compatible = "adi,ad7176-2", > - .data = &ad7173_device_info[ID_AD7176_2]}, > - { .compatible = "adi,ad7177-2", > - .data = &ad7173_device_info[ID_AD7177_2]}, > + { .compatible = "adi,ad7172-2", .data = &ad7172_2_device_info}, > + { .compatible = "adi,ad7172-4", .data = &ad7172_4_device_info}, > + { .compatible = "adi,ad7173-8", .data = &ad7173_8_device_info}, > + { .compatible = "adi,ad7175-2", .data = &ad7175_2_device_info}, > + { .compatible = "adi,ad7175-8", .data = &ad7175_8_device_info}, > + { .compatible = "adi,ad7176-2", .data = &ad7176_2_device_info}, > + { .compatible = "adi,ad7177-2", .data = &ad7177_2_device_info}, > { } > }; > MODULE_DEVICE_TABLE(of, ad7173_of_match); > > static const struct spi_device_id ad7173_id_table[] = { > - { "ad7172-2", (kernel_ulong_t)&ad7173_device_info[ID_AD7172_2]}, > - { "ad7172-4", (kernel_ulong_t)&ad7173_device_info[ID_AD7172_4]}, > - { "ad7173-8", (kernel_ulong_t)&ad7173_device_info[ID_AD7173_8]}, > - { "ad7175-2", (kernel_ulong_t)&ad7173_device_info[ID_AD7175_2]}, > - { "ad7175-8", (kernel_ulong_t)&ad7173_device_info[ID_AD7175_8]}, > - { "ad7176-2", (kernel_ulong_t)&ad7173_device_info[ID_AD7176_2]}, > - { "ad7177-2", (kernel_ulong_t)&ad7173_device_info[ID_AD7177_2]}, > + { "ad7172-2", (kernel_ulong_t)&ad7172_2_device_info}, > + { "ad7172-4", (kernel_ulong_t)&ad7172_4_device_info}, > + { "ad7173-8", (kernel_ulong_t)&ad7173_8_device_info}, > + { "ad7175-2", (kernel_ulong_t)&ad7175_2_device_info}, > + { "ad7175-8", (kernel_ulong_t)&ad7175_8_device_info}, > + { "ad7176-2", (kernel_ulong_t)&ad7176_2_device_info}, > + { "ad7177-2", (kernel_ulong_t)&ad7177_2_device_info}, nit: I would leave a space before the trailing } to match the space after the leading { here and in the _of_ table. > { } > }; > MODULE_DEVICE_TABLE(spi, ad7173_id_table); >