From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8568333F8B3 for ; Tue, 10 Feb 2026 10:29:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770719377; cv=none; b=Jqpfucmjj2UszB7vlYkkS26FUGlKFoaODDN7t8aZdr/EzjWxr6lsxCpkNXvHJDXfDssOoHwlJP6SjFBH06XFM96Kqx7ywDmvHCasUtcNqEKNkC6QIkyTP74E9BSo9rHhPJXrTCurO6BH8hO/HdDtStvIR1xOzSGjvAOQnVu6rIA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770719377; c=relaxed/simple; bh=H+CnyxWlK1/RWUajLsjk2IlpTD98xymU41dsOhZiuI8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wx3jI6u5VtreAwRsz3qj875815qpEJwPJeaMtaAkERIbELF7TNxqXqlpaWDII08LR9hUZdL6avc9pLDxfqqXRQ9M91SNbdBgXlzYlEGrewQOM0i8cJPmhk7Q5L426UPw2XHtISnmG7yU8MUVIBlPfUpwcA3OS0tXnOxpvP97Xjw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Mpt+so5F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=C9Ze7fQ0; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Mpt+so5F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="C9Ze7fQ0" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61A53o6B801178 for ; Tue, 10 Feb 2026 10:29:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UyShRs8H98+Iv0NfP9uKmh8Iz3yjnfMsJhckbhbT2SA=; b=Mpt+so5Frzez3FO7 ONKQbsYkrb2N2saBbg+punr1pmCLeuEcq+DE0iO9XIe7M577EDQ9RAq+PL9eywsi HhO55MimkqGwVp+0IKJyBeIrPyxzwPG7oQScBZ7afp46pjz8B2Clm7MkjwYmI+96 19da005he2DastLVR6PakgIVXFKoag1YwWKHdgCegEHEZe/2rQZ1oRRcUyiLLGiu n4NFKAAuRGrhwzV5K8VgXbSGm78dgp1pjmoPnDCQS3rjjWel7RQtiAYbUS86lEFh Wk6c2mDBz7E5mP+xaJH4SsGECVW1yUCN7b6Suul9TEhBuAvBzskiz+OZ69lQkTha XSQcSw== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c7x6u1273-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 10 Feb 2026 10:29:35 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-81f3fb8c8caso11228729b3a.1 for ; Tue, 10 Feb 2026 02:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770719375; x=1771324175; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UyShRs8H98+Iv0NfP9uKmh8Iz3yjnfMsJhckbhbT2SA=; b=C9Ze7fQ0BcxwIdnzP12mIjIluLFTAGkuff3m6qrOmnXCIWGJS6os8Osq3GTT1ld4uV jEeBh9YIlrE9oE7rp5uq3DzaspeGtWL+iKNKZmRn8XmOZ9n9FZ8SeCvs/VR7I+gDtSQu yTDL+dii7bncSA/xQ/uXef4mMkAiOmwkyGsk1GAxfWIGpDizdEKESxVmGz4Ep84QNRS8 /d9Cw/bEIwJfxE8dVKbqwyfSPxDZOtULz1dhFRHfBn3O4oGp827UYJyjDepNR0Os4H/p kJdv4U9BQL2+Ysf4Cx7yThTO81/BitcaY3yxU7x9c4KfRj1b9b5N9JejvTN45pIFbXtF MD/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770719375; x=1771324175; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UyShRs8H98+Iv0NfP9uKmh8Iz3yjnfMsJhckbhbT2SA=; b=TfgRlZ9PAkqE/nRqyAhjK7/QihtmIW0gHhNLfTfEE6Q6kklIhZ6f7V4rHyrtrJGeCQ PNkz09MMVaNJ2dyIcxmjEB1D7sL3Jq7JEDzkT6tmbIB/3eb6RhNSUKK5S3nHG04DF/RY KmaVnoAPmJqViJ1NhyFgvMoa4sJgbA3m/LUk/A2ZnsXE7OjGNN1+wRCwTuWvcPAMIq5w HL4h+2RUxyYp/E9XVwhGuJyXP7D0rv/ZM106dK2xSlD48W8VL9H3oTRP9S2Y4nQS+iNT 2/TuFTS/dyBvpLTuS3UgoYPl9pK7p5vBf1eL9ASIyjDlUbREEzEKdZrmR1UDlmf6z3aF s7Kg== X-Forwarded-Encrypted: i=1; AJvYcCU7ABFF5TAMu6mCaqy6NT/cCJ8wZaWsBcRcnLpZFZfniYNRKxbc7XFKjLTKZTwicGizrRJ3Ni41tXCzqhw=@vger.kernel.org X-Gm-Message-State: AOJu0YyqLUgc32eo0nversGIwqxeJOQSFA1PpdP3ZmjQjeGfQANUk2mu AdBqpeRejXC/k2lAnCbdxubvjIOyFkoZLwEYiZee6rBipxSL6sxaRMYs00i+1iboxHv/RNXHinl dBmeo2Gmk1SqWFOlJqctOQTFn0BS1hhutTQD9Irj+q1wH+qdtgZ4MyV7+E1fyw1RRVl0= X-Gm-Gg: AZuq6aJI9fuS1YORsPNCNINjwWK5sNEY6Ewm2ggfH8iqyv+hzgtYZRbhAASXorPV+XC tEdpGrTgoFdJcWOt5t2J2zRXxeRYTMy6r8OMW5mBqAjb2VoxY6cy8fZimnxCbkmkyny1aJYpl3p 0Wh879Iah6YuooxzpQ7WNusWf5/Mc2hZdIi568jJWU2xs18rc1LjqSHomFf9cVlEhteY8RANegh eHrgJq897ict/L0J63npv8ru93U1RereLpd6iHlCwy45+8X4nTqBGAbk70UJ0hG0RPFQPh3aemS noTPn55rLzQ2xRHATZqDgdv6mSLi53NMaQYxNYQaeGIlBRLpHrC7JWESN4yDSmg1k47Zbj04+Wd vXlPS9YYWwmvJApQgvdVMKLK0SDAE33Axqk5kXAjhlqlmLFGP7+6ADp5ZKQLktE1+ACK4Csb+Pb pKOw8A5gwJtCXkD64= X-Received: by 2002:a05:6a00:6ca1:b0:81e:a228:f0cb with SMTP id d2e1a72fcca58-824416f8ee0mr13630299b3a.36.1770719374678; Tue, 10 Feb 2026 02:29:34 -0800 (PST) X-Received: by 2002:a05:6a00:6ca1:b0:81e:a228:f0cb with SMTP id d2e1a72fcca58-824416f8ee0mr13630279b3a.36.1770719374213; Tue, 10 Feb 2026 02:29:34 -0800 (PST) Received: from [10.133.33.6] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8244169ddbasm12302656b3a.25.2026.02.10.02.29.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Feb 2026 02:29:33 -0800 (PST) Message-ID: <845165e6-4595-41de-8cff-d065e8f6b6be@oss.qualcomm.com> Date: Tue, 10 Feb 2026 18:29:29 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] phy: qcom: edp: Add eDP phy mode switch support To: Konrad Dybcio , Vinod Koul , Neil Armstrong Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260205-edp_phy-v1-0-231882bbf3f1@oss.qualcomm.com> <20260205-edp_phy-v1-3-231882bbf3f1@oss.qualcomm.com> Content-Language: en-US From: Yongxing Mou In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: WFPez8DOGB4dPzblRYrgFtxw-pN0iChb X-Proofpoint-ORIG-GUID: WFPez8DOGB4dPzblRYrgFtxw-pN0iChb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEwMDA4NSBTYWx0ZWRfX7pMzn+008NTq TrEiGJJyJ3rplHVyfXjZ689A4Jde/38QrZFMFHp+ZKlEvacO0SqP0OMJA8zKo4SSo6H1YdtAeg9 A1JTbZhUG62yWT3+pvkK7NiBDh10WDXP1YI3te+boforCozMZ8VRBGOHf9I+GoC/LJgZCGnGPAo SDxRYovMtKLah6ArAjI9qnI1wOqdLJK5Lgd+CozsH6ZpFLSQHLp1shoiNMvVYGVX3GlY0aS5TI1 mHmWQ4NB8iDIMGl7+XDAyIk30NcM5biF7TnVNu4DvbDOBPWjgFeY+36r6BrC5KD8MlVNyJNSGW5 rwlK7f0Eay9xEGqwUp25k+WxYWYltxxzudRe9vey2o4up46+Jgu3ZQFfTmZPqJOSpTLuW9wP5xn rGCF7/5o7x8cwmBOy9N3lrY2qxwKulKTKuaFBxDlWM/J1GwGlP073iZx3EwGO5gV3hAvdyqAPoT +NvafuwJ/U2bGYZ8vcg== X-Authority-Analysis: v=2.4 cv=YfmwJgRf c=1 sm=1 tr=0 ts=698b088f cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=z0i2z7H4iVerI-YqTMIA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-10_01,2026-02-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602100085 On 2/6/2026 7:02 PM, Konrad Dybcio wrote: > On 2/5/26 10:20 AM, Yongxing Mou wrote: >> Add DP/eDP switch support by splitting the PHY swing/pre-emphasis tables >> into separate DP and eDP configurations. This allows the driver to select >> the correct table based on the is_edp flag. >> >> Add a dedicated table for the SC7280/glymur platforms, as they are not >> compatible with the others. >> >> Signed-off-by: Yongxing Mou >> --- > > [...] > >> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = { >> + { 0x0b, 0x11, 0x16, 0x1b }, >> + { 0x0b, 0x19, 0x1f, 0xff }, >> + { 0x18, 0x1f, 0xff, 0xff }, >> + { 0x1f, 0xff, 0xff, 0xff } >> +}; >> + >> +static const u8 edp_pre_emp_hbr2_hbr3_v3[4][4] = { >> + { 0x0c, 0x15, 0x19, 0x1e }, >> + { 0x09, 0x14, 0x19, 0xff }, >> + { 0x0f, 0x14, 0xff, 0xff }, >> + { 0x0d, 0xff, 0xff, 0xff } >> +}; > > This is not quite in line with docs for kodiak. Now, if you have > better/newer sequences than the HPG, I'm not objecting, but please > cross-check > > the rest of this patch I think looks fine > > Konrad Thanks for point that.. >> +static const u8 edp_swing_hbr2_hbr3_v3[4][4] = { >> + { 0x0b, 0x11, 0x16, 0x1b }, here should be { 0x06, 0x11, 0x16, 0x1b }, arr[0][1]: 0x0b->0x06 does this looks fine? will check tables again..