From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Bartosz Golaszewski" <bartosz.golaszewski@linaro.org>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
Linux-Arch <linux-arch@vger.kernel.org>,
linux-kernel@vger.kernel.org
Cc: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Subject: Re: [PATCH v1 5/5] gpio: Clean up headers
Date: Thu, 26 Jan 2023 09:42:32 +0100 [thread overview]
Message-ID: <8454db45-a967-4542-8f16-538043542e14@app.fastmail.com> (raw)
In-Reply-To: <20230125201020.10948-6-andriy.shevchenko@linux.intel.com>
On Wed, Jan 25, 2023, at 21:10, Andy Shevchenko wrote:
> There is a few things done:
> - include only the headers we are direct user of
> - when pointer is in use, provide a forward declaration
> - add missing headers
> - group generic headers and subsystem headers
> - sort each group alphabetically
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/asm-generic/gpio.h | 8 --------
> include/linux/gpio.h | 9 +++------
> include/linux/gpio/consumer.h | 14 ++++++++++----
> include/linux/gpio/driver.h | 34 ++++++++++++++++++++++++----------
> 4 files changed, 37 insertions(+), 28 deletions(-)
This change looks fine, but it conflicts with a slightly
broader cleanup that I meant to have already submitted,
folding include/asm-generic/gpio.h into linux/gpio.h and
removing the driver-side interface from that.
Let me try to dig out my series again, we should be able to
either use my version, or merge parts of this patch into it.
Arnd
next prev parent reply other threads:[~2023-01-26 8:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 20:10 [PATCH v1 0/5] gpio: First attempt to clean " Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 1/5] gpiolib: fix linker errors when GPIOLIB is disabled Andy Shevchenko
2023-01-26 8:14 ` Christophe Leroy
2023-01-26 8:40 ` Arnd Bergmann
2023-01-26 10:17 ` Andy Shevchenko
2023-01-26 10:27 ` Arnd Bergmann
2023-01-26 12:14 ` Andy Shevchenko
2023-01-26 10:19 ` Andy Shevchenko
2023-01-26 12:44 ` Christophe Leroy
2023-01-26 12:56 ` Arnd Bergmann
2023-01-26 13:29 ` Andy Shevchenko
2023-01-26 13:41 ` Pierluigi Passaro
2023-01-26 14:10 ` Arnd Bergmann
2023-01-25 20:10 ` [PATCH v1 2/5] gpio: Drop unused forward declaration from driver.h Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 3/5] gpio: Deduplicate forward declarations in consumer.h Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 4/5] gpio: Group " Andy Shevchenko
2023-01-25 20:10 ` [PATCH v1 5/5] gpio: Clean up headers Andy Shevchenko
2023-01-26 8:42 ` Arnd Bergmann [this message]
2023-01-26 10:16 ` Andy Shevchenko
2023-01-26 13:08 ` Arnd Bergmann
2023-01-26 10:22 ` Linus Walleij
2023-01-26 12:16 ` Andy Shevchenko
2023-01-26 12:29 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8454db45-a967-4542-8f16-538043542e14@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=brgl@bgdev.pl \
--cc=christophe.leroy@csgroup.eu \
--cc=dmitry.torokhov@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®