From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Junyi Zhao <junyi.zhao@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Tue, 10 Nov 2026 15:49:52 +0800 [thread overview]
Message-ID: <84565a50-0c52-45ff-b43a-3d30902690df@amlogic.com> (raw)
In-Reply-To: <01d3c9aa-ad7c-491f-b99b-aee731c1ad1e@web.de>
Hi Markus,
Thanks for your review.
On 2026/11/7 03:33, Markus Elfring wrote:
> …
>> +++ b/drivers/i2c/busses/i2c-amlogic-a9.c
>> @@ -0,0 +1,432 @@
> …
>> +static irqreturn_t aml_i2c_irq(int irqno, void *dev_id)
>> +{
> …
>> + spin_lock(&i2c->lock);
>> +
>> + irq_state = readl(i2c->regs + REG_CFG_IRQ_STATE);
>> + if (i2c->state == A9_STATE_IDLE) {
>> + dev_warn(i2c->dev, "i2c irq triggered abnormally, irq_state:0x%x,irq_en:0x%x\n",
>> + irq_state, readl(i2c->regs + REG_CFG_IRQ_ENABLE));
>> + clear_irq_status(i2c, IRQ_ALL_MASK);
>> + spin_unlock(&i2c->lock);
>> + return IRQ_HANDLED;
>> + }
> …
>
> Please avoid duplicate source code a bit more for such a function implementation.
>
Will do.
> Regards,
> Markus
prev parent reply other threads:[~2026-11-10 7:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 10:00 [PATCH v7 0/2] i2c: Add driver support Amlogic A9 I2C Xianwei Zhao via B4 Relay
2026-11-04 10:00 ` [PATCH v7 1/2] dt-bindings: i2c: add Amlogic A9 I2C controller Xianwei Zhao via B4 Relay
2026-11-04 10:01 ` [PATCH v7 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Xianwei Zhao via B4 Relay
2026-11-06 19:33 ` Markus Elfring
2026-11-10 7:49 ` Xianwei Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84565a50-0c52-45ff-b43a-3d30902690df@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=Markus.Elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junyi.zhao@amlogic.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®