From: Roi Dayan <roid@nvidia.com>
To: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@nvidia.com>,
gregkh <gregkh@linuxfoundation.org>
Cc: Leon Romanovsky <leonro@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>,
Jason Wang <jasowang@redhat.com>, <linux-rdma@vger.kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>, <netdev@vger.kernel.org>,
Parav Pandit <parav@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>,
<virtualization@lists.linux-foundation.org>,
<alsa-devel@alsa-project.org>, <tiwai@suse.de>,
<broonie@kernel.org>, "David S . Miller" <davem@davemloft.net>,
<ranjani.sridharan@linux.intel.com>,
<pierre-louis.bossart@linux.intel.com>, <fred.oh@linux.intel.com>,
<shiraz.saleem@intel.com>, <dan.j.williams@intel.com>,
<kiran.patil@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH mlx5-next v1 11/11] RDMA/mlx5: Remove IB representors dead code
Date: Tue, 3 Nov 2020 09:10:48 +0200 [thread overview]
Message-ID: <845b26c8-4dfa-5ef2-67a8-1ae6f556fd71@nvidia.com> (raw)
In-Reply-To: <20201101201542.2027568-12-leon@kernel.org>
On 2020-11-01 10:15 PM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> Delete dead code.
>
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> ---
> drivers/infiniband/hw/mlx5/ib_rep.c | 31 +++++++----------------------
> drivers/infiniband/hw/mlx5/ib_rep.h | 31 -----------------------------
> 2 files changed, 7 insertions(+), 55 deletions(-)
>
> diff --git a/drivers/infiniband/hw/mlx5/ib_rep.c b/drivers/infiniband/hw/mlx5/ib_rep.c
> index 9810bdd7f3bc..a1a9450ed92c 100644
> --- a/drivers/infiniband/hw/mlx5/ib_rep.c
> +++ b/drivers/infiniband/hw/mlx5/ib_rep.c
> @@ -13,7 +13,7 @@ mlx5_ib_set_vport_rep(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
> struct mlx5_ib_dev *ibdev;
> int vport_index;
>
> - ibdev = mlx5_ib_get_uplink_ibdev(dev->priv.eswitch);
> + ibdev = mlx5_eswitch_uplink_get_proto_dev(dev->priv.eswitch, REP_IB);
> vport_index = rep->vport_index;
>
> ibdev->port[vport_index].rep = rep;
> @@ -74,6 +74,11 @@ mlx5_ib_vport_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
> return ret;
> }
>
> +static void *mlx5_ib_rep_to_dev(struct mlx5_eswitch_rep *rep)
> +{
> + return rep->rep_data[REP_IB].priv;
> +}
> +
> static void
> mlx5_ib_vport_rep_unload(struct mlx5_eswitch_rep *rep)
> {
> @@ -91,40 +96,18 @@ mlx5_ib_vport_rep_unload(struct mlx5_eswitch_rep *rep)
> __mlx5_ib_remove(dev, dev->profile, MLX5_IB_STAGE_MAX);
> }
>
> -static void *mlx5_ib_vport_get_proto_dev(struct mlx5_eswitch_rep *rep)
> -{
> - return mlx5_ib_rep_to_dev(rep);
> -}
> -
> static const struct mlx5_eswitch_rep_ops rep_ops = {
> .load = mlx5_ib_vport_rep_load,
> .unload = mlx5_ib_vport_rep_unload,
> - .get_proto_dev = mlx5_ib_vport_get_proto_dev,
> + .get_proto_dev = mlx5_ib_rep_to_dev,
> };
>
> -struct mlx5_ib_dev *mlx5_ib_get_rep_ibdev(struct mlx5_eswitch *esw,
> - u16 vport_num)
> -{
> - return mlx5_eswitch_get_proto_dev(esw, vport_num, REP_IB);
> -}
> -
> struct net_device *mlx5_ib_get_rep_netdev(struct mlx5_eswitch *esw,
> u16 vport_num)
> {
> return mlx5_eswitch_get_proto_dev(esw, vport_num, REP_ETH);
> }
>
> -struct mlx5_ib_dev *mlx5_ib_get_uplink_ibdev(struct mlx5_eswitch *esw)
> -{
> - return mlx5_eswitch_uplink_get_proto_dev(esw, REP_IB);
> -}
> -
> -struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct mlx5_eswitch *esw,
> - u16 vport_num)
> -{
> - return mlx5_eswitch_vport_rep(esw, vport_num);
> -}
> -
> struct mlx5_flow_handle *create_flow_rule_vport_sq(struct mlx5_ib_dev *dev,
> struct mlx5_ib_sq *sq,
> u16 port)
> diff --git a/drivers/infiniband/hw/mlx5/ib_rep.h b/drivers/infiniband/hw/mlx5/ib_rep.h
> index 93f562735e89..ce1dcb105dbd 100644
> --- a/drivers/infiniband/hw/mlx5/ib_rep.h
> +++ b/drivers/infiniband/hw/mlx5/ib_rep.h
> @@ -12,11 +12,6 @@
> extern const struct mlx5_ib_profile raw_eth_profile;
>
> #ifdef CONFIG_MLX5_ESWITCH
> -struct mlx5_ib_dev *mlx5_ib_get_rep_ibdev(struct mlx5_eswitch *esw,
> - u16 vport_num);
> -struct mlx5_ib_dev *mlx5_ib_get_uplink_ibdev(struct mlx5_eswitch *esw);
> -struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct mlx5_eswitch *esw,
> - u16 vport_num);
> int mlx5r_rep_init(void);
> void mlx5r_rep_cleanup(void);
> struct mlx5_flow_handle *create_flow_rule_vport_sq(struct mlx5_ib_dev *dev,
> @@ -25,26 +20,6 @@ struct mlx5_flow_handle *create_flow_rule_vport_sq(struct mlx5_ib_dev *dev,
> struct net_device *mlx5_ib_get_rep_netdev(struct mlx5_eswitch *esw,
> u16 vport_num);
> #else /* CONFIG_MLX5_ESWITCH */
> -static inline
> -struct mlx5_ib_dev *mlx5_ib_get_rep_ibdev(struct mlx5_eswitch *esw,
> - u16 vport_num)
> -{
> - return NULL;
> -}
> -
> -static inline
> -struct mlx5_ib_dev *mlx5_ib_get_uplink_ibdev(struct mlx5_eswitch *esw)
> -{
> - return NULL;
> -}
> -
> -static inline
> -struct mlx5_eswitch_rep *mlx5_ib_vport_rep(struct mlx5_eswitch *esw,
> - u16 vport_num)
> -{
> - return NULL;
> -}
> -
> static inline int mlx5r_rep_init(void) { return 0; }
> static inline void mlx5r_rep_cleanup(void) {}
> static inline
> @@ -62,10 +37,4 @@ struct net_device *mlx5_ib_get_rep_netdev(struct mlx5_eswitch *esw,
> return NULL;
> }
> #endif
> -
> -static inline
> -struct mlx5_ib_dev *mlx5_ib_rep_to_dev(struct mlx5_eswitch_rep *rep)
> -{
> - return rep->rep_data[REP_IB].priv;
> -}
> #endif /* __MLX5_IB_REP_H__ */
> --
> 2.28.0
>
Reviewed-by: Roi Dayan <roid@nvidia.com>
prev parent reply other threads:[~2020-11-03 7:11 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 20:15 [PATCH mlx5-next v1 00/11] Convert mlx5 to use auxiliary bus Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 01/11] net/mlx5: Don't skip vport check Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 02/11] net/mlx5: Properly convey driver version to firmware Leon Romanovsky
2020-11-02 14:47 ` Roi Dayan
2020-11-01 20:15 ` [PATCH mlx5-next v1 03/11] net/mlx5_core: Clean driver version and name Leon Romanovsky
2020-11-02 5:07 ` Parav Pandit
2020-11-02 5:56 ` Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 04/11] vdpa/mlx5: Make hardware definitions visible to all mlx5 devices Leon Romanovsky
2020-11-05 20:31 ` Saeed Mahameed
2020-11-05 20:36 ` Jason Gunthorpe
2020-11-06 7:05 ` Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 05/11] net/mlx5: Register mlx5 devices to auxiliary virtual bus Leon Romanovsky
2020-11-05 20:59 ` Saeed Mahameed
2020-11-05 21:09 ` Jason Gunthorpe
2020-11-06 6:56 ` Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 06/11] vdpa/mlx5: Connect mlx5_vdpa to auxiliary bus Leon Romanovsky
2020-11-03 15:45 ` Jason Gunthorpe
2020-11-04 23:21 ` Dan Williams
2020-11-05 7:33 ` gregkh
2020-11-05 7:49 ` Dan Williams
2020-11-05 16:47 ` Jason Gunthorpe
2020-11-05 16:57 ` gregkh
2020-11-01 20:15 ` [PATCH mlx5-next v1 07/11] net/mlx5e: Connect ethernet part " Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 08/11] RDMA/mlx5: Convert mlx5_ib to use " Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 09/11] net/mlx5: Delete custom device management logic Leon Romanovsky
2020-11-01 20:15 ` [PATCH mlx5-next v1 10/11] net/mlx5: Simplify eswitch mode check Leon Romanovsky
2020-11-02 14:54 ` Roi Dayan
2020-11-01 20:15 ` [PATCH mlx5-next v1 11/11] RDMA/mlx5: Remove IB representors dead code Leon Romanovsky
2020-11-03 7:10 ` Roi Dayan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845b26c8-4dfa-5ef2-67a8-1ae6f556fd71@nvidia.com \
--to=roid@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=fred.oh@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=jgg@nvidia.com \
--cc=kiran.patil@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=saeedm@nvidia.com \
--cc=shiraz.saleem@intel.com \
--cc=tiwai@suse.de \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome