From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96CE546AA89 for ; Tue, 4 Aug 2026 11:00:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841248; cv=none; b=GmVIC7mik+zgZIVf7RvFY1PPZdqMnGOdRbd3yKCplz6EKqbW1lzK9Qv/xkblMSxAmunP8doR8S6mxsgyokBs50vuoA5xSPoDl3FNViSOPQv2ZibPIvPiTy5abtN+MHKtZMJmb3KUSFZ3/DUXynNZm8LQr3GAvOuH571abiPHahg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785841248; c=relaxed/simple; bh=j4jB2CuktZt9BmmOQZAWYh7FwI+2H94W1au8O2AKvC8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nsxR9F6SrPIgQNpOpnivQPa1GvP6MMx6R0Mh5mcH6pfr0lVUwoscxKACcAe5nY8THq0VCOnFZG+8R/JNx+bzIBWhmlx3a1HP4+1tc7P/mlxV0HoYR5idcz8SOcyhPaK412Kng7569nWZWSoja342V9U0/S6EfEf/q1Siu7hzyGg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XYFqXQGa; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IU/nUTo4; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XYFqXQGa"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IU/nUTo4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785841242; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cJtreoVIWq8iraOxCVehJ8SXF71GD0ffstjU1unaYZE=; b=XYFqXQGaf/Qb2krDoH/U63gg/MD5FWbuCbx3be5+ytrv7UMehF3gq0WMusNEGhKboYT5ar lFICu6bgdBux5h69P1Tvp0i48BZJKl8snqbTRm7KfA4Dep2xnDe5T4hM39JGeEZ5vhmiNa VM23e0tWl3YB/5YIbMHc3kZGDTiTSE8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-265-RJFuW8_EP5Kf_zuWPNak9g-1; Tue, 04 Aug 2026 07:00:31 -0400 X-MC-Unique: RJFuW8_EP5Kf_zuWPNak9g-1 X-Mimecast-MFC-AGG-ID: RJFuW8_EP5Kf_zuWPNak9g_1785841230 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49545071724so32300775e9.0 for ; Tue, 04 Aug 2026 04:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785841230; x=1786446030; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cJtreoVIWq8iraOxCVehJ8SXF71GD0ffstjU1unaYZE=; b=IU/nUTo4wmBc2jPYJ/XZq3yIPA/ur9C36kSVLl6vpcNoO5146GaVJF9TICUoLDT1ev BmvmKa/GdcmCfB7rRdmhxe0Ig6FiqiOu6L2Nxzlv0k+KlyOh67kGMUZfEEi0eayzxJB0 R37QNyyYpDDZiCveL7mXNoLWYeZyHuXP7vSbjiVCUcYJE7TEGr7Fm3SbmTp9r/brWqDY 6Ai3Xu7IeIgIZ9Mn+p8uTr2XFyeiMngzqCB8b7ur6E3E59VRLMk8m/M+tGoXI4lJCLLN x7+cxDJBwaUBOCpxntp2e6IYK+WDc9R+BWa4iSkTDJh+VKoXhMRh4GoblpHEylsADryC wBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785841230; x=1786446030; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cJtreoVIWq8iraOxCVehJ8SXF71GD0ffstjU1unaYZE=; b=ArCXrcGKj8KSi4OdpyFzf1CQvEpWJr5lrzXnVwVb/3xrEkbrsTfQyXYdk6/tz8JXlD /NTY+RyrT6GFrqg7xwzRQo6GcWefUSu0LWoyrMw6vDI0ANZ/EqzK37Ag4HPJpDQU+5aU uM3ILY4uSUpOTwZU7LfYp5E7YR8xw55hF428OJ4ha63zUWvGLKAScn5T3+d5S3F3aIub KJdGrvNiTxUKJIir1OYecOxBtnA6KjCCeimoI0C4GLJuTyxf6TvzeBWXQIehJ9/slOI8 iZGxSxG/kAIWyLs4mz//MEDRxbE6JsmJscSOjoBW3PSQkwdzf8wotHzH7PG166Nydx8A +qXg== X-Forwarded-Encrypted: i=1; AHgh+RrvWGkOnsEuFaZg/q4+Na3uF/Z5wAgElt45uYT+6TdlRUfkTdrkzLo5u/H5mHohbdbMhAxeJWcr6KihLYs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw0mrJ1dMx8V1xgfUdWuLghBgP1ZQKJWv9AAo8BabVO3RFyqkpG NHHdu5hDp0pWjZzfe8iozCaHCq5HEgCv/VCKtLrPmfAwSzh76RhNKwZA+LIQOoBFB5E4jlKtBBm Aup9xk1SKnzAmEmArMLWJmhKNGsmvPVuE/w9S1NSmnWLmvTsNfRi5Yu46HSxrgMMTig== X-Gm-Gg: AR+sD12QntSoQdUx1z1AQbkc69pL8ZDBnQHw+NX5nRVxdHRZiSZ/a1lN9KSh+4D7+3g p/vt1PsGMfdlVtG6bo8LYpyzyM0iGi61W+kgBHLdx94+GbWLOqo6veRUKGX3OvQgry3xDg05ouV 7Kc35Sei2yTPCPSzofZO/QzmWoSTZ6gd2nBtO/nY2CAIjlf3bYttlb2gSXEBlLIiVC3/Pe+v+4y BxYT9O7emE6zCjsecW9QJtzhoif8gsggZ2w4jXiHPb0eQN0mhIxba3u8FgFr3HVye2rLhNdNdVW FU0rgoICOOpsT5DlRVTVTWaWJbhjyz9cpVhVUIS1BSQZ+InbCVPe+X/8LTgf7J/RlN3e1Fio9rS s/EYgjnGEIOB0ekiFdrcpGMbQbTLZ+6kWw5/ZjFdPbD+nD6GHjab2vDLogGZmEs7BMOppqMQEvj E= X-Received: by 2002:a05:600c:e48a:b0:496:ca1f:a428 with SMTP id 5b1f17b1804b1-4980c695d6emr213046745e9.19.1785841228803; Tue, 04 Aug 2026 04:00:28 -0700 (PDT) X-Received: by 2002:a05:600c:e48a:b0:496:ca1f:a428 with SMTP id 5b1f17b1804b1-4980c695d6emr213045745e9.19.1785841228325; Tue, 04 Aug 2026 04:00:28 -0700 (PDT) Received: from [192.168.188.103] (ip239-44-231-195.pool-bba.aruba.it. [195.231.44.239]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41d0064sm41447011f8f.5.2026.08.04.04.00.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 04:00:27 -0700 (PDT) Message-ID: <845bb9f6-73e9-4301-a5ee-94e7f7aacd88@redhat.com> Date: Tue, 4 Aug 2026 13:00:26 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv3 net-next] net: dsa: b53: srab: propagate errors from init helpers To: Rosen Penev , netdev@vger.kernel.org Cc: Florian Fainelli , Jonas Gorski , Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , open list References: <20260729202953.704662-1-rosenp@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260729202953.704662-1-rosenp@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/29/26 10:29 PM, Rosen Penev wrote: > -static void b53_srab_mux_init(struct platform_device *pdev) > +static int b53_srab_mux_init(struct platform_device *pdev) > { > struct b53_device *dev = platform_get_drvdata(pdev); > struct b53_srab_priv *priv = dev->priv; > struct b53_srab_port_priv *p; > + void __iomem *mux_config; > unsigned int port; > u32 reg, off = 0; > int ret; > > - if (dev->pdata && dev->pdata->chip_id != BCM58XX_DEVICE_ID) > - return; > + if (!dev->pdata || dev->pdata->chip_id != BCM58XX_DEVICE_ID) > + return 0; > > - priv->mux_config = devm_platform_ioremap_resource(pdev, 1); > - if (IS_ERR(priv->mux_config)) > - return; > + mux_config = devm_platform_ioremap_resource(pdev, 1); > + if (IS_ERR(mux_config)) > + return PTR_ERR(mux_config); Sashiko noted this strict checking may cause regression on previously working setup: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260729202953.704662-1-rosenp%40gmail.com /P