From: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
To: Abel Vesa <abel.vesa@linaro.org>, Andy Gross <agross@kernel.org>,
"Bjorn Andersson" <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: <linux-arm-msm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Avinash Philip <quic_avinashp@quicinc.com>,
Umnathi Chalicheemala <quic_uchalich@quicinc.com>
Subject: Re: [PATCH] soc: qcom: llcc: Fix LLCC_TRP_ATTR2_CFGn offset
Date: Wed, 11 Oct 2023 23:36:24 -0700 [thread overview]
Message-ID: <845e2747-535e-80e0-342b-e5343bd620aa@quicinc.com> (raw)
In-Reply-To: <20231012061127.95637-1-abel.vesa@linaro.org>
On 10/11/2023 11:11 PM, Abel Vesa wrote:
> According to documentation, it has increments of 4, not 8.
>
> Fixes: c72ca343f911 ("soc: qcom: llcc: Add v4.1 HW version support")
> Reported-by: Umnathi Chalicheemala <quic_uchalich@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
Thanks Abel.
Reviewed-by: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
> ---
> drivers/soc/qcom/llcc-qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c
> index 674abd0d6700..fb4085b7cb19 100644
> --- a/drivers/soc/qcom/llcc-qcom.c
> +++ b/drivers/soc/qcom/llcc-qcom.c
> @@ -47,7 +47,7 @@
> #define LLCC_TRP_STATUSn(n) (4 + n * SZ_4K)
> #define LLCC_TRP_ATTR0_CFGn(n) (0x21000 + SZ_8 * n)
> #define LLCC_TRP_ATTR1_CFGn(n) (0x21004 + SZ_8 * n)
> -#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_8 * n)
> +#define LLCC_TRP_ATTR2_CFGn(n) (0x21100 + SZ_4 * n)
>
> #define LLCC_TRP_SCID_DIS_CAP_ALLOC 0x21f00
> #define LLCC_TRP_PCB_ACT 0x21f04
next prev parent reply other threads:[~2023-10-12 6:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-12 6:11 Abel Vesa
2023-10-12 6:36 ` Satya Durga Srinivasu Prabhala [this message]
2023-10-12 8:23 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845e2747-535e-80e0-342b-e5343bd620aa@quicinc.com \
--to=quic_satyap@quicinc.com \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_avinashp@quicinc.com \
--cc=quic_uchalich@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®