From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: trix@redhat.com, balbi@kernel.org, gregkh@linuxfoundation.org,
mathias.nyman@intel.com, johan@kernel.org,
stern@rowland.harvard.edu, gustavoars@kernel.org,
viro@zeniv.linux.org.uk, lee.jones@linaro.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
usb-storage@lists.one-eyed-alien.net
Subject: Re: [PATCH] usb: remove unneeded break
Date: Mon, 26 Oct 2020 16:23:47 +0200 [thread overview]
Message-ID: <845e43b3-1c53-3eed-b540-4efa109f33a9@linux.intel.com> (raw)
In-Reply-To: <20201019150202.19713-1-trix@redhat.com>
On 19.10.2020 18.02, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
>
> A break is not needed if it is preceded by a return or goto
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/gadget/function/f_hid.c | 9 ---------
> drivers/usb/host/xhci-mem.c | 1 -
> drivers/usb/misc/iowarrior.c | 3 ---
> drivers/usb/serial/iuu_phoenix.c | 2 --
> drivers/usb/storage/freecom.c | 1 -
> 5 files changed, 16 deletions(-)
Would probably be better to split this into several patches.
The xhci change looks good (as a separate patch)
-Mathias
prev parent reply other threads:[~2020-10-26 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 15:02 trix
2020-10-26 14:23 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=845e43b3-1c53-3eed-b540-4efa109f33a9@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavoars@kernel.org \
--cc=johan@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=trix@redhat.com \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome