From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752799AbdJ3SXV (ORCPT ); Mon, 30 Oct 2017 14:23:21 -0400 Received: from mout.gmx.net ([212.227.15.15]:52601 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751691AbdJ3SXU (ORCPT ); Mon, 30 Oct 2017 14:23:20 -0400 Subject: Re: [PATCH] net: ethernet: slicoss: remove redundant initialization of idx To: Jakub Kicinski , Colin King Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171029133809.6831-1-colin.king@canonical.com> <20171030110449.3aea9670@cakuba.netronome.com> From: Lino Sanfilippo Message-ID: <84600781-e88e-4d1f-5b01-7cd46b53d4ef@gmx.de> Date: Mon, 30 Oct 2017 19:23:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171030110449.3aea9670@cakuba.netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vvhBoIriwD/xV97+bpkRsc6z7bXv/UOYidlXxzZLavScQz0ESPs qoXQQDLqmtKi96LbOpufGfS40lsuScJCtSdkNcxhfMGNN6UZ0wTQzV+ijgDwDrzh4om1knx BHJ+1MM+uAB6sGG1/HKdZJvrKo2aoMH1dBENAEj1W/EaqCaXn8PpIQ4U9QI5GovA/KcQWzm LEMrc3hS/y2je3gLhwPdQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:yJ8e4gr5Rw8=:ME6xctyFdQVrJWpJETdhfv 0z6+8KPViQosJE/5H/gaaxKlKwLR4/hdvE0BU5FWolRAWEn3hghm8hADlh7r/Q5jJhlwgl6cJ jER8vneh6rBQiv96mllbU3UlHVJ9+FbIWnaDYZRnYfK1xfaGiS34MEXjTjrA7Y+ZomJ8NZgmo vYJbWldY3nD5z93cG2uBdbC+B5Gal2MEyaKTXP+egIhCT50pk4fTXcobFeRv1H3NcjpSusq6u q9TWXeVDn6Crs2Zx7Aml9QokkM/jU6QCD2UESAdUMxDjE0OfGcn1oSYeLZQEK2cIhnaqtwPEs 3OMWpWdzJqgo/CNLgc3MDXFMzsZS8oXLq4FE9cP8Al4kKJXlbNzAuXbNRGfjxPbnobp8zYYNK PmwzJz94gntL0645qXlu5Rj3Lw9WyL3a6TvLueLRuLJejblAhPHolNsV97IpdovH7nnRGG90d 03KWp+zeDcNtUxebRYxvi7JME6Avilq+85zDbmU0nVneeEHZHDuubc1S7ZLsYV4jGMJoMROHk Z6DW1mvTDCisOQbIJpOp5kZjcqyVpmsDuAENmJ9xHd4km97ztUUMzBqyhy9qIyCM52PfHij1Q PAJt96ppMhWMQc1wQHwPERsWd6UoxKOJKcPvyZ/7ghFV1ydZL0cGw/ml80cE18i//kddIrgwN qLByXvKmyg8v6ldtr/05kdDyFT1ineMWrIjUPobMlRcI+dZHDi+PqrLCp5SgYs5gQV4SW1PWT L6MxtFPZ6QX6SCU0zJu7ZyWoCkye7rkP0yxSBYF34BfLl1VK60+4F2rw7N19kkprpDTS0l/bx E7+0od7JanSMgHTJlb86psKEQyxg2Ge5rn+47/xDv6eGWOb4sY= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.10.2017 19:04, Jakub Kicinski wrote: > On Sun, 29 Oct 2017 13:38:09 +0000, Colin King wrote: >> From: Colin Ian King >> >> Variable idx is being initialized and later on over-written by >> a new value in a do-loop without the initial value ever being >> read. Hence the initializion is redundant and can be removed. >> Cleans up clang warning: >> >> drivers/net/ethernet/alacritech/slicoss.c:358:15: warning: Value >> stored to 'idx' during its initialization is never read >> >> Signed-off-by: Colin Ian King >> --- >> drivers/net/ethernet/alacritech/slicoss.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c >> index 15a8096c60df..ac8004186fa8 100644 >> --- a/drivers/net/ethernet/alacritech/slicoss.c >> +++ b/drivers/net/ethernet/alacritech/slicoss.c >> @@ -355,7 +355,7 @@ static void slic_xmit_complete(struct slic_device *sdev) >> { >> struct slic_tx_queue *txq = &sdev->txq; >> struct net_device *dev = sdev->netdev; >> - unsigned int idx = txq->done_idx; >> + unsigned int idx; >> struct slic_tx_buffer *buff; >> unsigned int frames = 0; >> unsigned int bytes = 0; > > You should probably reorder the variables now so they stay longest to > shortest. > I agree. While the change itself is ok, it would be nice if we could keep the order of the variables by length. Regards, Lino