From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84E6C15C14A for ; Mon, 19 Aug 2024 09:34:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724060049; cv=none; b=uLaRBdOzPSoZhjIoBMXL1MNA+A4R8sjaC3djzJZh10RJyhU5fNRoQCtgPjYess9OcuggdZ/urNdrSgj7nLSuzNsRzZFDca67budzZz8a9sATeZd6pGneN0CRmwZhHybnpWyp1dtUDNd5Vzcyy4JRqYCpUg3Vgp8GWNP9yYHEEEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724060049; c=relaxed/simple; bh=SpUtl05BeCGOM/1Lkbq/9mp5CcEOrFAlx+xbPz3AkRQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HBlJOi0XpdGwYWiq2BR6JZ1bio6hLpVuFxg50bNUxTe/rlFISxs3fXvN52VvMCmllrLKg4nosAD3uAKz1wHznisgzSmLneDYv+MKVQnD2ZRpU2cWJ3zgQWz9VmhfMlotVHGrchQRyrxFNez16c3k64k/TzzvNcS6WnDCPuOTsZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=eqrUq6v9; arc=none smtp.client-ip=209.85.215.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="eqrUq6v9" Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-7c2595f5c35so421700a12.1 for ; Mon, 19 Aug 2024 02:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1724060047; x=1724664847; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lL9HyxhiOHw1ksx03a4JZenwbuQJWQ+/lpC+EZL1Mdo=; b=eqrUq6v9yImy+6bOdnGikaEulfNDYq6iwh+p3MEZKEMvGDdTwsK/2NNOoHbhtOq8mG 0xBAi9KwMUxaFfohkqg+u2JOC/jOi7+5G0YoL4pUENiCWH66shgAQdFvO1pcRbGCT0Ok +fjDYdUu6GD39byrD/gu4dJgDq+d4lVhxsnnA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724060047; x=1724664847; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lL9HyxhiOHw1ksx03a4JZenwbuQJWQ+/lpC+EZL1Mdo=; b=JJnPelsyGVpH6yW8G/og0/dgCOgr60vwW3TQESdm6Aik2wb0iURuZEjqwjHs7w2pWS cCDh4pFUkdYkWi4UQ5p6Gu8XxmvP0OYPXkxqG0UozzpimqXo0GDTq25MEZYZCgtMZ1a/ ODoaO3G3N5L0yHJBJWJrLAnKxiPzI2KlhXIlzqh8UC13uB0tBglRJ0dHnb4DjUVvKAId uCSOZfbi/TS7IFrxUR7aw2v5eqRewVdSOp/Yw/A+fT8Kkt4pfPLTWA/TPFYvx8sr3YkQ hTgW1bGvlXdY0d+Sv3iuneD6H6kZDRU6pI9gSPM4uw7J5nE7p4N8/EkHf/oId1p5oXzU ozuw== X-Forwarded-Encrypted: i=1; AJvYcCU8vYAbxILog5facrWBupW8mjvPQiZwKKvf1IUTInpBVQFNZ+bdGp32EipWo0nTAisLHUacoANagSjp8BE=@vger.kernel.org X-Gm-Message-State: AOJu0YyWRh3qZdmqFhd/nGkTquUIL6uBs/HX9nEkeQYlKRs6e73rcEOM jb7l195QO2kOEXafsy18y3XJnK67+c/wLtinbXWoOKWgQMHscA1+zp5duYubfJc= X-Google-Smtp-Source: AGHT+IEUw2ClrCHZwzq1ZRV562eGADDxdcjSOnOQEZkmnCKWFyddq0xvCP5HqungbQ1iEQ/0y/yZeQ== X-Received: by 2002:a05:6a21:6d90:b0:1c4:f30e:97ff with SMTP id adf61e73a8af0-1c90509322amr8886710637.9.1724060046565; Mon, 19 Aug 2024 02:34:06 -0700 (PDT) Received: from [192.168.104.75] ([223.118.50.121]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-201f0303285sm59630475ad.26.2024.08.19.02.33.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Aug 2024 02:34:06 -0700 (PDT) Message-ID: <84629569-c5e3-4900-aa54-82be24369f74@linuxfoundation.org> Date: Mon, 19 Aug 2024 03:33:56 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: fix relative rpath usage To: Eugene Syromiatnikov Cc: linux-kselftest@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Mark Brown , Shuah Khan , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Mathieu Desnoyers , Peter Zijlstra , "Paul E. McKenney" , Boqun Feng , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, Artem Savkov , Shuah Khan References: <20240812165650.GA5102@asgard.redhat.com> <3667e585-ecaa-4664-9e6e-75dc9de928e8@linuxfoundation.org> <20240813163348.GA30739@asgard.redhat.com> <20240814122513.GA18728@asgard.redhat.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240814122513.GA18728@asgard.redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/14/24 06:25, Eugene Syromiatnikov wrote: > On Wed, Aug 14, 2024 at 05:14:08AM -0600, Shuah Khan wrote: >> On 8/13/24 10:33, Eugene Syromiatnikov wrote: >>> On Mon, Aug 12, 2024 at 05:03:45PM -0600, Shuah Khan wrote: >>>> On 8/12/24 10:56, Eugene Syromiatnikov wrote: >>>>> The relative RPATH ("./") supplied to linker options in CFLAGS is resolved >>>>> relative to current working directory and not the executable directory, >>>>> which will lead in incorrect resolution when the test executables are run >>>> >from elsewhere. Changing it to $ORIGIN makes it resolve relative >>>>> to the directory in which the executables reside, which is supposedly >>>>> the desired behaviour. This patch also moves these CFLAGS to lib.mk, >>>>> so the RPATH is provided for all selftest binaries, which is arguably >>>>> a useful default. >>>> >>>> Can you elaborate on the erros you would see if this isn't fixed? I understand >>>> that check-rpaths tool - howebver I would like to know how it manifests and >>> >>> One would be unable to execute the test binaries that require additional >>> locally built dynamic libraries outside the directories in which they reside: >>> >>> [build@builder selftests]$ alsa/mixer-test >>> alsa/mixer-test: error while loading shared libraries: libatest.so: cannot open shared object file: No such file or directory >>> >>>> how would you reproduce this problem while running selftests? >>> >>> This usually doesn't come up in a regular selftests usage so far, as they >>> are usually run via make, and make descends into specific test directories >>> to execute make the respective make targets there, triggering the execution >>> of the specific test bineries. >>> >> >> Right. selftests are run usually via make and when they are installed run through >> a script which descends into specific test directories where the tests are installed. >> >> Unless we see the problem using kselftest use-case, there is no reason the make changes. > > The reason has been outlined in the commit message: relative paths in > RPATH/RUNPATH are incorrect and ought to be fixed. > >> Sorry I am not going be taking these patches. > > I see, by the same token, kernel maintainers reject any patches that fix > compilation/build warnings, I guess. > No - compilation and build warnings are accepted. This doesn't fall into that case. As you mentioned you can't reproduce this using the kselftest use-cases. Hence the reason to reject. thanks, -- Shuah