From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E74E4239099 for ; Sat, 7 Mar 2026 17:30:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772904651; cv=none; b=pyW8Zs3ufWXk6//XSrSF+kY5EYimOgCSgZ/TDXk2S1K8qTZGw9lDJ2sPm0jHv+yddGsbwB0o9yvwUPzeke3zFr8/7jJn1S9WcCeLlKo8cW6N0RFOAb2rbG6LeptVe6P6PXrKk9QcdXw58GHWJ9lGbf3966xajJOkgC/cRE38me8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772904651; c=relaxed/simple; bh=m89L82vCOIYwlaqtEXxfMdClJNyoSgW1XydJZTxQh5w=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=jwNm9eSPc6rg1LA2NQl7bl+7KaFqLd7nA4WqHhWmFZ6+18YNp13Vr6PtCbh3WfUdPDFGwdv3TePNUdhNmVlRe97W8WcbEawbgPLho534QuM4a4EW+XfFOARPHFADKPp8vYfGDotP8DqYOXDKePxK4lCmJ4Hyx1vkD3u+jl7Ug8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=He5mNKv9; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="He5mNKv9" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4852ff06541so5251105e9.2 for ; Sat, 07 Mar 2026 09:30:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772904648; x=1773509448; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=m89L82vCOIYwlaqtEXxfMdClJNyoSgW1XydJZTxQh5w=; b=He5mNKv91+pdr1mn27uWJ7idPj60hmEgNPF64yfwW6ZXk+db7CbJAhxM01+pR+hJCL rnrTMqqpF6TlINehyzc9vXAuF9Nr9Qw99UgLInjDGGv5rKSZiXbkO+gcyBYWuU8SS57S /B+YuhKk87ClW7vbVSbkNRCPICWEqrAYoRBthWab3kEG35oKVBF7avggkEUg7Z6NPjrM pbY/5vQXPFjlb9nncKgCNEuRAp23OGJpEilsCKgWE2nLzYcoVD+yDVai06e5UbeE+WUb OzN/9f6SFAWMefx88IDPEszSmgI8TRyJF3nIwxbsMBKiZOziXeb3PGG9qLGBbbkqv028 TcRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772904648; x=1773509448; h=content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:from:date:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=m89L82vCOIYwlaqtEXxfMdClJNyoSgW1XydJZTxQh5w=; b=WRbwtTXzNJdGvlVgg4SjobEr08KJbZdh10nzsi5NSnozeY0wnX4XoYBRXX57498JIn W+411mj5yQZ++yENGN9UvQJ2QpwRK+J0xF7Pp5Wk+2qAyAw1VRkDkHjA54dILRStO2Qu JqYbTmCxt2HojNKVtxV5GwOpJOIv07o2HHikVn1pL1S14l4qs6EiJ5t9bdz/s8tGhxiH JDj8z1MXA28iOJ2MzRr8oLTd934hLfHvBcnsBYZUu2jAeTO+J+bY70Hcxa60hI+xQNVn u1hso5J5ORCvFuqvN9VQIE++Z/LTI/3O8yC8/JLXrNzAKItTnALdH6aYvVDWuZGSkNxO NXIw== X-Forwarded-Encrypted: i=1; AJvYcCVneAQWsMaGzl3ZtlaZTDHkkzx/Rqf/ZljFUfJggrVu6scoORNU//1FMsLNRIwVdU43kdfwAlnR3jjpCMM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy9I9kM2utB+a4POSUEDRuXC8i8Z1cUfW2fnCbeChnNXqPmW3SI BHP5JxxL9v6aVxJ93jkG5VKjNl7RmH1GoPfOBpwNsbCadjqC0hYlyC1R X-Gm-Gg: ATEYQzztOXwv8TGOvJLHB4dna1/ox9yUNMpVdqalz/njs1leTz2QbArlpVVD5HpW/JS zPyjXmFzy8y1imz6zDEiX5eBGW0eSyVDROS+07bybJsEhs9eT2ySaS2R6R/8ogqx80+eJ4MGPMf RMq6soXY2E7MfEfqVfi9w/1XMq+vRHbSRGhy4DWOwhcaMFJdLJZb0nNCuq7L8pgfidE1Q1hgfjk 8XlvxlDKJ8hFXvc9K+UqXbxeNkQs1+LgTv2+rHRDmCeQ0TnJexwqBkxOE/6iNk14YPTSfvIB0Di 8g8+VBcVnDntkLySDFBP4d83CovoJwQPBWMySMFr227+XjRdkK6MNQj6oSfrzEZqzPu31SPlrsP r288OUUPL83Cg5SZSQLsxNqfiRjinPSdVj7xR5kR5+ims7Ot9DiIxO7W0t7YOvtDYT3b/d+KB1u VCRq5XYTt/jhfi1m0i X-Received: by 2002:a05:600c:3b0c:b0:477:5b0a:e616 with SMTP id 5b1f17b1804b1-485269188admr100391575e9.5.1772904647869; Sat, 07 Mar 2026 09:30:47 -0800 (PST) Received: from [127.0.0.1] ([86.1.69.5]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4851fb3666asm179127335e9.14.2026.03.07.09.30.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Mar 2026 09:30:47 -0800 (PST) Date: Sat, 7 Mar 2026 17:30:46 +0000 From: Josh Law To: Kuan-Wei Chiu Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Josh Law Message-ID: <8464111d-2f31-4682-adba-b50a8feff342@gmail.com> In-Reply-To: References: <20260306161647.2811874-1-objecting@objecting.org> Subject: Re: [PATCH] lib/inflate: fix memory leak in inflate_dynamic() on inflate_codes() failure Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Correlation-ID: <8464111d-2f31-4682-adba-b50a8feff342@gmail.com> 7 Mar 2026 17:12:03 Kuan-Wei Chiu : > Hi Josh, > > On Fri, Mar 06, 2026 at 04:16:47PM +0000, Josh Law wrote: >> When inflate_codes() fails in inflate_dynamic(), the code jumps to the >> 'out' label which only frees 'll', leaking the Huffman tables 'tl' and >> 'td'. Restructure the code so that the decoding tables are always freed >> before reaching the 'out' label. >> >> Signed-off-by: Josh Law > > The change itself looks good. > However, IIRC, this isn't the first time I've complained about the > following checkpatch.pl warning: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law ' !=3D 'Signed-off-by: Josh Law ' > > Regards, > Kuan-Wei > >> --- >> lib/inflate.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/lib/inflate.c b/lib/inflate.c >> index 5b1e70d0ce8c..ae704e4f64ec 100644 >> --- a/lib/inflate.c >> +++ b/lib/inflate.c >> @@ -1009,10 +1009,10 @@ DEBG("dyn5d "); >> DEBG("dyn6 "); >> >> =C2=A0=C2=A0 /* decompress until an end-of-block code */ >> -=C2=A0 if (inflate_codes(tl, td, bl, bd)) { >> +=C2=A0 if (inflate_codes(tl, td, bl, bd)) >> =C2=A0=C2=A0=C2=A0=C2=A0 ret =3D 1; >> -=C2=A0=C2=A0=C2=A0 goto out; >> -=C2=A0 } >> +=C2=A0 else >> +=C2=A0=C2=A0=C2=A0 ret =3D 0; >> >> DEBG("dyn7 "); >> >> @@ -1021,7 +1021,6 @@ DEBG("dyn7 "); >> =C2=A0=C2=A0 huft_free(td); >> >> =C2=A0=C2=A0 DEBG(">"); >> -=C2=A0 ret =3D 0; >> out: >> =C2=A0=C2=A0 free(ll); >> =C2=A0=C2=A0 return ret; >> -- >> 2.43.0 >> >> Hello Kuan, I did take your criticism and I fixed it, (by overriding the fr= om: in the email to the from: in the changelog) but some things fall under = the cracks sometimes, Andrew did fix it.. V/R Josh law