Re: [PATCH v2 2/2] platform/x86: bitland-mifs-wmi: Don't fail suspend or resume on profile errors

[Mingyou Chen <qby140326@gmail.com>]

On 10/26/26 17:48, Chris Taraszka wrote:
> On Mon, 26 Oct 2026, Mingyou Chen wrote:
>> What value does the firmware respond?
>>
>> This patch fixes the suspend problem, but it hides the real driver
>> problem (unsupported profile entry).
>>
>> I saw 0x04 in your patch "platform/x86: bitland-mifs-wmi: Add Xiaomi
>> Book Pro 14 quirk".
>>
>> If result.data[0] in laptop_profile_get actually equals 0x04, the
>> function should be succeed, but it doesn't.
> Hi Mingyou,
>
> It does succeed with patch 1. The firmware returns 0x04 (I also read it

Apologies, I misunderstood; I assume the "patch 1" you referred to is 
the one that adds the MAINTAINERS entries

of my v13.

> back from EC 0x68), and with the TM2424 entry laptop_profile_get() maps
> it to performance. Since then the machine has suspended and resumed
> several times without the warning.
>
> The test in the notes was run without patch 1 on purpose, on the v13
> default table, where 0x04 is not listed. That is the state of every
> Bitland machine that has no entry yet: the TM2424 before patch 1, the
> TM2107 before Matias' patch, and whatever model comes next. On those,
> the aborted suspend is what users hit first. Before I knew the mode
> values, logind retried the suspend every 15 seconds with the lid
> closed, and the laptop drained about 40 Wh in one night.

This is a good point, so

Reviewed-by: Mingyou Chen <qby140326@gmail.com>
>> Is there another no_set (for read only) profile entry for the
>> performance profile?
> No. GET only ever returned 0x02, 0x03, 0x04, 0x09 and 0x0a here, and
> all five are in the table.
>
> So patch 2 does not hide a problem on this machine. On a machine
> without an entry it keeps suspend working, and the "Failed to save
> platform profile" warning still shows that the table needs an entry.
>
> Thanks for the review of patch 1.
>
> Chris