From: Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
To: Christoph Hellwig <hch@infradead.org>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<bhelgaas@google.com>, <gwshan@linux.vnet.ibm.com>
Subject: Re: [PATCH] pci: add missing __iomem cast
Date: Fri, 21 Jul 2017 12:38:32 +0100 [thread overview]
Message-ID: <84660edf-3a19-0400-4fa7-8f26ae5e4218@synopsys.com> (raw)
In-Reply-To: <20170720080742.GA22116@infradead.org>
Hi Christoph,
Looking deep into to this, i think there is no need to use phy_to_virts since pdev->rom is already a physical address.
That's what pci_platform_rom should return, right?!
I'll probably send a new patch removing the usage of phys_to_virt.
Regards,
C.Palminha
On 20-07-2017 09:07, Christoph Hellwig wrote:
> On Wed, Jul 19, 2017 at 01:05:35PM +0100, Carlos Palminha wrote:
>> Add missing __iomem annotation to fix sparse warning:
>> - incorrect type in return expression (different address spaces)
>
> How is this going to shut up sparse without a __force?
>
> And once you add the __force please also add a comment explaining
> why it's safe.
>
prev parent reply other threads:[~2017-07-21 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 12:05 Carlos Palminha
2017-07-20 8:07 ` Christoph Hellwig
2017-07-21 11:38 ` Carlos Palminha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84660edf-3a19-0400-4fa7-8f26ae5e4218@synopsys.com \
--to=carlos.palminha@synopsys.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®