From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012038.outbound.protection.outlook.com [40.93.195.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A7BD26B764 for ; Mon, 19 Jan 2026 06:43:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.195.38 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768805004; cv=fail; b=goZArHtFHs6PTTlQKZ4O6IcTTWM3xT1X/8C8pI+owDfj14ZF5rIuPVXIigr81ngkb1Hxl7VaT/4r9jBcVIiiiuHNLVve1/Bu+AvCHOJl8wseIbpbt2HcOKais8tE5Uy5uY+vais9R3GycxUGoYz2kFJaxj9qxD4kvd5RZ63V0KY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768805004; c=relaxed/simple; bh=IcvgAWqblALpQcU2LN3FYB83/5qg2F6sd058KQbY8YI=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=qXYFBIEFVmUNqOpZp/HF4l8mlFjbVliYHxn8/C15q6iXBUsaLcrhChJViV4+QaDu0KiTPq92558f3BDRmVYwvTMJP51uuDAKIQ0kbbi+xMZCRkbQkmLPbrJ7BKJpgB3joSKPbW9cMihXmZ2Y23k9k7YxiA2hi9ZXGgVqr9AzdrY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=iYjzgqA4; arc=fail smtp.client-ip=40.93.195.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="iYjzgqA4" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=M4TLMyHIcuzb1qz0zW1zJcS3TcnrG5SfyfKd1iow1jJhmoXz/+1nnVyGd5o0FAvJbmNuFbwx1StNDOc+sP29IctfWkoVk6amUZu1tWWeI5YGJoi7yy+rS85ImYhFD+fRvGP7zKvrytYR9xPZpZBMywcQ1BUSpZ88Xx9ySatfVffBpIaDVY6TxISh0rmFKw7aFa6FCV/8CsYE+uYNFb/yt6t0jjS6qsyZvTp6h9UUuAe9FQ7Y/oO9UwSVcsgyEmcaMjPrbIq+kcEKENKR8C5l4Fghd0LS2pPOfV8xT10qLP0C0NWeonEzOkZ1Fx13oK+SwN5e2LW4KNn8MTN5GOt72Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GqTkhyrpgisPLF55VE2blMBDVKUPaV038BZO+8Zq0fs=; b=jL04e6xM8yC0zk35oQK+4gXjrZKGPwWd5dtE12FJFASpgqmI4PRdxwiWfjuZ+zl4eFB1U7GqQZxSc8I71CmsmR6Jkwon5dP4JLLkc6VhHliXBMZG18hTsAP+t7GzIQlBpt63W01zOcSkbnmdRZvJ72jm0EEcLp12dnxsFTPwddExYdN9lQTk/jhFj4BhFw0tCqf0YJLMg+3MZMi+MNsey4EjKnwAVyDX3Hc6aH76euUPxZJMfzbQOcOYx4TzxSOHcrVNqK/6VDaXQe5UCNAI2oSGK2ivFn5CIEnR31ZBAw6H/yiTYMx/6MolFeq1sGDFJ1McTlZWMyB61y/K6zemNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=ncsu.edu smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GqTkhyrpgisPLF55VE2blMBDVKUPaV038BZO+8Zq0fs=; b=iYjzgqA4AWlGHLL6ZNjmysS9DNY56O8kFrp/ZzJdQHHgFoLnMPPkfGojjkRlNopyL+Z0p+xbu7NAVd/itUiPPvjpX8xxpkIqBz+7Cdq7tDsIghJnKIwTvaJX1kj62hELY0M4E0gFCCtbRi2lF8Kf16s/z0SS8xuCFqVURJRYsGo= Received: from DS7PR07CA0019.namprd07.prod.outlook.com (2603:10b6:5:3af::7) by SA5PPF7D510B798.namprd12.prod.outlook.com (2603:10b6:80f:fc04::8d0) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9520.11; Mon, 19 Jan 2026 06:43:20 +0000 Received: from CH3PEPF00000018.namprd21.prod.outlook.com (2603:10b6:5:3af:cafe::ba) by DS7PR07CA0019.outlook.office365.com (2603:10b6:5:3af::7) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9520.12 via Frontend Transport; Mon, 19 Jan 2026 06:43:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by CH3PEPF00000018.mail.protection.outlook.com (10.167.244.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9564.0 via Frontend Transport; Mon, 19 Jan 2026 06:43:19 +0000 Received: from satlexmb10.amd.com (10.181.42.219) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 19 Jan 2026 00:43:19 -0600 Received: from satlexmb08.amd.com (10.181.42.217) by satlexmb10.amd.com (10.181.42.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Mon, 19 Jan 2026 00:43:19 -0600 Received: from [10.85.36.78] (10.180.168.240) by satlexmb08.amd.com (10.181.42.217) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Mon, 19 Jan 2026 00:43:14 -0600 Message-ID: <846a25a5-60d4-4d6c-8d06-cd7b96fce8df@amd.com> Date: Mon, 19 Jan 2026 12:13:13 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 2/3] sched/fair: Remove task_group->se pointer array To: Zecheng Li , Ingo Molnar , "Peter Zijlstra" , Juri Lelli , "Vincent Guittot" CC: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Rik van Riel , Chris Mason , Madadi Vineeth Reddy , Xu Liu , Blake Jones , Josh Don , Nilay Vaish , , Zecheng Li References: <20260118033431.158464-1-zli94@ncsu.edu> <20260118033431.158464-3-zli94@ncsu.edu> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260118033431.158464-3-zli94@ncsu.edu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH3PEPF00000018:EE_|SA5PPF7D510B798:EE_ X-MS-Office365-Filtering-Correlation-Id: b4afe991-92cc-4783-1fc9-08de5726088e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|376014|7416014|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TGpxM2J5R2xlQzZvVkxFajlFcndSOVBPbEkrM2pmYjVGYnBxck8xY2VTOU9h?= =?utf-8?B?cEZTUUkxVnY5eUJTSXFHMVlMSGMvVWdjNW8vUEZTRUwzM21oWDRKbXFtWGNj?= =?utf-8?B?dEMwVTd6OEFsS0tHUDc3NDZlWCtuY3haM3lPZ1BudWRoOU5yc0dWdDRPRklr?= =?utf-8?B?UElvVFU4MW5zL1V2YzlISFo2b0o0NXJ2L0w2YjE0VDRqaWMzWkx5cEJVRFY1?= =?utf-8?B?SGZHeFAyTlloSVpoQ0dOb0ZsRHVMQ082cWoyYUFyNzQ5dHV5WXBGeDJEUk5E?= =?utf-8?B?cWUxQ1BIckNLdXlJLzdUaFBXdXRrWGdzd3dDbCtsR25XYVd2UGxxYStEWlp3?= =?utf-8?B?MlMvTmJCUXMxM0VFemYzMDFqTnN5ajFuYm9MWTMwQTBrdXhsMHpVRjM2cGJK?= =?utf-8?B?eHkzc0RWSWt6TU1KYi91Q25TQmZuQlo1eWZyY0hvNk9mY3BmMG1mclpiMlh6?= =?utf-8?B?ZFgvbDJjNWg5U0pMVnJoTWxtbmR4cnFoZXVqM2l1dE51S1pCUVlPLzFYb1lS?= =?utf-8?B?QkNXQ253LzZLeTZoWVFhaGVzZE5zY2pKd0NyUEJWejc4OFBoQUZ5MEE2WDR3?= =?utf-8?B?ZCtNRFFOSkZNSGFXN09iTWJFb0pUMjNIaDZKejJhem8yWGZyR3BHQnFsY3RY?= =?utf-8?B?Wk1LKzNibVpxdzBDdnpOT1dUU0tNUVhQMjcrWDl4bWZMVlhrZitJa1c5TlNn?= =?utf-8?B?dkpOSXhGd2ZyOWdSc29sbzlBcmRQVjJNaW4ySzUraTZTYThqRlpJaHIwR01H?= =?utf-8?B?eTFqMXlmSitaRE04N3pnNDIxVm1CT3NYTVRSMlYrSVhlRWVzSWVaL016aHoz?= =?utf-8?B?WkJMTXU1c2JIbFhDb0haSDlPM3VTQnVQUTI4cHoyZlBwQ0ZiTi9BK0t5Risw?= =?utf-8?B?SmJ0RlBWMHVtc1FjTzF6YUdtdm8xTytwY05SdFlDVmpGb3ZVdHRDREZxS3Y1?= =?utf-8?B?bHdaSHdaMnVPQUx0RTVDRHZic05QMnpUN3M2bWxWZWhOREVoZmZWTU41cHkx?= =?utf-8?B?QmNPNlNnMC9MU2lMYnJKU01TeHExUmVDR3RRMlNEYytzMUtVam5hQURRd2hW?= =?utf-8?B?L3NqTDBONlhkM2sxN0ZHRTRBTGExWXc0YVhUWDZLM010NU1Rb3QrdW9JSzds?= =?utf-8?B?Y2Z5YTFibVhJMDlvOTZBZlA4UGxRUDVkd1Q3cVBDTHQ5a09NQ1hPNDhVUWc1?= =?utf-8?B?ZS9OaHgzSHF2Nmh0TzZ0aVdMNjJpYm5XeS9LYjBsVlJVRzlDYnRMSks1VjZn?= =?utf-8?B?K1JYWVBwbHZ0ak1wZ25JcnlTUWE5Wnh6aTE5NHVGWDUrTkxWdS8vdnlYNE9t?= =?utf-8?B?Ynh3QXpjY1lhdUVSNmdrRFFadDJ1aGhNRnZRLzdoTFdnQ0pHUGREREFhdGxC?= =?utf-8?B?aW14SUNsTk9FaW5Lay9weVhTdkJ4YVloajdTMDIybUhDUDZjZjZRL1p5MDU5?= =?utf-8?B?RVFUMGxBVVV1bEdxaytXYUhwc1NBdHV5bXh6aWYzN3c3VkpVS0NBclhUUEx4?= =?utf-8?B?YlBod2huZ3dveXgyS0QwbGR1WGRHbTduMmt6eUc4UkNralJQZ1ltQTdGMDZr?= =?utf-8?B?NnhReWIwWUs0bmROUlJYTGord29DbWMxU1lOL1RYVHBxYzhsUGlHK0loUWtV?= =?utf-8?B?Ry9GcUV5ZDFLSjNLS1BVZW5ndG9XaTFRbVhUa3o2M09naXNVRTBHV1JPeFJs?= =?utf-8?B?YlBscS8rYVBuVEdnenRZcXF2NWduUnAwR1BCaGNtOEJTQlMxZkFVWEQ2Uzkw?= =?utf-8?B?aURreGdUa2lWVkRpVUdzSjhZaXpkbXprV2NZZkN4UzAvUUdEK1lMS2YzZ2hG?= =?utf-8?B?NkVEdkRRclVTRTJKSzkxWkJ5czhwM0NtYjFpLzZVVTBiM3N3aytYQkdkMVdt?= =?utf-8?B?YjhCeUxwb2gxUVRabElDc0xlNEo2cXhUSDEzR0ZJSGpVSUNiMlVoZnN0OFJo?= =?utf-8?B?Ly8yYlpkSjRCSzJreEFSTEZsRjBnaGJOcVFKY0VOR0tRZk5DWGpNTXh4Q295?= =?utf-8?B?ZDdHemJOcVo0dWpSUTJmM3paa013ejU3MlVKTG53TDdYUUxuWTFTUkhpeEJI?= =?utf-8?B?NUorenpYODQ2aGJpeWdndFB1ektTSnpRTUY2Ty9Qd1c5SlV1WVJYdjlWdndo?= =?utf-8?B?S2FPZXJzU0NBU1hRTmlWOEJabW50bGVVR2JSTHd2MXYxWmF6YlRuK2xkR1R3?= =?utf-8?Q?LHXkX1z23LoeRYjdGWmRM2Ht7gCdGqpw1ox3zxcLodrP?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(376014)(7416014)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2026 06:43:19.6574 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b4afe991-92cc-4783-1fc9-08de5726088e X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CH3PEPF00000018.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA5PPF7D510B798 Hello Zecheng, On 1/18/2026 9:04 AM, Zecheng Li wrote: > @@ -2201,6 +2200,26 @@ struct cfs_tg_state { > struct sched_entity se; > struct sched_statistics stats; > } __no_randomize_layout; > + > +static inline struct sched_entity *tg_se(struct task_group *tg, int cpu) > +{ > + if (is_root_task_group(tg)) > + return NULL; > + > + struct cfs_tg_state *state = nit. Can you move the declaration of "struct cfs_tg_state *state" to the top of the function. Same for cfs_rq_se(). > + container_of(tg->cfs_rq[cpu], struct cfs_tg_state, cfs_rq); > + return &state->se; > +} > + > +static inline struct sched_entity *cfs_rq_se(struct cfs_rq *cfs_rq) > +{ > + if (is_root_task_group(cfs_rq->tg)) > + return NULL; > + > + struct cfs_tg_state *state = > + container_of(cfs_rq, struct cfs_tg_state, cfs_rq); > + return &state->se; > +} > #endif -- Thanks and Regards, Prateek