From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 296403BADB5 for ; Mon, 11 May 2026 09:20:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491202; cv=none; b=LwCnK2+gwyvsN22tN4l/wDEa2QjPw4Fze1LR4kGA8i4CtbVp5CR/IPQ1yg3anrUv7Lk195PyPAxc6uSgqW22YdbzLL7BU/nNP7vLV7OZK3o/lV76gFB4+Y41KeCYj0odnj3R7uPmuiEN/Z/AFz54oQbsI63HtMoVs7NOXpRy7JM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778491202; c=relaxed/simple; bh=5rJvbkYU1Cds+pHnp8IhQ0uuKul2+jUK58aooICkDOY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SnLtbHPoEK+/c4rQYLd5hCoas5AfzdbcN9y878truIVvT1jszp2W/wlUX3RsOno3OOdhSNJjWk1nOzLHR9FLdsw/Zedqpn5qZdHNQSijvBoJ5HymXde/lh1/oFuPfLpoBVcsZT1rQkTDt4d+tyv9rz3Ab7jcrIn3sCbW7CsiLDI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JZHzioRb; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AjIpo1Vo; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JZHzioRb"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AjIpo1Vo" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64B4Gw25653394 for ; Mon, 11 May 2026 09:20:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OH6IOw4LvlPC74wSQTZMRd3GjpTaSP1yMTLUPKXvH+A=; b=JZHzioRbuAdW9A+A F8Hse+myv4NsfFt4YYPguntfOc31JpA5/rXKY2ZSr14eAYLwBBNZTjxGk5VEFRNb 5QreiuMHN9TZznIVfGMlorc75WzcmQMWhuZHRDkcFVfhmE67EgjyOuSIazEzztpv 0Ton3xKyBzU04DEO3a+ib67bZiWbEfUhPwXvhZifAHlCJ+uCR8axVWt3feBDv/2S CNVULKaRCbhmJ61mAP6kRU/qDfTobp3IQRxdD2iuRfQI9t/jJrrDILBmdYKefj3F TOag/2UVn7V2ZYA8fx3fcLUO8L4lcZP/T93YRbkPRU8BtfQlentk/DQlN+0N1FHV jdgWCw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e37xu91h7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 11 May 2026 09:19:59 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-94de248f59eso173106241.2 for ; Mon, 11 May 2026 02:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778491199; x=1779095999; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OH6IOw4LvlPC74wSQTZMRd3GjpTaSP1yMTLUPKXvH+A=; b=AjIpo1VoXcvPjfFQwctha8aFjGC7/7PaAOSCxd09raSbZLle9DwxGu/iuID3d+VRI9 HoAh3PDkfGPfl84Wiah9W5pK9ITSaY75Vo+7t4EoGElrjDF9onJstPlEiiaPqgouG19b vhTOzjvDOdikRUQ+ne+KGzh5xHEQ6ijbKC5KGs/bn/iO+Sz8FJO2aZY9GXXN1PJnqylz InhDGK3omjZdEu/dkrr7F6kzYMkiszXPVRWVRRHXAuLLz8WY8l0b9QBVGpcAlymDlv1+ K77OgMipZ/eLO9BJvWfliKlouJsY230gWzpzkHwdmE0hC37yPPp3zCIDdr3Ey1xmZX/d ovpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778491199; x=1779095999; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OH6IOw4LvlPC74wSQTZMRd3GjpTaSP1yMTLUPKXvH+A=; b=tUn68zvC9ivdVgmSo8UmOV6kyGeET68PJns12Qjh4LCAym+eAfUj+88cWB6jD1sQR0 w6LcTsEMIQsaNtYPlWztV1rYOoCZboMtNwO9iPi0z4fTBtYc2UcQXLU321FOMUMt6red d8AyhpWDA18l8CJqp5Oi9Jtn0opgbsx3U4FyLP6H32Qxpsc/TYUYCEqg/q962xdi8eh8 1ELXh0LITKI5N/ZdQ385zhkg79LoX60elcTNHnidZ1Ya44jXMA6EqfKPWgndwX4E4kwg DDZimQDsPGAurRGLrtsCxx0ikJtCh4ScMULOQstI/F2pIFPxsXH6nfnO7EiMpQPnoPjE Fo8A== X-Forwarded-Encrypted: i=1; AFNElJ8FL4GQnMLvF4M+Xw5m2h1R3iiLiR0hFgc0o6V9tfmpFYEUvDo3S4P1RTASGv989A4vQNp+FOu/m4/dzms=@vger.kernel.org X-Gm-Message-State: AOJu0YwrKy9g8dYS8gUhUFq0xQrMkvOM1AJqICA+xESLU/6ywyaNH5Hk tGJubRwujcxn3PrGPbp+RHHCGNK5jGOINn/QJuzFbfDavHBe9v5L6VMTNOJxvYkNNkBWFHL+/cv p3ids1pWGWy19uGXUyl1/Tcou6fa/iC3QmPlPXd0hNXo1BtHUi4cxHgl42Z0chQojhU2GlArwnn c= X-Gm-Gg: Acq92OHXLx2Uw7PPo3G33D7/t00/Jt+3Iu8FlrOxEYUBZT+F5zcmU+JUT9/gctaQ2wA mWD75fdEX4kaozwm73MPrGoemMVLeiEX6lQijje+HzYGNL+gkVSce56TcrTpzRQe/bxC5/Hxm1Y y6MFYRp6ljSQfiBWJyyuh8Ph/4TDMHWL40cGyPFNSgMCbNEsyGDAa094YMBU3jwLTyuSvQJsLg1 7rWAZyy8WPioqE/bzlnj/le26/mDLfH1Wy4cfXRkeNq+ODPBXt0svFNHkb3OLam9AaUBjRXVakq bOVHbu9jNi8EaSfOqrQ2b6e4AFBTagztUvL16G3K2u7ZAWVCOgyOLusYmEqWo2wcC7VHdTe8m9i ok4ZWno9TpVKWGR4UDXHkaauhhHylDJHs3P6l9VOGVTXcQ0/bczmE0tjYk2LNiGaDXpDCvMgC/7 jAo9w= X-Received: by 2002:a05:6102:5112:b0:632:c8af:8a8c with SMTP id ada2fe7eead31-632c8af8ef7mr977103137.2.1778491198816; Mon, 11 May 2026 02:19:58 -0700 (PDT) X-Received: by 2002:a05:6102:5112:b0:632:c8af:8a8c with SMTP id ada2fe7eead31-632c8af8ef7mr977090137.2.1778491198360; Mon, 11 May 2026 02:19:58 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bcac3a7fe13sm462890566b.31.2026.05.11.02.19.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 02:19:57 -0700 (PDT) Message-ID: <846c41a5-8f6c-468a-bcc1-d8140051d0de@oss.qualcomm.com> Date: Mon, 11 May 2026 11:19:55 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: qcom: add basic devicetree for Ayaneo Pocket DS gaming console To: azkali.limited@gmail.com, Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Teguh Sobirin References: <20260510-pocketds-v1-0-cf05acec06af@gmail.com> <20260510-pocketds-v1-2-cf05acec06af@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260510-pocketds-v1-2-cf05acec06af@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=EcL4hvmC c=1 sm=1 tr=0 ts=6a019f3f cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=pGLkceISAAAA:8 a=UeHltZ2LXldOZfv8U84A:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTExMDEwMiBTYWx0ZWRfX2khZ8UPRncML nseJGLP5ehw3fD/quRHcD6z3CwghZCSk54seFRzg9I2n4J5n13O8Z+cSDIjKwZA351SAiLTnxRm P49aLgelA8NBw8zOTwoGSlSABgE7kHAMoFdPRv1XKP112rlQ7a+zhsZHM5o7ebXPaIrt4Ox6J4G vJjKQQ/e5pynP+bGjr7J5PO9Qg+ziDRosr9Lmlo+V+KenEeTL+LYPxlUudmZ4iRfWYMuBM87Oot yjgfKBMVYc8pvr0NujqLvxTW430wLAGtJqnZrXM+cliMt8xS/TT+EWhpbrJNVDoXnuv96qhFnw3 7adyNL/bfQqEMSl41T4Nh4mM5Lfn6NvmgyTzPKm2V60xazE6dfaPKskg/HH5aVfmsge7wi8fhin rkHHKu+gTT8MqPzCgjBpQKV5N53Q7B88+xk0oTP1rLd1JBYslqtb3aHwMioq56/cPZfy/+KGGpf oXfgHpxpiSV30H3kJ4Q== X-Proofpoint-ORIG-GUID: 95k1cLcP1SnfS-Z6Kh-bFRojzORFluY3 X-Proofpoint-GUID: 95k1cLcP1SnfS-Z6Kh-bFRojzORFluY3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-11_02,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 malwarescore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605110102 On 5/10/26 6:05 PM, Alexandre Hamamdjian via B4 Relay wrote: > From: Teguh Sobirin > > Add initial device tree support for the Ayaneo Pocket DS gaming > console based on the Qualcomm QCS8550 platform. > > The board file is split into qcs8550-ayaneo-pocket-common.dtsi and > qcs8550-ayaneo-pocketds.dts in anticipation of additional boards in > the same family that share the QCS8550 base. Only the Pocket DS has > been verified on hardware so far; the shared dtsi is intended to pick > up sibling boards as they are submitted. > > Co-developed-by: Alexandre Hamamdjian > Signed-off-by: Alexandre Hamamdjian > Signed-off-by: Teguh Sobirin > --- [...] > + splash_region: splash_region@b8000000 { underscores in node names are frowned upon > + reg = <0x0 0xb8000000 0x0 0x2b00000>; > + label = "cont_splash_region"; Is this label any useful? > + no-map; > + }; > + }; > + > + sound { > + status = "okay"; It's already 'okay' if previously not disabled, please drop this line > + compatible = "qcom,sm8550-sndcard", "qcom,sm8450-sndcard"; > + model = "SM8550-APS"; > + audio-routing = "SpkrLeft IN", "WSA_SPK1 OUT", > + "SpkrRight IN", "WSA_SPK2 OUT", > + "VA DMIC0", "vdd-micb", > + "VA DMIC1", "vdd-micb"; > + > + wsa-dai-link { > + link-name = "WSA Playback"; > + > + cpu { 'co'dec < 'cp'u < 'p'latform > + sound-dai = <&q6apmbedai WSA_CODEC_DMA_RX_0>; > + }; > + > + codec { > + sound-dai = <&spk_amp_l>, > + <&spk_amp_r>, > + <&swr0 0>, > + <&lpass_wsamacro 0>; Please align these entries [...] > + thermal-zones { > + cpuss0-thermal { You should really be overriding nodes by &labels, this is fragile as-is, since even if someone deletes the thermal zone nodes, DTC will happily compile this (and it won't work) > + polling-delay = <200>; > + trips { Let's add an \n between the last property and the followng subnodes > + cpuss0_fan0: trip-point2 { > + temperature = <40000>; > + hysteresis = <3000>; > + type = "passive"; > + }; Please remove the extra \t here and separate subsequent nodes with a \n [...] > + vdd_fan_5v0: vdd-fan-5v0-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vdd_fan_5v0"; > + > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + gpio = <&tlmm 31 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&fan_pwr_active>; property-n property-names file-wide, please > + > + regulator-state-mem { > + regulator-off-in-suspend; > + }; > + }; > + > + vph_pwr: regulator-vph-pwr { > + compatible = "regulator-fixed"; > + regulator-name = " vph_pwr"; stray spaces after " > +&gpu { > + status = "okay"; > + > + zap-shader { Please use the &gpu_zap_shader label to override > + firmware-name = "qcom/sm8550/a740_zap.mbn"; > + }; > +}; > + > +&gpu_opp_table { > + /* Additional speedbin for Adreno A32 > + * 719000000 RPMH_REGULATOR_LEVEL_SVS_L2 > + * 746000000 RPMH_REGULATOR_LEVEL_NOM > + * 794000000 RPMH_REGULATOR_LEVEL_NOM_L1 > + * 827000000 RPMH_REGULATOR_LEVEL_TURBO > + * 860000000 RPMH_REGULATOR_LEVEL_TURBO_L1 > + * 1000000000 RPMH_REGULATOR_LEVEL_TURBO_L2 > + */ > + opp-719000000 { > + opp-hz = /bits/ 64 <719000000>; > + opp-level = ; > + opp-peak-kBps = <10687500>; // Level 7 Let's drop these inline comments [...] > +&mdss_dsi0 { > + vdda-supply = <&vreg_l3e_1p2>; > + status = "okay"; Please keep an \n before 'status' [...] > +&mdss_dp0_out { > + data-lanes = <0 1>; > +}; Only 2 lanes? Are the other 2 not wired up? > + > +&pcie0 { > + wake-gpios = <&tlmm 96 GPIO_ACTIVE_HIGH>; > + perst-gpios = <&tlmm 94 GPIO_ACTIVE_LOW>; > + > + max-link-speed = <2>; Are there issues with Gen3-speed links? [...] > +&i2c2 { > + clock-frequency = <400000>; > + status = "okay"; > + > + touchscreen@5d { > + reg = <0x5d>; > + compatible = "goodix,gt911"; > + > + interrupt-parent = <&tlmm>; > + interrupts = <39 IRQ_TYPE_EDGE_FALLING>; > + > + reset-gpios = <&tlmm 38 GPIO_ACTIVE_HIGH>; > + irq-gpios = <&tlmm 39 GPIO_ACTIVE_HIGH>; > + VDDIO-supply = <&vdd_ts>; > + > + touchscreen-size-x = <768>; > + touchscreen-size-y = <1024>; > + > + pinctrl-names = "default"; > + pinctrl-0 = <&ts2_reset>, <&ts2_irq>; > + > + }; Stray \n above Does userspace somehow map these touchpanels to the right display, or do you need to bind them somehow? Konrad