From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41910C433EF for ; Mon, 14 Mar 2022 08:05:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234470AbiCNIGt (ORCPT ); Mon, 14 Mar 2022 04:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58360 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238900AbiCNIEq (ORCPT ); Mon, 14 Mar 2022 04:04:46 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17FC06540 for ; Mon, 14 Mar 2022 01:02:34 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id j17so22545066wrc.0 for ; Mon, 14 Mar 2022 01:02:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=FCTa1MEHZ8RflaCaL+Kv3IB7oupUyUxIYhWpI7cZElk=; b=CPYvO7CXsDtRHFv+aDgUHU3k7MoLfFq17gtgRZR4JdQQpMZli8AiYNEUu+PbzficSb kDLK7fNDlYCoxWfM3BOU2HueKNJDZIK7I8FZ6wWB9ui2crHxS9Xs4NT9/goKSvhMxDaC Su/z3KOd5lN3ajtVx0cM1iXhpFPSDH2ClbJUQMQ4FZayf+7vJ1C2ZcNeR5klliK+Zh8G yC+yUtrQhzURXVIK4aC3wcr1GxrSzO65DF7KDecC6oL00uM9/eG1Nn13sUKmdnUE3x+J HCgbhL6ICpV2tGofvMIQEVBoxio1VM2bYHKzKXhsw+s4FNCnL8RBXUZ86ObcZVOCX5IQ z8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=FCTa1MEHZ8RflaCaL+Kv3IB7oupUyUxIYhWpI7cZElk=; b=Ufv2DGHkHLKcRDSlCrdp07x4kZr5EOqsckvBAKkklBJf0Hj5X3nDYCTzXGJylIoA8E y0FC2ogeQp/vE8uRoDcgy6uLAzpUGHqiLFudN0Q3Bb4hyLzH9JsYbm/xpaRb2RsJ7tFS DZNAaSGyGcVn0vUDaYsxHU1GVkC/koAPelKpw0mLcFz7ELHzqiddHJCEtWCxXjyndl95 dqT1/Y0PIgIOhwCn8n/Jrc2FxS/706AhX5xlkOXE+wqWn/tAyFSCAhygH2NZaJORKKVP T9IAeyDN28M2X4fBzAIntQK6WjC5/tT87eyRodKyJi4ty2fO3dK3aOoiDeQ5qAgIaqqr dnFQ== X-Gm-Message-State: AOAM533T9RMDmZWLyIyZWBYfZac1vrdxmWELXMFqsd71BCkHtmegReyX fc+4RHWMLyrtmq3WUm2e8rnibjxLCadA/A== X-Google-Smtp-Source: ABdhPJygPodjlvvW7OainAGLKsdDvzFoilMLfj02cRFY2jabbkEhO2PBY0GqOsOjtLsFBdJBcYu+Ag== X-Received: by 2002:a5d:51cb:0:b0:203:8dff:e9e4 with SMTP id n11-20020a5d51cb000000b002038dffe9e4mr13637700wrv.512.1647244935364; Mon, 14 Mar 2022 01:02:15 -0700 (PDT) Received: from ?IPV6:2001:861:44c0:66c0:67f0:57f7:2185:6d18? ([2001:861:44c0:66c0:67f0:57f7:2185:6d18]) by smtp.gmail.com with ESMTPSA id o6-20020a5d6846000000b001f044a8e214sm12331808wrw.107.2022.03.14.01.02.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 01:02:14 -0700 (PDT) Message-ID: <846c8a4f-73ed-5003-1c7c-578d580a9833@baylibre.com> Date: Mon, 14 Mar 2022 09:02:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] media: meson-ir-tx: fix platform_get_irq.cocci warning Content-Language: en-US To: Yihao Han , Sean Young , Mauro Carvalho Chehab , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@vivo.com References: <20220310074059.12269-1-hanyihao@vivo.com> From: Neil Armstrong Organization: Baylibre In-Reply-To: <20220310074059.12269-1-hanyihao@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/03/2022 08:40, Yihao Han wrote: > Remove dev_err() messages after platform_get_irq*() failures. > platform_get_irq() already prints an error. > > Generated by: scripts/coccinelle/api/platform_get_irq.cocci > > Signed-off-by: Yihao Han > --- > drivers/media/rc/meson-ir-tx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/rc/meson-ir-tx.c b/drivers/media/rc/meson-ir-tx.c > index 63e1dbf0a4e9..abdb62b16e98 100644 > --- a/drivers/media/rc/meson-ir-tx.c > +++ b/drivers/media/rc/meson-ir-tx.c > @@ -323,10 +323,8 @@ static int __init meson_irtx_probe(struct platform_device *pdev) > return PTR_ERR(ir->reg_base); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq resource found\n"); > + if (irq < 0) > return -ENODEV; > - } > > ir->dev = dev; > ir->carrier = MIRTX_DEFAULT_CARRIER; Reviewed-by: Neil Armstrong