From: John Garry <john.garry@huawei.com>
To: YueHaibing <yuehaibing@huawei.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <chenxiang66@hisilicon.com>,
<b.zolnierkie@samsung.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] scsi: hisi_sas: Fix build error without SATA_HOST
Date: Thu, 2 Apr 2020 10:09:17 +0100 [thread overview]
Message-ID: <8470370b-5359-4b82-ed55-8018f8b60697@huawei.com> (raw)
In-Reply-To: <20200402085812.32948-1-yuehaibing@huawei.com>
On 02/04/2020 09:58, YueHaibing wrote:
> If SATA_HOST is n, build fails:
>
> drivers/scsi/hisi_sas/hisi_sas_main.o: In function `hisi_sas_fill_ata_reset_cmd':
> hisi_sas_main.c:(.text+0x2500): undefined reference to `ata_tf_to_fis'
>
> Select SATA_HOST to fix this.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: bd322af15ce9 ("ata: make SATA_PMP option selectable only if any SATA host driver is enabled")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: John Garry <john.garry@huawei.com>
> ---
> v2: use correct Fixes tag
> ---
> drivers/scsi/hisi_sas/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/hisi_sas/Kconfig b/drivers/scsi/hisi_sas/Kconfig
> index 90a17452a50d..13ed9073fc72 100644
> --- a/drivers/scsi/hisi_sas/Kconfig
> +++ b/drivers/scsi/hisi_sas/Kconfig
> @@ -6,6 +6,7 @@ config SCSI_HISI_SAS
> select SCSI_SAS_LIBSAS
> select BLK_DEV_INTEGRITY
> depends on ATA
> + select SATA_HOST
> help
> This driver supports HiSilicon's SAS HBA, including support based
> on platform device
>
next prev parent reply other threads:[~2020-04-02 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 6:30 [PATCH] " YueHaibing
2020-04-02 7:30 ` John Garry
2020-04-02 8:51 ` Yuehaibing
2020-04-02 8:53 ` Bartlomiej Zolnierkiewicz
2020-04-02 8:58 ` [PATCH v2] " YueHaibing
2020-04-02 9:08 ` Bartlomiej Zolnierkiewicz
2020-04-02 9:09 ` John Garry [this message]
2020-04-13 17:28 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8470370b-5359-4b82-ed55-8018f8b60697@huawei.com \
--to=john.garry@huawei.com \
--cc=b.zolnierkie@samsung.com \
--cc=chenxiang66@hisilicon.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®