From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2873E40098A for ; Wed, 15 Jul 2026 18:08:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784138897; cv=none; b=CgaGO26YjHVfQOd3MBT878cX3y3EgClasXPV0CPYcFxUJW9fESUb9zjZ3P/zKtrYV1SMmh/kw2pQpqzLsKf6db3aRpk+xxGJSJDUw4dTpI0goUIQI11kMcX31E8t4Ruc9WT9Tth9181rLtTCsBL/9hAvXSE87Eh3nZs7QYCOGTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784138897; c=relaxed/simple; bh=mKIBs623jp9oil6dkw2OIDAx86ckyTenDNJ6awWuF0M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uPayFY8pfD+xxoNIQScznHc4WMyj7u5UaCiRokeXPABgLHKDUAv0FVpbCXXcIzjWJSR1P+nytcB/Eoex9/WlcspCoE//0HKe6QGQGpL3216+WeDFWNRPBaGcR8p57XGIMedBP9Or7Fu78UDU88ARZ7JySBKyoVli6EaSHo7OmN0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NT0pazKg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VVKifFiM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NT0pazKg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VVKifFiM" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66FHBJIh1287634 for ; Wed, 15 Jul 2026 18:08:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 4EnkQlStKJrYtpsK0JQwA93q3Oyoc0ORGYNf/iLoitY=; b=NT0pazKg/IrAxKtL WvtsmjqL56BHpjsAj+ReAUtkZiCixk3zbwdhsaqhSgdAUMUahOFWfDSzvDJBuKh+ BPd4ZYaKRWW0wkUXU6DcWOrYw6ElM6CW6Z49AY6cm5Vd1Nzf5PcZIwRcjMyo46PZ 6eC8pjZmP5Au4xOeHH7LdVgcU6Bt6frj5PuDr0sI8N/HJhScpKvONW06CYsow1Zi 9HcbhuFjQAOO7UDpmWKPFYydgAkPmohtGqPbiNgbSZvUDedZ5cH3gmfKZU5ZuzIw FoLmLCTxyydI7kxZ0ODnQ/v1LK86h9Vrit3RE7h1VyPQYSxAV+WEXVpXRpQ+MnK2 X5y57g== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fe68wtkak-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 18:08:11 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c88aab7c1d4so8924499a12.3 for ; Wed, 15 Jul 2026 11:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784138891; x=1784743691; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4EnkQlStKJrYtpsK0JQwA93q3Oyoc0ORGYNf/iLoitY=; b=VVKifFiM1vBedwWkA6AR1GnyJxYWGCFlKAWqOCb+T1w2qW3RqA2AIohVGZRRs/Og+i CBU2MKf+dHpQVIK8Lysf68yZVYCmE2FWCL3iNKRvOY+q5dIIMemV6H/X5uF3mL0/7Kg7 VmF72H0/z3/NEhrwvBPXqRTNyUCKeT3jS+7LcJJr50yhdLRB7f9jkwK9hN1x2u13RUjs UPL3TDhN/aDsoonuwBEsPe5alEzW0WRyudSPPi0jWmWmotAQ1PibqwYivjdGpMsv3TIk QosBnX9vnIIepUZOS0cNpBsCnIljZRUdzqSUDYETsMMbjGXKpI2lPceps/DWqVGbQrs0 x3vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784138891; x=1784743691; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4EnkQlStKJrYtpsK0JQwA93q3Oyoc0ORGYNf/iLoitY=; b=rAEAi+ddZyvu3w0DhWdyquOZODAJWsgw18G0drGqNRX1cNHeggpnwh3rxQG9xqS4cG u2Gnkg8iP/SCdJ8sfBCJT5LaKsFsLIkNrxrYvGfP2rTPntiIoRA7QqSubEKqOebP5Nb9 EAJGece4BahBGhP4Gqz+ww59VXrPPfAxquj/hjND4d2pvGZxLpmG2oROt/gN8anFRBzt NjJg7iSoVcnlc/uOryU2dXR9VXuX3I5q1FUkC9s7EqlXSqH2iGgYailwu4rY3JohVs+A x6ZqPIrqUH4uheFc7DTcwfXkJm71A0DctNsdtezPAxvYnW2xMdY85JFyFI80+24zi69h GLFg== X-Forwarded-Encrypted: i=1; AHgh+Rrn9Q0VTqRDB6tjYfuxLUaesHayr0D+b8BtAO65goZJAW1vXa0j2ns32NZenXrG8lR82zy/NTpsDhDDtzk=@vger.kernel.org X-Gm-Message-State: AOJu0YzK6m/oEM0fjObCwdTUC/OxChG4+kL/CmGC8hZn+e4KWBngqO1P 7caIKmNXqedSj7ZHCEkJFzq+pY8YJSVGJrCnmxI0EHreSQnEc9h5L1HxW0d3HJwNg5vsBw04FyJ 6SsPQ/VGbKYnovwnRv9lXFCig/eOGVYnwdpfT2sJcjridFgBIDI/e5sZ+xyboQrNjduQ= X-Gm-Gg: AfdE7ckM7+DdKDeCdgSBjaLsspfkWviXP14hxiqnFZxs+M+ATwRUG2wLRjB8qy0zp3N KRCRpUT9d5dcJP+O7SViOwUy83l31LBXmqvdxnYUWBDpbjOD1oZso+dcKYJsH5d09hbboEQcqTo tv3LOvTGVsRC23GpNqlPFYps9FSRnyW7VmJchiu26ss5L5jTA4hOfz6J8aIH7pZeEd3h6SW2f+3 OzPabddq2VEh+M+bRsLra7574+GeZOT+n1byPkioEX7f37tVt4c9DKnfPnt6qn0Ad4J8Eup1yS7 5Oj1zrj69Q7F+utQBLU6kyth8lz8U+GWpF1/Ow+Jqu5Roll5zWjnQQfW2+nMfcyhKUYrLffEICN CrNsSKWsdg4FAfx+/Y18bszdi/tR5A+WP1H/YVHZZ0beEttC+ZA== X-Received: by 2002:a05:6a20:cc0e:b0:3c0:9c19:65a0 with SMTP id adf61e73a8af0-3c36c44c6f2mr3864071637.72.1784138890294; Wed, 15 Jul 2026 11:08:10 -0700 (PDT) X-Received: by 2002:a05:6a20:cc0e:b0:3c0:9c19:65a0 with SMTP id adf61e73a8af0-3c36c44c6f2mr3864037637.72.1784138889706; Wed, 15 Jul 2026 11:08:09 -0700 (PDT) Received: from [192.168.1.5] ([122.164.226.74]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cd432e848sm3411187c88.9.2026.07.15.11.08.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 11:08:09 -0700 (PDT) Message-ID: <847396bb-2cc1-4f45-bd81-33ab55d3af6f@oss.qualcomm.com> Date: Wed, 15 Jul 2026 23:38:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] ASoC: qcom: sc8280xp: Add RubikPi 3 sound card support To: Hongyang Zhao , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Daniel Drake , Katsuhiro Suzuki , Matteo Martelli , Binbin Zhou , Srinivas Kandagatla , Jaroslav Kysela , Takashi Iwai , Bjorn Andersson , Konrad Dybcio Cc: Neil Armstrong , Dmitry Baryshkov , Roger Shimizu , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260715-rubikpi-next-20260605-v2-0-67601d7a8581@thundersoft.com> <20260715-rubikpi-next-20260605-v2-5-67601d7a8581@thundersoft.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <20260715-rubikpi-next-20260605-v2-5-67601d7a8581@thundersoft.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Lic4duLBi0RvXn-ZRmgh_erMxUdM5x77 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDE4MCBTYWx0ZWRfX83g+ygYG8ask 7uBSnJ23Q6NRM+BIIbLNOVXq6FpXSA04fvZNuY1GyC1LKrMQdd0MtOzZW4jNSKYUCXNpc2tGw3+ xLZzMf6tl4Q+DC8Z7rp4DGxOBRTBWYhf3fnwFdJXgjP/HGkp+qheLfi3vRKrZ4E0tS1TM193Av8 ZKmEnrWYxhIwuOU3mg7NiWRhjxAm4rikjRUnVyA5omf79RBMvSsoqMOpAV/gPYsKayl77D67BkY 5tl+6vbuC9WlpJ+828PMXSLxB8v+YWawkiSE4KsrPN25M4+RggD9fx32SO3tqWrEwZXlhbG8swA nIZoqmsqv4wjTn1Bgvpk3XRpMyukxFfXkIBnFGhgI75RCPpFvAXbfIks2L8PH7uk6i10TCDW2Bq 5GaCcYaN+cTZJ3pKAy2t1sFJwOsLnIr+arls5HSwj97+NBBYLx8WaMIiAMyWkNVIa93tR0Bs29D /U/17vUG2vDiB8qvrvQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDE4MCBTYWx0ZWRfX3KwdJ/DstwZ8 TEYPGU00Es2cJQr+BZ6W9Lfd2HFoOrs1YXp7BMh2hiICuoDeK8Gdvt4n9lL3O0xX4TLn5Kch45+ 9D0K8z8kz+hH8YmUBKVBWFuBSMIp8TQ= X-Authority-Analysis: v=2.4 cv=LbgMLDfi c=1 sm=1 tr=0 ts=6a57cc8b cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=n9TYrBAzqQq97mF55NlG6Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=Wdb1h0LgAAAA:8 a=0ecicO8UAopkaP5Vd3UA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=j5gyrzqu0rbr1vhfHjzO:22 X-Proofpoint-GUID: Lic4duLBi0RvXn-ZRmgh_erMxUdM5x77 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_04,2026-07-15_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 malwarescore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150180 On 7/15/2026 7:32 PM, Hongyang Zhao wrote: > RubikPi 3 connects an ES8316 codec to the primary MI2S interface for > headset playback and capture, and an LT9611 bridge to the quaternary > MI2S interface for HDMI audio. > > Add board-specific DAI data for these links. Configure both directions > of the primary interface for I2S with normal clock polarity and the > codec as bit and frame clock consumer. Program the LPASS MCLK and BCLK, > drive the ES8316 with its required 19.2 MHz MCLK, and enable the generic > codec jack-detection setup on the playback link. > > Configure the quaternary playback link with the same I2S clock format. > Do not request a codec sysclk for this link because the LT9611 HDMI > codec DAI does not implement set_sysclk(). > > Select this configuration through the RubikPi 3 sound-card compatible. > > Signed-off-by: Hongyang Zhao > --- > sound/soc/qcom/sc8280xp.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/sound/soc/qcom/sc8280xp.c b/sound/soc/qcom/sc8280xp.c > index 885ec1e3e575..1354eecb56c9 100644 > --- a/sound/soc/qcom/sc8280xp.c > +++ b/sound/soc/qcom/sc8280xp.c > @@ -410,6 +410,41 @@ static const struct snd_soc_common qcs6490_priv_data = { > }), > }; > > +static const struct snd_soc_common qcs6490_rubikpi3_priv_data = { > + .driver_name = "qcs6490", > + .dapm_widgets = sc8280xp_dapm_widgets, > + .num_dapm_widgets = ARRAY_SIZE(sc8280xp_dapm_widgets), > + SC8280XP_DAI_DATA( Where is SC8280XP_DAI_DATA() defined? > + { > + .id = PRIMARY_MI2S_RX, > + .codec_dai_fmt = SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_BC_FC, codec_dai_fmt appears to be identical for all MI2S DAIs. Can this be moved into the common initialization path instead of being specified per DAI. > + .mclk_rate = 19200000, Is this mclk frequency fixed ? Typically, audio MCLK is expected to be 12.288 MHz or 24.576 MHz. > + .codec_sysclk_set = true, > + .mi2s_mclk_enable = true, Drop this mclk_enable flag; your already enabled from the codec node. is not ? +&i2c0 { + status = "okay"; + + es8316: audio-codec@11 { + compatible = "everest,es8316"; + reg = <0x11>; + #sound-dai-cells = <0>; + + clocks = <&q6prmcc LPASS_CLK_ID_MCLK_1 LPASS_CLK_ATTRIBUTE_COUPLE_NO>; + clock-names = "mclk"; + > + .mi2s_bclk_enable = true, > + .jack_setup = SC8280XP_JACK_SETUP_CODEC, .jack_setup is not part of snd_soc_common Best regards, Rafi > + }, > + { > + .id = PRIMARY_MI2S_TX, > + .codec_dai_fmt = SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_BC_FC, > + .mclk_rate = 19200000, > + .codec_sysclk_set = true, > + .mi2s_mclk_enable = true, > + .mi2s_bclk_enable = true, > + }, > + { > + .id = QUATERNARY_MI2S_RX, > + .codec_dai_fmt = SND_SOC_DAIFMT_I2S | > + SND_SOC_DAIFMT_NB_NF | > + SND_SOC_DAIFMT_BC_FC, > + } > + ), > +}; > + > static const struct snd_soc_common qcs8275_priv_data = { > .driver_name = "qcs8300", > .dapm_widgets = sc8280xp_dapm_widgets, > @@ -480,6 +515,10 @@ static const struct of_device_id snd_sc8280xp_dt_match[] = { > { .compatible = "qcom,sm8550-sndcard", .data = &sm8550_priv_data }, > { .compatible = "qcom,sm8650-sndcard", .data = &sm8650_priv_data }, > { .compatible = "qcom,sm8750-sndcard", .data = &sm8750_priv_data }, > + { > + .compatible = "thundercomm,qcs6490-rubikpi3-sndcard", > + .data = &qcs6490_rubikpi3_priv_data, > + }, > {} > }; > >